linux-next: build warning after merge of the drm-misc-fixes tree

linux-next: build warning after merge of the drm-misc-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2001 bytes --]

Hi all,

After merging the drm-misc-fixes tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

In file included from include/uapi/linux/posix_types.h:5,
                 from include/uapi/linux/types.h:14,
                 from include/linux/types.h:6,
                 from include/linux/limits.h:6,
                 from include/linux/kernel.h:7,
                 from fs/aio.c:14:
fs/aio.c: In function '__do_compat_sys_io_pgetevents':
include/linux/stddef.h:8:14: warning: initialization of 'unsigned int' from 'void *' makes integer from pointer without a cast [-Wint-conversion]
    8 | #define NULL ((void *)0)
      |              ^
fs/aio.c:2196:38: note: in expansion of macro 'NULL'
 2196 |  struct __compat_aio_sigset ksig = { NULL, };
      |                                      ^~~~
include/linux/stddef.h:8:14: note: (near initialization for 'ksig.sigmask')
    8 | #define NULL ((void *)0)
      |              ^
fs/aio.c:2196:38: note: in expansion of macro 'NULL'
 2196 |  struct __compat_aio_sigset ksig = { NULL, };
      |                                      ^~~~
fs/aio.c: In function '__do_compat_sys_io_pgetevents_time64':
include/linux/stddef.h:8:14: warning: initialization of 'unsigned int' from 'void *' makes integer from pointer without a cast [-Wint-conversion]
    8 | #define NULL ((void *)0)
      |              ^
fs/aio.c:2231:38: note: in expansion of macro 'NULL'
 2231 |  struct __compat_aio_sigset ksig = { NULL, };
      |                                      ^~~~
include/linux/stddef.h:8:14: note: (near initialization for 'ksig.sigmask')
    8 | #define NULL ((void *)0)
      |              ^
fs/aio.c:2231:38: note: in expansion of macro 'NULL'
 2231 |  struct __compat_aio_sigset ksig = { NULL, };
      |                                      ^~~~

Introduced by commit

  de80166a573d ("aio: Fix io_pgetevents() struct __compat_aio_sigset layout")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the vfs-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2281 bytes --]

Hi all,

[Some people didn't get this due to a typo]

This should have been reported against the vfs-fixes tree, sorry.

On Tue, 22 Oct 2019 08:07:34 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the drm-misc-fixes tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> In file included from include/uapi/linux/posix_types.h:5,
>                  from include/uapi/linux/types.h:14,
>                  from include/linux/types.h:6,
>                  from include/linux/limits.h:6,
>                  from include/linux/kernel.h:7,
>                  from fs/aio.c:14:
> fs/aio.c: In function '__do_compat_sys_io_pgetevents':
> include/linux/stddef.h:8:14: warning: initialization of 'unsigned int' from 'void *' makes integer from pointer without a cast [-Wint-conversion]
>     8 | #define NULL ((void *)0)
>       |              ^
> fs/aio.c:2196:38: note: in expansion of macro 'NULL'
>  2196 |  struct __compat_aio_sigset ksig = { NULL, };
>       |                                      ^~~~
> include/linux/stddef.h:8:14: note: (near initialization for 'ksig.sigmask')
>     8 | #define NULL ((void *)0)
>       |              ^
> fs/aio.c:2196:38: note: in expansion of macro 'NULL'
>  2196 |  struct __compat_aio_sigset ksig = { NULL, };
>       |                                      ^~~~
> fs/aio.c: In function '__do_compat_sys_io_pgetevents_time64':
> include/linux/stddef.h:8:14: warning: initialization of 'unsigned int' from 'void *' makes integer from pointer without a cast [-Wint-conversion]
>     8 | #define NULL ((void *)0)
>       |              ^
> fs/aio.c:2231:38: note: in expansion of macro 'NULL'
>  2231 |  struct __compat_aio_sigset ksig = { NULL, };
>       |                                      ^~~~
> include/linux/stddef.h:8:14: note: (near initialization for 'ksig.sigmask')
>     8 | #define NULL ((void *)0)
>       |              ^
> fs/aio.c:2231:38: note: in expansion of macro 'NULL'
>  2231 |  struct __compat_aio_sigset ksig = { NULL, };
>       |                                      ^~~~
> 
> Introduced by commit
> 
>   de80166a573d ("aio: Fix io_pgetevents() struct __compat_aio_sigset layout")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the vfs-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

Hi all,

In commit

  de80166a573d ("aio: Fix io_pgetevents() struct __compat_aio_sigset layout")

Fixes tag

  Fixes: 7a074e96 ("aio: implement io_pgetevents")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vfs-fixes tree

[Guillem Jover]

Hi!

On Tue, 2019-10-22 at 07:44:26 +1100, Stephen Rothwell wrote:
> Fixes tag
> 
>   Fixes: 7a074e96 ("aio: implement io_pgetevents")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

On Tue, 2019-10-22 at 09:35:12 +1100, Stephen Rothwell wrote:
> On Tue, 22 Oct 2019 08:07:34 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > fs/aio.c:2196:38: note: in expansion of macro 'NULL'
> >  2196 |  struct __compat_aio_sigset ksig = { NULL, };
> >       |                                      ^~~~

> > fs/aio.c:2196:38: note: in expansion of macro 'NULL'
> >  2196 |  struct __compat_aio_sigset ksig = { NULL, };
> >       |                                      ^~~~

> > fs/aio.c:2231:38: note: in expansion of macro 'NULL'
> >  2231 |  struct __compat_aio_sigset ksig = { NULL, };
> >       |                                      ^~~~

> > fs/aio.c:2231:38: note: in expansion of macro 'NULL'
> >  2231 |  struct __compat_aio_sigset ksig = { NULL, };
> >       |                                      ^~~~
> > 
> > Introduced by commit
> > 
> >   de80166a573d ("aio: Fix io_pgetevents() struct __compat_aio_sigset layout")

Ugh, sorry about that, I guess I didn't see the warnings in the scroll
back when I built this back then for testing. :/ Sending a new version
fixing both issues.

Thanks,
Guillem

linux-next: Fixes tag needs some work in the vfs-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

Hi all,

In commit

  bcf0d9d4b769 ("ecryptfs: fix unlink and rmdir in face of underlying fs modifications")

Fixes tag

  Fixes: 74dd7c97ea2 "ecryptfs_rename(): verify that lower dentries are still OK after lock_rename()"

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the vfs-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

Hi all,

In commit

  5f85b351d3d6 ("fix return values of seq_read_iter()")

Fixes tag

  Fixes: d4d50710a8b (seq_file: add seq_read_iter)

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

Also, just use

  git log -1 --format='Fixes: %h ("%s")' <commit>

to generate Fixes tags.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the vfs-fixes tree

[Al Viro]

On Fri, Nov 13, 2020 at 08:02:39AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   5f85b351d3d6 ("fix return values of seq_read_iter()")
> 
> Fixes tag
> 
>   Fixes: d4d50710a8b (seq_file: add seq_read_iter)
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long

Dealt with and force-pushed...

>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").
> 
> Also, just use
> 
>   git log -1 --format='Fixes: %h ("%s")' <commit>
> 
> to generate Fixes tags.

OK, will keep that in mind next time...

linux-next: Fixes tag needs some work in the vfs-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

Hi all,

In commit

  595a48eb7b48 ("hostfs: fix memory handling in follow_link()")

Fixes tag

  Fixes: 52b209f7b848 "get rid of hostfs_read_inode()" # v2.6.35+

has these problem(s):

  - Subject has leading but no trailing quotes
  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

The version comment is unneeded as it can be trivially gained from
"git describe".

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]