Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* Coverity: drm_dp_mst_process_up_req(): Null pointer dereferences
@ 2019-11-04 17:42 coverity-bot
  0 siblings, 0 replies; only message in thread
From: coverity-bot @ 2019-11-04 17:42 UTC (permalink / raw)
  To: Lyude Paul; +Cc: Sean Paul, Gustavo A. R. Silva, linux-next

Hello!

This is an experimental automated report about issues detected by Coverity
from a scan of next-20191031 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:

9408cc94eb04 ("drm/dp_mst: Handle UP requests asynchronously")

Coverity reported the following:

*** CID 1487392:  Null pointer dereferences  (FORWARD_NULL)
/drivers/gpu/drm/drm_dp_mst_topology.c: 3710 in drm_dp_mst_process_up_req()
3704
3705     		if (msg->req_type == DP_CONNECTION_STATUS_NOTIFY)
3706     			guid = msg->u.conn_stat.guid;
3707     		else if (msg->req_type == DP_RESOURCE_STATUS_NOTIFY)
3708     			guid = msg->u.resource_stat.guid;
3709
vvv     CID 1487392:  Null pointer dereferences  (FORWARD_NULL)
vvv     Passing null pointer "guid" to "drm_dp_get_mst_branch_device_by_guid", which dereferences it.
3710     		mstb = drm_dp_get_mst_branch_device_by_guid(mgr, guid);
3711     	} else {
3712     		mstb = drm_dp_get_mst_branch_device(mgr, hdr->lct, hdr->rad);
3713     	}
3714
3715     	if (!mstb) {

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487392 ("Null pointer dereferences")
Fixes: 9408cc94eb04 ("drm/dp_mst: Handle UP requests asynchronously")


Thanks for your attention!

-- 
Coverity-bot

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-04 17:42 Coverity: drm_dp_mst_process_up_req(): Null pointer dereferences coverity-bot

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git