linux-next: build warning after merge of the vhost tree

linux-next: build warning after merge of the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

Hi all,

After merging the vhost tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/vhost/vhost.c: In function 'fetch_buf_packed':
drivers/vhost/vhost.c:2568:1: warning: no return statement in function returning non-void [-Wreturn-type]
 2568 | }
      | ^

Introduced by commit

  b65f969494e9 ("vhost: partial infrastructure for vhost")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

Hi all,

After merging the vhost tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/userspace-api/vduse.rst:236: WARNING: Title underline too short.

HOW VDUSE devices reconnectoin works
----------------

Introduced by commit

  2b3fd606c662 ("Documentation: Add reconnect process for VDUSE")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vhost tree

[Michael S. Tsirkin]

On Wed, Mar 22, 2023 at 12:32:31PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the vhost tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> drivers/virtio/virtio_ring.c:2346: warning: Excess function parameter 'vq' description in 'virtqueue_dma_dev'
> 
> Introduced by commit
> 
>   9225f75b9b80 ("virtio_ring: introduce virtqueue_dma_dev()")
> 
> -- 
> Cheers,
> Stephen Rothwell

Fixed up, thanks, no need to repost the patch.

-- 
MST

linux-next: build warning after merge of the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

Hi all,

After merging the vhost tree, today's linux-next build (htmldocs)
produced this warning:

drivers/virtio/virtio_ring.c:2346: warning: Excess function parameter 'vq' description in 'virtqueue_dma_dev'

Introduced by commit

  9225f75b9b80 ("virtio_ring: introduce virtqueue_dma_dev()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vhost tree

[Ricardo Cañuelo]

On 20/12/22 7:01, Michael S. Tsirkin wrote:
> Ricardo I assume you will fix this? Patch on top is ok.

Yes, I'll take a look.

Cheers,
Ricardo

Re: linux-next: build warning after merge of the vhost tree

[Michael S. Tsirkin]

On Tue, Dec 20, 2022 at 10:59:56AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the vhost tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> include/linux/virtio_config.h:74: warning: duplicate section name 'Note'
> include/linux/virtio_config.h:94: warning: expecting prototype for virtio_config_ops(). Prototype was for vq_callback_t() instead
> 
> Revelealed by commit
> 
>   333723e8bc39 ("docs: driver-api: virtio: virtio on Linux")


Ricardo I assume you will fix this? Patch on top is ok.

> -- 
> Cheers,
> Stephen Rothwell

linux-next: build warning after merge of the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]

Hi all,

After merging the vhost tree, today's linux-next build (htmldocs)
produced this warning:

include/linux/virtio_config.h:74: warning: duplicate section name 'Note'
include/linux/virtio_config.h:94: warning: expecting prototype for virtio_config_ops(). Prototype was for vq_callback_t() instead

Revelealed by commit

  333723e8bc39 ("docs: driver-api: virtio: virtio on Linux")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vhost tree

[Ricardo Cañuelo]

Hi Stephen, Michael,

On 11/8/22 3:59, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the vhost tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/driver-api/index.rst:14: WARNING: toctree contains reference to nonexisting document 'driver-api/virtio/index'
> 
> Introduced by commit
> 
>    6355eeb59129 ("docs: driver-api: virtio: virtio on Linux")
> 

The patch that ended up in the vhost tree is only a part of the
complete patch:
https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git/commit/?h=linux-next&id=6355eeb59129a31aed0adb60d174df63a5630f8e

The full patch is this:
https://lore.kernel.org/linux-doc/20220810094004.1250-1-ricardo.canuelo@collabora.com/T/#t

Cheers,
Ricardo

linux-next: build warning after merge of the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

Hi all,

After merging the vhost tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/driver-api/index.rst:14: WARNING: toctree contains reference to nonexisting document 'driver-api/virtio/index'

Introduced by commit

  6355eeb59129 ("docs: driver-api: virtio: virtio on Linux")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vhost tree

[Xuan Zhuo]

On Wed, 9 Mar 2022 14:15:44 +0800, Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote:
> On Wed, 9 Mar 2022 17:13:00 +1100, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > Hi Michael,
> >
> > On Mon, 7 Mar 2022 06:00:27 -0500 "Michael S. Tsirkin" <mst@redhat.com> wrote:
> > >
> > > On Mon, Mar 07, 2022 at 09:12:42PM +1100, Stephen Rothwell wrote:
> > > >
> > > > On Mon, 7 Mar 2022 14:46:40 +0800 Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote:
> > > > >
> > > > > Can you help me test this patch? I don't have an arm environment around me.
> > > > >
> > > > > Thanks
> > > > >
> > > > >
> > > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> > > > > index 1fa2d632a994..4d629d1ea894 100644
> > > > > --- a/drivers/net/virtio_net.c
> > > > > +++ b/drivers/net/virtio_net.c
> > > > > @@ -1820,7 +1820,7 @@ static int virtnet_rx_vq_reset(struct virtnet_info *vi,
> > > > >
> > > > >  err:
> > > > >         netdev_err(vi->dev,
> > > > > -                  "reset rx reset vq fail: rx queue index: %ld err: %d\n",
> > > > > +                  "reset rx reset vq fail: rx queue index: %td err: %d\n",
> > > > >                    rq - vi->rq, err);
> > > > >         virtnet_napi_enable(rq->vq, &rq->napi);
> > > > >         return err;
> > > > > @@ -1870,7 +1870,7 @@ static int virtnet_tx_vq_reset(struct virtnet_info *vi,
> > > > >
> > > > >  err:
> > > > >         netdev_err(vi->dev,
> > > > > -                  "reset tx reset vq fail: tx queue index: %ld err: %d\n",
> > > > > +                  "reset tx reset vq fail: tx queue index: %td err: %d\n",
> > > > >                    sq - vi->sq, err);
> > > > >         virtnet_napi_tx_enable(vi, sq->vq, &sq->napi);
> > > > >         return err;
> > > >
> > > > I had to apply that by hand, but it does work.
> > > >
> > > > Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > >
> > > OK, I squashed this into the problematic patch. Thanks a lot!
> >
> > The warnings have reappeared today :-( and this fixup is not applied.
> > Something got lost in the rebase/rewrite?
>
> Sorry for that.
>
> The patch of the fix I submitted before was not merged locally. When the patch
> set of v7 was released yesterday, this fix patch was not included.

I see that Jason is reviewing, and when he completes the review, I will re-post
the patch set. And according to his meaning, it will be split into two patch
sets.

Thanks.


>
>
> > --
> > Cheers,
> > Stephen Rothwell
> >

Re: linux-next: build warning after merge of the vhost tree

[Xuan Zhuo]

On Wed, 9 Mar 2022 17:13:00 +1100, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Michael,
>
> On Mon, 7 Mar 2022 06:00:27 -0500 "Michael S. Tsirkin" <mst@redhat.com> wrote:
> >
> > On Mon, Mar 07, 2022 at 09:12:42PM +1100, Stephen Rothwell wrote:
> > >
> > > On Mon, 7 Mar 2022 14:46:40 +0800 Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote:
> > > >
> > > > Can you help me test this patch? I don't have an arm environment around me.
> > > >
> > > > Thanks
> > > >
> > > >
> > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> > > > index 1fa2d632a994..4d629d1ea894 100644
> > > > --- a/drivers/net/virtio_net.c
> > > > +++ b/drivers/net/virtio_net.c
> > > > @@ -1820,7 +1820,7 @@ static int virtnet_rx_vq_reset(struct virtnet_info *vi,
> > > >
> > > >  err:
> > > >         netdev_err(vi->dev,
> > > > -                  "reset rx reset vq fail: rx queue index: %ld err: %d\n",
> > > > +                  "reset rx reset vq fail: rx queue index: %td err: %d\n",
> > > >                    rq - vi->rq, err);
> > > >         virtnet_napi_enable(rq->vq, &rq->napi);
> > > >         return err;
> > > > @@ -1870,7 +1870,7 @@ static int virtnet_tx_vq_reset(struct virtnet_info *vi,
> > > >
> > > >  err:
> > > >         netdev_err(vi->dev,
> > > > -                  "reset tx reset vq fail: tx queue index: %ld err: %d\n",
> > > > +                  "reset tx reset vq fail: tx queue index: %td err: %d\n",
> > > >                    sq - vi->sq, err);
> > > >         virtnet_napi_tx_enable(vi, sq->vq, &sq->napi);
> > > >         return err;
> > >
> > > I had to apply that by hand, but it does work.
> > >
> > > Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
> >
> > OK, I squashed this into the problematic patch. Thanks a lot!
>
> The warnings have reappeared today :-( and this fixup is not applied.
> Something got lost in the rebase/rewrite?

Sorry for that.

The patch of the fix I submitted before was not merged locally. When the patch
set of v7 was released yesterday, this fix patch was not included.


> --
> Cheers,
> Stephen Rothwell
>

Re: linux-next: build warning after merge of the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1799 bytes --]

Hi Michael,

On Mon, 7 Mar 2022 06:00:27 -0500 "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> On Mon, Mar 07, 2022 at 09:12:42PM +1100, Stephen Rothwell wrote:
> > 
> > On Mon, 7 Mar 2022 14:46:40 +0800 Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote:  
> > >
> > > Can you help me test this patch? I don't have an arm environment around me.
> > > 
> > > Thanks
> > > 
> > > 
> > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> > > index 1fa2d632a994..4d629d1ea894 100644
> > > --- a/drivers/net/virtio_net.c
> > > +++ b/drivers/net/virtio_net.c
> > > @@ -1820,7 +1820,7 @@ static int virtnet_rx_vq_reset(struct virtnet_info *vi,
> > > 
> > >  err:
> > >         netdev_err(vi->dev,
> > > -                  "reset rx reset vq fail: rx queue index: %ld err: %d\n",
> > > +                  "reset rx reset vq fail: rx queue index: %td err: %d\n",
> > >                    rq - vi->rq, err);
> > >         virtnet_napi_enable(rq->vq, &rq->napi);
> > >         return err;
> > > @@ -1870,7 +1870,7 @@ static int virtnet_tx_vq_reset(struct virtnet_info *vi,
> > > 
> > >  err:
> > >         netdev_err(vi->dev,
> > > -                  "reset tx reset vq fail: tx queue index: %ld err: %d\n",
> > > +                  "reset tx reset vq fail: tx queue index: %td err: %d\n",
> > >                    sq - vi->sq, err);
> > >         virtnet_napi_tx_enable(vi, sq->vq, &sq->napi);
> > >         return err;  
> > 
> > I had to apply that by hand, but it does work.
> > 
> > Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>  
> 
> OK, I squashed this into the problematic patch. Thanks a lot!

The warnings have reappeared today :-( and this fixup is not applied.
Something got lost in the rebase/rewrite?
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vhost tree

[Michael S. Tsirkin]

On Mon, Mar 07, 2022 at 09:12:42PM +1100, Stephen Rothwell wrote:
> Hi,
> 
> On Mon, 7 Mar 2022 14:46:40 +0800 Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote:
> >
> > Can you help me test this patch? I don't have an arm environment around me.
> > 
> > Thanks
> > 
> > 
> > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> > index 1fa2d632a994..4d629d1ea894 100644
> > --- a/drivers/net/virtio_net.c
> > +++ b/drivers/net/virtio_net.c
> > @@ -1820,7 +1820,7 @@ static int virtnet_rx_vq_reset(struct virtnet_info *vi,
> > 
> >  err:
> >         netdev_err(vi->dev,
> > -                  "reset rx reset vq fail: rx queue index: %ld err: %d\n",
> > +                  "reset rx reset vq fail: rx queue index: %td err: %d\n",
> >                    rq - vi->rq, err);
> >         virtnet_napi_enable(rq->vq, &rq->napi);
> >         return err;
> > @@ -1870,7 +1870,7 @@ static int virtnet_tx_vq_reset(struct virtnet_info *vi,
> > 
> >  err:
> >         netdev_err(vi->dev,
> > -                  "reset tx reset vq fail: tx queue index: %ld err: %d\n",
> > +                  "reset tx reset vq fail: tx queue index: %td err: %d\n",
> >                    sq - vi->sq, err);
> >         virtnet_napi_tx_enable(vi, sq->vq, &sq->napi);
> >         return err;
> 
> I had to apply that by hand, but it does work.
> 
> Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>

OK, I squashed this into the problematic patch. Thanks a lot!

> -- 
> Cheers,
> Stephen Rothwell

Re: linux-next: build warning after merge of the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1310 bytes --]

Hi,

On Mon, 7 Mar 2022 14:46:40 +0800 Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote:
>
> Can you help me test this patch? I don't have an arm environment around me.
> 
> Thanks
> 
> 
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 1fa2d632a994..4d629d1ea894 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -1820,7 +1820,7 @@ static int virtnet_rx_vq_reset(struct virtnet_info *vi,
> 
>  err:
>         netdev_err(vi->dev,
> -                  "reset rx reset vq fail: rx queue index: %ld err: %d\n",
> +                  "reset rx reset vq fail: rx queue index: %td err: %d\n",
>                    rq - vi->rq, err);
>         virtnet_napi_enable(rq->vq, &rq->napi);
>         return err;
> @@ -1870,7 +1870,7 @@ static int virtnet_tx_vq_reset(struct virtnet_info *vi,
> 
>  err:
>         netdev_err(vi->dev,
> -                  "reset tx reset vq fail: tx queue index: %ld err: %d\n",
> +                  "reset tx reset vq fail: tx queue index: %td err: %d\n",
>                    sq - vi->sq, err);
>         virtnet_napi_tx_enable(vi, sq->vq, &sq->napi);
>         return err;

I had to apply that by hand, but it does work.

Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the vhost tree

[Xuan Zhuo]

On Mon, 7 Mar 2022 04:17:39 -0500, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Mon, Mar 07, 2022 at 02:46:40PM +0800, Xuan Zhuo wrote:
> > On Mon, 7 Mar 2022 15:40:11 +1100, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > Hi all,
> > >
> > > After merging the vhost tree, today's linux-next build (arm
> > > multi_v7_defconfig) produced this warning:
> > >
> > > drivers/net/virtio_net.c: In function 'virtnet_rx_vq_reset':
> > > drivers/net/virtio_net.c:1823:63: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'int' [-Wformat=]
> > >  1823 |                    "reset rx reset vq fail: rx queue index: %ld err: %d\n",
> > >       |                                                             ~~^
> > >       |                                                               |
> > >       |                                                               long int
> > >       |                                                             %d
> > >  1824 |                    rq - vi->rq, err);
> > >       |                    ~~~~~~~~~~~
> > >       |                       |
> > >       |                       int
> > > drivers/net/virtio_net.c: In function 'virtnet_tx_vq_reset':
> > > drivers/net/virtio_net.c:1873:63: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'int' [-Wformat=]
> > >  1873 |                    "reset tx reset vq fail: tx queue index: %ld err: %d\n",
> > >       |                                                             ~~^
> > >       |                                                               |
> > >       |                                                               long int
> > >       |                                                             %d
> > >  1874 |                    sq - vi->sq, err);
> > >       |                    ~~~~~~~~~~~
> > >       |                       |
> > >       |                       int
> > >
> > > Introduced by commit
> > >
> > >   920ee0c540a2 ("virtio_net: support rx/tx queue reset")
> > >
> >
> >
> > Can you help me test this patch? I don't have an arm environment around me.
> >
> > Thanks
>
>
> You should at least use
> https://mirrors.edge.kernel.org/pub/tools/crosstool/
> to test-build + test on x86.


I reproduced the problem using this method, and verified that this patch fixes
it. I submitted a patch email.

Thanks.

>
> >
> > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> > index 1fa2d632a994..4d629d1ea894 100644
> > --- a/drivers/net/virtio_net.c
> > +++ b/drivers/net/virtio_net.c
> > @@ -1820,7 +1820,7 @@ static int virtnet_rx_vq_reset(struct virtnet_info *vi,
> >
> >  err:
> >         netdev_err(vi->dev,
> > -                  "reset rx reset vq fail: rx queue index: %ld err: %d\n",
> > +                  "reset rx reset vq fail: rx queue index: %td err: %d\n",
> >                    rq - vi->rq, err);
> >         virtnet_napi_enable(rq->vq, &rq->napi);
> >         return err;
> > @@ -1870,7 +1870,7 @@ static int virtnet_tx_vq_reset(struct virtnet_info *vi,
> >
> >  err:
> >         netdev_err(vi->dev,
> > -                  "reset tx reset vq fail: tx queue index: %ld err: %d\n",
> > +                  "reset tx reset vq fail: tx queue index: %td err: %d\n",
> >                    sq - vi->sq, err);
> >         virtnet_napi_tx_enable(vi, sq->vq, &sq->napi);
> >         return err;
> >
> > > --
> > > Cheers,
> > > Stephen Rothwell
> > >
>

Re: linux-next: build warning after merge of the vhost tree

[Michael S. Tsirkin]

On Mon, Mar 07, 2022 at 02:46:40PM +0800, Xuan Zhuo wrote:
> On Mon, 7 Mar 2022 15:40:11 +1100, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > Hi all,
> >
> > After merging the vhost tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> >
> > drivers/net/virtio_net.c: In function 'virtnet_rx_vq_reset':
> > drivers/net/virtio_net.c:1823:63: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'int' [-Wformat=]
> >  1823 |                    "reset rx reset vq fail: rx queue index: %ld err: %d\n",
> >       |                                                             ~~^
> >       |                                                               |
> >       |                                                               long int
> >       |                                                             %d
> >  1824 |                    rq - vi->rq, err);
> >       |                    ~~~~~~~~~~~
> >       |                       |
> >       |                       int
> > drivers/net/virtio_net.c: In function 'virtnet_tx_vq_reset':
> > drivers/net/virtio_net.c:1873:63: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'int' [-Wformat=]
> >  1873 |                    "reset tx reset vq fail: tx queue index: %ld err: %d\n",
> >       |                                                             ~~^
> >       |                                                               |
> >       |                                                               long int
> >       |                                                             %d
> >  1874 |                    sq - vi->sq, err);
> >       |                    ~~~~~~~~~~~
> >       |                       |
> >       |                       int
> >
> > Introduced by commit
> >
> >   920ee0c540a2 ("virtio_net: support rx/tx queue reset")
> >
> 
> 
> Can you help me test this patch? I don't have an arm environment around me.
> 
> Thanks


You should at least use
https://mirrors.edge.kernel.org/pub/tools/crosstool/
to test-build + test on x86.

> 
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 1fa2d632a994..4d629d1ea894 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -1820,7 +1820,7 @@ static int virtnet_rx_vq_reset(struct virtnet_info *vi,
> 
>  err:
>         netdev_err(vi->dev,
> -                  "reset rx reset vq fail: rx queue index: %ld err: %d\n",
> +                  "reset rx reset vq fail: rx queue index: %td err: %d\n",
>                    rq - vi->rq, err);
>         virtnet_napi_enable(rq->vq, &rq->napi);
>         return err;
> @@ -1870,7 +1870,7 @@ static int virtnet_tx_vq_reset(struct virtnet_info *vi,
> 
>  err:
>         netdev_err(vi->dev,
> -                  "reset tx reset vq fail: tx queue index: %ld err: %d\n",
> +                  "reset tx reset vq fail: tx queue index: %td err: %d\n",
>                    sq - vi->sq, err);
>         virtnet_napi_tx_enable(vi, sq->vq, &sq->napi);
>         return err;
> 
> > --
> > Cheers,
> > Stephen Rothwell
> >

Re: linux-next: build warning after merge of the vhost tree

[Xuan Zhuo]

On Mon, 7 Mar 2022 15:40:11 +1100, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> After merging the vhost tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> drivers/net/virtio_net.c: In function 'virtnet_rx_vq_reset':
> drivers/net/virtio_net.c:1823:63: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'int' [-Wformat=]
>  1823 |                    "reset rx reset vq fail: rx queue index: %ld err: %d\n",
>       |                                                             ~~^
>       |                                                               |
>       |                                                               long int
>       |                                                             %d
>  1824 |                    rq - vi->rq, err);
>       |                    ~~~~~~~~~~~
>       |                       |
>       |                       int
> drivers/net/virtio_net.c: In function 'virtnet_tx_vq_reset':
> drivers/net/virtio_net.c:1873:63: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'int' [-Wformat=]
>  1873 |                    "reset tx reset vq fail: tx queue index: %ld err: %d\n",
>       |                                                             ~~^
>       |                                                               |
>       |                                                               long int
>       |                                                             %d
>  1874 |                    sq - vi->sq, err);
>       |                    ~~~~~~~~~~~
>       |                       |
>       |                       int
>
> Introduced by commit
>
>   920ee0c540a2 ("virtio_net: support rx/tx queue reset")
>


Can you help me test this patch? I don't have an arm environment around me.

Thanks


diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 1fa2d632a994..4d629d1ea894 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1820,7 +1820,7 @@ static int virtnet_rx_vq_reset(struct virtnet_info *vi,

 err:
        netdev_err(vi->dev,
-                  "reset rx reset vq fail: rx queue index: %ld err: %d\n",
+                  "reset rx reset vq fail: rx queue index: %td err: %d\n",
                   rq - vi->rq, err);
        virtnet_napi_enable(rq->vq, &rq->napi);
        return err;
@@ -1870,7 +1870,7 @@ static int virtnet_tx_vq_reset(struct virtnet_info *vi,

 err:
        netdev_err(vi->dev,
-                  "reset tx reset vq fail: tx queue index: %ld err: %d\n",
+                  "reset tx reset vq fail: tx queue index: %td err: %d\n",
                   sq - vi->sq, err);
        virtnet_napi_tx_enable(vi, sq->vq, &sq->napi);
        return err;

> --
> Cheers,
> Stephen Rothwell
>

linux-next: build warning after merge of the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1774 bytes --]

Hi all,

After merging the vhost tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/net/virtio_net.c: In function 'virtnet_rx_vq_reset':
drivers/net/virtio_net.c:1823:63: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'int' [-Wformat=]
 1823 |                    "reset rx reset vq fail: rx queue index: %ld err: %d\n",
      |                                                             ~~^
      |                                                               |
      |                                                               long int
      |                                                             %d
 1824 |                    rq - vi->rq, err);
      |                    ~~~~~~~~~~~                                 
      |                       |
      |                       int
drivers/net/virtio_net.c: In function 'virtnet_tx_vq_reset':
drivers/net/virtio_net.c:1873:63: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'int' [-Wformat=]
 1873 |                    "reset tx reset vq fail: tx queue index: %ld err: %d\n",
      |                                                             ~~^
      |                                                               |
      |                                                               long int
      |                                                             %d
 1874 |                    sq - vi->sq, err);
      |                    ~~~~~~~~~~~                                 
      |                       |
      |                       int

Introduced by commit

  920ee0c540a2 ("virtio_net: support rx/tx queue reset")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

Hi all,

After merging the vhost tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/net/virtio_net.c: In function 'start_xmit':
drivers/net/virtio_net.c:1695:15: warning: unused variable 'bytes' [-Wunused-variable]
 1695 |  unsigned int bytes = skb->len;
      |               ^~~~~

Introduced by commit

  b3634a892df4 ("virtio_net: disable cb aggressively")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1416 bytes --]

Hi all,

After merging the vhost tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/device.h:15,
                 from include/linux/virtio.h:9,
                 from drivers/virtio/virtio_mem.c:10:
drivers/virtio/virtio_mem.c: In function 'virtio_mem_init':
drivers/virtio/virtio_mem.c:1720:27: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'uint64_t' {aka 'long long unsigned int'} [-Wformat=]
 1720 |  dev_info(&vm->vdev->dev, "subblock size: 0x%x",
      |                           ^~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
   19 | #define dev_fmt(fmt) fmt
      |                      ^~~
drivers/virtio/virtio_mem.c:1720:2: note: in expansion of macro 'dev_info'
 1720 |  dev_info(&vm->vdev->dev, "subblock size: 0x%x",
      |  ^~~~~~~~
drivers/virtio/virtio_mem.c:1720:46: note: format string is defined here
 1720 |  dev_info(&vm->vdev->dev, "subblock size: 0x%x",
      |                                             ~^
      |                                              |
      |                                              unsigned int
      |                                             %llx

Introduced by commit

  676fa9ba893e ("virtio_mem: convert device block size into 64bit")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1619 bytes --]

Hi all,

After merging the vhost tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

In file included from include/linux/list.h:9,
                 from include/linux/preempt.h:11,
                 from include/linux/spinlock.h:51,
                 from include/linux/seqlock.h:36,
                 from include/linux/time.h:6,
                 from include/linux/stat.h:19,
                 from include/linux/fcntl.h:5,
                 from include/linux/eventfd.h:12,
                 from drivers/vhost/vhost.c:13:
drivers/vhost/vhost.c: In function 'vhost_log_write':
include/linux/kernel.h:844:29: warning: comparison of distinct pointer types lacks a cast
  844 |   (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
      |                             ^~
include/linux/kernel.h:858:4: note: in expansion of macro '__typecheck'
  858 |   (__typecheck(x, y) && __no_side_effects(x, y))
      |    ^~~~~~~~~~~
include/linux/kernel.h:868:24: note: in expansion of macro '__safe_cmp'
  868 |  __builtin_choose_expr(__safe_cmp(x, y), \
      |                        ^~~~~~~~~~
include/linux/kernel.h:877:19: note: in expansion of macro '__careful_cmp'
  877 | #define min(x, y) __careful_cmp(x, y, <)
      |                   ^~~~~~~~~~~~~
drivers/vhost/vhost.c:1968:11: note: in expansion of macro 'min'
 1968 |   u64 l = min(log[i].len, len);
      |           ^~~

Introduced by commit

  b072ae74df17 ("vhost: use vhost_desc instead of vhost_log")

vhost_log::len was u64 and vhost_desc::len is u32 and len is u64.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]