Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Fixes tag needs some work in the sound-asoc tree
@ 2020-07-29 22:04 Stephen Rothwell
  0 siblings, 0 replies; 32+ messages in thread
From: Stephen Rothwell @ 2020-07-29 22:04 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Dan Murphy


[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

Hi all,

In commit

  e5448d7ec656 ("ASoC: tlv320adcx140: Fix various style errors and warnings")

Fixes tag

  Fixes: 689c7655b50 ("ASoC: tlv320adcx140: Add the tlv320adcx140 codec driver family")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

Just a hint for the future.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* linux-next: Fixes tag needs some work in the sound-asoc tree
@ 2020-04-06 21:49 Stephen Rothwell
  0 siblings, 0 replies; 32+ messages in thread
From: Stephen Rothwell @ 2020-04-06 21:49 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Julia Lawall


[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

Hi all,

In commit

  7506baeed8d0 ("ASoC: stm32: sai: Add missing cleanup")

Fixes tag

  Fixes: commit 0d6defc7e0e4 ("ASoC: stm32: sai: manage rebind issue")

has these problem(s):

  - leading word 'commit' unexpected

Also, please keep all the commit tags together at the end of the commit
message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* linux-next: Fixes tag needs some work in the sound-asoc tree
@ 2020-03-29  0:09 Stephen Rothwell
  0 siblings, 0 replies; 32+ messages in thread
From: Stephen Rothwell @ 2020-03-29  0:09 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Dan Murphy


[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

Hi all,

In commit

  d4061518c398 ("ASoC: tlv320adcx140: Remove undocumented property")

Fixes tag

  Fixes: 302c0b7490cd ("dt-bindings: sound: Add TLV320ADCx140 dt

has these problem(s):

  - Target SHA1 does not exist

Maybe yuou meant

Fixes: 4ee67cbd9766 ("dt-bindings: sound: Add TLV320ADCx140 dt bindings")

Also, please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: linux-next: Fixes tag needs some work in the sound-asoc tree
  2020-03-14 10:50 Stephen Rothwell
@ 2020-03-16  8:21 ` Kai Vehmanen
  0 siblings, 0 replies; 32+ messages in thread
From: Kai Vehmanen @ 2020-03-16  8:21 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Liam Girdwood, Linux Next Mailing List,
	Linux Kernel Mailing List, Kai Vehmanen, Pierre-Louis Bossart

Hi,

On Sat, 14 Mar 2020, Stephen Rothwell wrote:

> n commit
>   5c82813ce43e ("ASoC: Intel: boards: drop reverse deps for SND_HDA_CODEC_HDMI")
> 
> Fixes tag
>   Fixes: aa2b4a5 ('ASoC: Intel: boards: fix incorrect HDMI Kconfig dependency')[
> 
>  - SHA1 should be at least 12 digits long

ack, thanks, this is a plain oversight -- other fixes tags from same 
author (i.e. me) as well as other use of the tag in the sound-asoc tree 
appear fine. So my bad, sorry!

Br, Kai

^ permalink raw reply	[flat|nested] 32+ messages in thread

* linux-next: Fixes tag needs some work in the sound-asoc tree
@ 2020-03-14 10:50 Stephen Rothwell
  2020-03-16  8:21 ` Kai Vehmanen
  0 siblings, 1 reply; 32+ messages in thread
From: Stephen Rothwell @ 2020-03-14 10:50 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Kai Vehmanen,
	Pierre-Louis Bossart


[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

Hi all,

n commit

  5c82813ce43e ("ASoC: Intel: boards: drop reverse deps for SND_HDA_CODEC_HDMI")

Fixes tag

  Fixes: aa2b4a5 ('ASoC: Intel: boards: fix incorrect HDMI Kconfig dependency')

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* linux-next: Fixes tag needs some work in the sound-asoc tree
@ 2020-03-01  5:45 Stephen Rothwell
  0 siblings, 0 replies; 32+ messages in thread
From: Stephen Rothwell @ 2020-03-01  5:45 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Kuninori Morimoto


[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

Hi all,

In commit

  ac5bf39e3968 ("ASoC: soc-dapm: don't use rtd->cpu_dai on for_each_rtd_cpu_dai()")

Fixes tag

  Fixes: commit de6214a33633d ("ASoC: Add multiple CPU DAI support in DAPM")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* linux-next: Fixes tag needs some work in the sound-asoc tree
@ 2020-02-24 22:30 Stephen Rothwell
  0 siblings, 0 replies; 32+ messages in thread
From: Stephen Rothwell @ 2020-02-24 22:30 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Kuninori Morimoto


[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

Hi all,

In commit

  1c5312308c96 ("ASoC: soc-pcm/soc-compress: don't use snd_soc_dapm_stream_stop()")

Fixes tag

  Fixes: commit b0edff42360ab4 ("ASoC: soc-pcm/soc-compress: use snd_soc_dapm_stream_stop() for SND_SOC_DAPM_STREAM_STOP")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: linux-next: Fixes tag needs some work in the sound-asoc tree
  2019-10-15 11:30 Stephen Rothwell
@ 2019-10-15 11:35 ` Peter Ujfalusi
  0 siblings, 0 replies; 32+ messages in thread
From: Peter Ujfalusi @ 2019-10-15 11:35 UTC (permalink / raw)
  To: Stephen Rothwell, Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

Hi Stephen,

On 15/10/2019 14.30, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   a35716a95655 ("ASoC: pcm3168a: Fix serial mode dependent format support")
> 
> Fixes tag
> 
>   Fixes: ("ASoC: pcm3168a: Use fixup instead of constraint for channels and formats")
> 
> has these problem(s):
> 
>   - No SHA1 recognised
> 
> Did you mean
> 
> Fixes: cfc28ac124c4 ("ASoC: pcm3168a: Use fixup instead of constraint for channels and formats")

Not again, I have left out the SHA1 to look it up in linux-next which I
failed to do.

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 32+ messages in thread

* linux-next: Fixes tag needs some work in the sound-asoc tree
@ 2019-10-15 11:30 Stephen Rothwell
  2019-10-15 11:35 ` Peter Ujfalusi
  0 siblings, 1 reply; 32+ messages in thread
From: Stephen Rothwell @ 2019-10-15 11:30 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Peter Ujfalusi


[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

Hi all,

In commit

  a35716a95655 ("ASoC: pcm3168a: Fix serial mode dependent format support")

Fixes tag

  Fixes: ("ASoC: pcm3168a: Use fixup instead of constraint for channels and formats")

has these problem(s):

  - No SHA1 recognised

Did you mean

Fixes: cfc28ac124c4 ("ASoC: pcm3168a: Use fixup instead of constraint for channels and formats")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: linux-next: Fixes tag needs some work in the sound-asoc tree
  2019-08-20 21:04 Stephen Rothwell
@ 2019-08-20 22:27 ` Stephen Rothwell
  0 siblings, 0 replies; 32+ messages in thread
From: Stephen Rothwell @ 2019-08-20 22:27 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Codrin Ciubotariu


[-- Attachment #1: Type: text/plain, Size: 990 bytes --]

Hi all,

These actually relate to the sound-asoc-fixes tree.

On Wed, 21 Aug 2019 07:04:52 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
> 
> In commit
> 
>   0f6fc97501b7 ("ASoC: mchp-i2s-mcc: Wait for RX/TX RDY only if controller is running")
> 
> Fixes tag
> 
>   Fixes: 7e0cdf545a55 ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Did you mean
> 
> Fixes: b87d37d0231f ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller")
> 
> In commit
> 
>   988b59467b2b ("ASoC: mchp-i2s-mcc: Fix unprepare of GCLK")
> 
> Fixes tag
> 
>   Fixes: 7e0cdf545a55 ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Did you mean
> 
> Fixes: b87d37d0231f ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* linux-next: Fixes tag needs some work in the sound-asoc tree
@ 2019-08-20 22:25 Stephen Rothwell
  0 siblings, 0 replies; 32+ messages in thread
From: Stephen Rothwell @ 2019-08-20 22:25 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Codrin Ciubotariu


[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

Hi all,

In commit

  c9cff337eab3 ("ASoC: mchp-i2s-mcc: Fix simultaneous capture and playback in master mode")

Fixes tag

  Fixes: 7e0cdf545a55 ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: b87d37d0231f ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* linux-next: Fixes tag needs some work in the sound-asoc tree
@ 2019-08-20 21:04 Stephen Rothwell
  2019-08-20 22:27 ` Stephen Rothwell
  0 siblings, 1 reply; 32+ messages in thread
From: Stephen Rothwell @ 2019-08-20 21:04 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Codrin Ciubotariu


[-- Attachment #1: Type: text/plain, Size: 772 bytes --]

Hi all,

In commit

  0f6fc97501b7 ("ASoC: mchp-i2s-mcc: Wait for RX/TX RDY only if controller is running")

Fixes tag

  Fixes: 7e0cdf545a55 ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: b87d37d0231f ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller")

In commit

  988b59467b2b ("ASoC: mchp-i2s-mcc: Fix unprepare of GCLK")

Fixes tag

  Fixes: 7e0cdf545a55 ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: b87d37d0231f ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* linux-next: Fixes tag needs some work in the sound-asoc tree
@ 2019-08-15 21:59 Stephen Rothwell
  0 siblings, 0 replies; 32+ messages in thread
From: Stephen Rothwell @ 2019-08-15 21:59 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, YueHaibing


[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

Hi all,

In commit

  bed7f1469f08 ("ASoC: cs4349: Use PM ops 'cs4349_runtime_pm'")

Fixes tag

  Fixes: e40da86 ("ASoC: cs4349: Add support for Cirrus Logic CS4349")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* linux-next: Fixes tag needs some work in the sound-asoc tree
@ 2019-08-15 21:34 Stephen Rothwell
  0 siblings, 0 replies; 32+ messages in thread
From: Stephen Rothwell @ 2019-08-15 21:34 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, YueHaibing


[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

Hi all,

In commit

  9b4275c415ac ("ASoC: cs4349: Use PM ops 'cs4349_runtime_pm'")

Fixes tag

  Fixes: e40da86 ("ASoC: cs4349: Add support for Cirrus Logic CS4349")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: linux-next: Fixes tag needs some work in the sound-asoc tree
  2019-07-26 12:11   ` Mark Brown
@ 2019-07-29  5:57     ` Peter Ujfalusi
  0 siblings, 0 replies; 32+ messages in thread
From: Peter Ujfalusi @ 2019-07-29  5:57 UTC (permalink / raw)
  To: Mark Brown
  Cc: Stephen Rothwell, Liam Girdwood, Linux Next Mailing List,
	Linux Kernel Mailing List

Mark,

On 26/07/2019 15.11, Mark Brown wrote:
> On Fri, Jul 26, 2019 at 09:04:37AM +0300, Peter Ujfalusi wrote:
> 
>> Mark: can you either drop the patch and I'll send a new one with fixed
>> SHA1 or can you fix the commit message in place?
> 
> Both of which involve rebasing :(  Against my better judgement I
> rebased.

thank you and sorry again...

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: linux-next: Fixes tag needs some work in the sound-asoc tree
  2019-07-26  6:04 ` Peter Ujfalusi
@ 2019-07-26 12:11   ` Mark Brown
  2019-07-29  5:57     ` Peter Ujfalusi
  0 siblings, 1 reply; 32+ messages in thread
From: Mark Brown @ 2019-07-26 12:11 UTC (permalink / raw)
  To: Peter Ujfalusi
  Cc: Stephen Rothwell, Liam Girdwood, Linux Next Mailing List,
	Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

On Fri, Jul 26, 2019 at 09:04:37AM +0300, Peter Ujfalusi wrote:

> Mark: can you either drop the patch and I'll send a new one with fixed
> SHA1 or can you fix the commit message in place?

Both of which involve rebasing :(  Against my better judgement I
rebased.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: linux-next: Fixes tag needs some work in the sound-asoc tree
  2019-07-25 21:27 Stephen Rothwell
@ 2019-07-26  6:04 ` Peter Ujfalusi
  2019-07-26 12:11   ` Mark Brown
  0 siblings, 1 reply; 32+ messages in thread
From: Peter Ujfalusi @ 2019-07-26  6:04 UTC (permalink / raw)
  To: Stephen Rothwell, Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

Stephen,

On 26/07/2019 0.27, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   9fcf9139a2fd ("ASoC: ti: davinci-mcasp: Fix clk PDIR handling for i2s master mode")
> 
> Fixes tag
> 
>   Fixes: 2302be4126f52 ("ASoC: davinci-mcasp: Update PDIR (pin direction) register handling")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Did you mean
> 
> Fixes: ca3d9433349e ("ASoC: davinci-mcasp: Update PDIR (pin direction) register handling")

Indeed this is the correct SHA1, looks like the 2302be4126f52 is on TI's
4.19-LTS branch and it got into the commit message because I have
validated first on that before moving on to linux-next.

Mark: can you either drop the patch and I'll send a new one with fixed
SHA1 or can you fix the commit message in place?

Sorry.

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 32+ messages in thread

* linux-next: Fixes tag needs some work in the sound-asoc tree
@ 2019-07-25 21:27 Stephen Rothwell
  2019-07-26  6:04 ` Peter Ujfalusi
  0 siblings, 1 reply; 32+ messages in thread
From: Stephen Rothwell @ 2019-07-25 21:27 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Peter Ujfalusi


[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

Hi all,

In commit

  9fcf9139a2fd ("ASoC: ti: davinci-mcasp: Fix clk PDIR handling for i2s master mode")

Fixes tag

  Fixes: 2302be4126f52 ("ASoC: davinci-mcasp: Update PDIR (pin direction) register handling")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: ca3d9433349e ("ASoC: davinci-mcasp: Update PDIR (pin direction) register handling")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: linux-next: Fixes tag needs some work in the sound-asoc tree
  2019-07-10 16:13 Stephen Rothwell
@ 2019-07-11  0:40 ` Tzung-Bi Shih
  0 siblings, 0 replies; 32+ messages in thread
From: Tzung-Bi Shih @ 2019-07-11  0:40 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Liam Girdwood, Linux Next Mailing List,
	Linux Kernel Mailing List, Kuninori Morimoto

On Thu, Jul 11, 2019 at 12:13 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> In commit
>
>   6cd249cfad68 ("ASoC: max98357a: use mdelay for sdmode-delay")
>
> Fixes tag
>
>   Fixes: cec5b01f8f1c ("ASoC: max98357a: avoid speaker pop when playback
>
> has these problem(s):
>
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more than one line. Also, don't
> include blank lines among the tags.
I am sorry for this fault.

Mark, do you need me to resend the patch to fix the commit message?

^ permalink raw reply	[flat|nested] 32+ messages in thread

* linux-next: Fixes tag needs some work in the sound-asoc tree
@ 2019-07-10 16:13 Stephen Rothwell
  2019-07-11  0:40 ` Tzung-Bi Shih
  0 siblings, 1 reply; 32+ messages in thread
From: Stephen Rothwell @ 2019-07-10 16:13 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Tzung-Bi Shih, Kuninori Morimoto


[-- Attachment #1: Type: text/plain, Size: 719 bytes --]

Hi all,

In commit

  52db6685932e ("ASoC: simple_card_utils.h: care NULL dai at asoc_simple_debug_dai()")

Fixes tag

  Fixes: commit 0580dde59438 ("ASoC: simple-card-utils: add asoc_simple_debug_info()")

has these problem(s):

  - leading word 'commit' unexpected

In commit

  6cd249cfad68 ("ASoC: max98357a: use mdelay for sdmode-delay")

Fixes tag

  Fixes: cec5b01f8f1c ("ASoC: max98357a: avoid speaker pop when playback

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line. Also, don't
include blank lines among the tags.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* linux-next: Fixes tag needs some work in the sound-asoc tree
@ 2019-06-30 21:49 Stephen Rothwell
  0 siblings, 0 replies; 32+ messages in thread
From: Stephen Rothwell @ 2019-06-30 21:49 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Kuninori Morimoto


[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

Hi all,

In commit

  8a90efd15ef6 ("ASoC: vc4: vc4_htmi: consider CPU-Platform possibility")

Fixes tag

  Fixes: commit 6c6de1c9e2bf2 ("ASoC: vc4: vc4_hdmi: don't select unnecessary Platform")

has these problem(s):

  - leading word 'commit' unexpected

This as also the case for the whole follogin series of commits :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* linux-next: Fixes tag needs some work in the sound-asoc tree
@ 2019-06-26 13:42 Stephen Rothwell
  0 siblings, 0 replies; 32+ messages in thread
From: Stephen Rothwell @ 2019-06-26 13:42 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Kuninori Morimoto


[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

Hi all,

In commit

  e3303268f9cf ("ASoC: soc-core: don't use soc_find_component() at snd_soc_find_dai()")

Fixes tag

  Fixes: commit b9f2e25c599bb ("ASoC: soc-core: use soc_find_component() at snd_soc_find_dai()")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* linux-next: Fixes tag needs some work in the sound-asoc tree
@ 2019-05-30 22:02 Stephen Rothwell
  0 siblings, 0 replies; 32+ messages in thread
From: Stephen Rothwell @ 2019-05-30 22:02 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Zhu Yingjiang, Pierre-Louis Bossart


[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

Hi all,

In commit

  970c43d17835 ("ASoC: SOF: Intel: hda: use the defined ppcap functions")

Fixes tag

  Fixes: 8a300c8fb17 ("ASoC: SOF: Intel: Add HDA controller for Intel DSP")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* linux-next: Fixes tag needs some work in the sound-asoc tree
@ 2019-05-21 21:31 Stephen Rothwell
  0 siblings, 0 replies; 32+ messages in thread
From: Stephen Rothwell @ 2019-05-21 21:31 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jiaxin Yu


[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

Hi all,

In commit

  e355d3de196f ("ASoC: Mediatek: MT8183: fix compile error")

Fixes tag

  Fixes: 1628fc3f4771 ("ASoC: Mediatek: MT8183: add memory interface data align")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* linux-next: Fixes tag needs some work in the sound-asoc tree
@ 2019-05-17 11:12 Stephen Rothwell
  0 siblings, 0 replies; 32+ messages in thread
From: Stephen Rothwell @ 2019-05-17 11:12 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Shengjiu Wang


[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Hi all,

In commit

  ad6eecbfc01c ("ASoC: cs42xx8: Add regcache mask dirty")

Fixes tag

  Fixes: 0c516b4ff85c ("ASoC: cs42xx8: Add codec driver

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* RE: linux-next: Fixes tag needs some work in the sound-asoc tree
@ 2019-05-17  2:41 S.j. Wang
  0 siblings, 0 replies; 32+ messages in thread
From: S.j. Wang @ 2019-05-17  2:41 UTC (permalink / raw)
  To: Stephen Rothwell, Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

Hi 

   Do I need to resend the patch?

Best regards
Wang shengjiu
> 
> In commit
> 
>   b06c58c2a1ee ("ASoC: fsl_asrc: Fix the issue about unsupported rate")
> 
> Fixes tag
> 
>   Fixes: fff6e03c7b65 ("ASoC: fsl_asrc: add support for 8-30kHz
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not split fixes tags over more that one line.
> 
> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 32+ messages in thread

* linux-next: Fixes tag needs some work in the sound-asoc tree
@ 2019-05-16 22:34 Stephen Rothwell
  0 siblings, 0 replies; 32+ messages in thread
From: Stephen Rothwell @ 2019-05-16 22:34 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Shengjiu Wang


[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

Hi all,

In commit

  b06c58c2a1ee ("ASoC: fsl_asrc: Fix the issue about unsupported rate")

Fixes tag

  Fixes: fff6e03c7b65 ("ASoC: fsl_asrc: add support for 8-30kHz

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split fixes tags over more that one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* linux-next: Fixes tag needs some work in the sound-asoc tree
@ 2019-03-18 11:18 Stephen Rothwell
  0 siblings, 0 replies; 32+ messages in thread
From: Stephen Rothwell @ 2019-03-18 11:18 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jiada Wang


[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

Hi all,

In commit

  825b22e5961a ("ASoC: rsnd: src: fix compiler warnings")

Fixes tag

  Fixes: linux-next commit 7674bec4fc09 ("ASoC: rsnd: update BSDSR/BSDISR handling")

has these problem(s):

  - 'linux-next commit' was unexpected.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: linux-next: Fixes tag needs some work in the sound-asoc tree
  2019-03-17  1:28 ` Stephen Rothwell
@ 2019-03-18 10:08   ` Sylwester Nawrocki
  0 siblings, 0 replies; 32+ messages in thread
From: Sylwester Nawrocki @ 2019-03-18 10:08 UTC (permalink / raw)
  To: Stephen Rothwell, Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

On 3/17/19 02:28, Stephen Rothwell wrote:
> In commit
> 
>   2b13bee38849 ("ASoC: samsung: odroid: Fix clock configuration for 44100 sample rate")
> 
> Fixes tag
> 
>   Fixes: fbeec965b8d1c ("ASoC: samsung: odroid: Fix 32000 sample rate handling")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Did you mean:
> 
>   1d22c337dc8f ("ASoC: samsung: odroid: Fix 32000 sample rate handling"


Yes, I unfortunately used erroneously hash from this -stable commit:
 

commit fbeec965b8d1ca4005f2b63f70fd6ed54a147027
Author: Sylwester Nawrocki <s.nawrocki@samsung.com>
Date:   Wed Mar 14 17:41:13 2018 +0100

    ASoC: samsung: odroid: Fix 32000 sample rate handling
    
    [ Upstream commit 1d22c337dc8f3a25638f7262e7bcb5729a34d140 ]
    
    In case of sample rates lower than 44100 currently there is too low MCLK
    frequency set for the CODEC. Playback fails with following errors:
    
    $ speaker-test -c2 -t sine -f 1500 -l2 -r 32000
    
    Sine wave rate is 1500.0000Hz
    Rate set to 32000Hz (requested 32000Hz)
    Buffer size range from 128 to 131072
    Period size range from 64 to 65536
    Using max buffer size 131072
    Periods = 4
    Unable to set hw params for playback: Invalid argument
    Setting of hwparams failed: Invalid argument
    
    [  497.883700] max98090 1-0010: Invalid master clock frequency
    
    To fix this the I2S root clock's frequency is increased, depending
    on sampling rate.
    
    Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
    Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


-- 
Thanks,
Sylwester

^ permalink raw reply	[flat|nested] 32+ messages in thread

* linux-next: Fixes tag needs some work in the sound-asoc tree
@ 2019-03-17  1:34 Stephen Rothwell
  0 siblings, 0 replies; 32+ messages in thread
From: Stephen Rothwell @ 2019-03-17  1:34 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jiada Wang


[-- Attachment #1: Type: text/plain, Size: 628 bytes --]

Hi all,

In commit

  399706df420e ("ASoC: rsnd: src: fix compiler warnings")

Fixes tag

  Fixes: linux-next commit 7674bec4fc09 ("ASoC: rsnd: update BSDSR/BSDISR handling")

has these problem(s):

  - 'linux-next commit' was unexpected.

In commit

  ba164a49f8f7 ("ASoC: rsnd: src: Avoid a potential deadlock")

Fixes tag

  Fixes: linux-next commit 7674bec4fc09 ("ASoC: rsnd: update BSDSR/BSDISR handling")

has these problem(s):

  - 'linux-next commit' was unexpected.

Just use:

  got log --format='Fixes: %h ("%s")' <commit>

to generate the Fixes tags.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* linux-next: Fixes tag needs some work in the sound-asoc tree
@ 2019-03-17  1:28 ` Stephen Rothwell
  2019-03-18 10:08   ` Sylwester Nawrocki
  0 siblings, 1 reply; 32+ messages in thread
From: Stephen Rothwell @ 2019-03-17  1:28 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Sylwester Nawrocki


[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

Hi all,

In commit

  2b13bee38849 ("ASoC: samsung: odroid: Fix clock configuration for 44100 sample rate")

Fixes tag

  Fixes: fbeec965b8d1c ("ASoC: samsung: odroid: Fix 32000 sample rate handling")

has these problem(s):

  - Target SHA1 does not exist

Did you mean:

  1d22c337dc8f ("ASoC: samsung: odroid: Fix 32000 sample rate handling"

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* linux-next: Fixes tag needs some work in the sound-asoc tree
@ 2019-01-28 20:27 Stephen Rothwell
  0 siblings, 0 replies; 32+ messages in thread
From: Stephen Rothwell @ 2019-01-28 20:27 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Kuninori Morimoto


[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

Hi all,

In commit

  720734a0b66f ("ASoC: soc-core: use for_each_link_codecs() for dai_link codecs V2")

Fixes tag

  Fixes: 50acc7e49 ("ASoC: core: Fix multi-CODEC setups")

has these problem(s):

  - Target SHA1 does not exist

Maybe commit 3f6a125230d8bfcbfe0c06ff0b8eaccbc727acd7?

Fixes tag

  Fixes: 10dff9b0d ("ASoC: soc-core: use for_each_link_codecs() for dai_link codecs")

has these problem(s):

  - SHA1 should be at least 12 digits long

In commit

  141474c6ac7f ("ASoC: Fixup build error for mt6358")

Fixes tag

  Fixes: commit 6a8d4198ca8 ("ASoC: mediatek: mt6358: add codec driver")

has these problem(s):

  - leading word 'commit' unexpected
  - SHA1 should be at least 12 digits long

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

end of thread, back to index

Thread overview: 32+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-29 22:04 linux-next: Fixes tag needs some work in the sound-asoc tree Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2020-04-06 21:49 Stephen Rothwell
2020-03-29  0:09 Stephen Rothwell
2020-03-14 10:50 Stephen Rothwell
2020-03-16  8:21 ` Kai Vehmanen
2020-03-01  5:45 Stephen Rothwell
2020-02-24 22:30 Stephen Rothwell
2019-10-15 11:30 Stephen Rothwell
2019-10-15 11:35 ` Peter Ujfalusi
2019-08-20 22:25 Stephen Rothwell
2019-08-20 21:04 Stephen Rothwell
2019-08-20 22:27 ` Stephen Rothwell
2019-08-15 21:59 Stephen Rothwell
2019-08-15 21:34 Stephen Rothwell
2019-07-25 21:27 Stephen Rothwell
2019-07-26  6:04 ` Peter Ujfalusi
2019-07-26 12:11   ` Mark Brown
2019-07-29  5:57     ` Peter Ujfalusi
2019-07-10 16:13 Stephen Rothwell
2019-07-11  0:40 ` Tzung-Bi Shih
2019-06-30 21:49 Stephen Rothwell
2019-06-26 13:42 Stephen Rothwell
2019-05-30 22:02 Stephen Rothwell
2019-05-21 21:31 Stephen Rothwell
2019-05-17 11:12 Stephen Rothwell
2019-05-17  2:41 S.j. Wang
2019-05-16 22:34 Stephen Rothwell
2019-03-18 11:18 Stephen Rothwell
2019-03-17  1:34 Stephen Rothwell
     [not found] <CGME20190317012907epcas3p129240b3dcef7d974c2fea23c26a76f2a@epcas3p1.samsung.com>
2019-03-17  1:28 ` Stephen Rothwell
2019-03-18 10:08   ` Sylwester Nawrocki
2019-01-28 20:27 Stephen Rothwell

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git