linux-next: build warning after merge of the dma-mapping tree

linux-next: build warning after merge of the dma-mapping tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 945 bytes --]

Hi all,

After merging the dma-mapping tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

In file included from arch/arm/mach-keystone/keystone.c:24:
arch/arm/mach-keystone/keystone.c: In function 'keystone_platform_notifier':
arch/arm/mach-keystone/memory.h:17:34: warning: conversion from 'long long unsigned int' to 'phys_addr_t' {aka 'unsigned int'} changes value from '34359738368' to '0' [-Woverflow]
   17 | #define KEYSTONE_HIGH_PHYS_START 0x800000000ULL
      |                                  ^~~~~~~~~~~~~~
arch/arm/mach-keystone/keystone.c:40:39: note: in expansion of macro 'KEYSTONE_HIGH_PHYS_START'
   40 |   int ret = dma_set_offset_range(dev, KEYSTONE_HIGH_PHYS_START,
      |                                       ^~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  eef520b232c6 ("dma-mapping: introduce DMA range map, supplanting dma_pfn_offset")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the dma-mapping tree

[Christoph Hellwig]

Adding Santosh,

I'm trying to understand the code that Jim changed for the range
dma offsets.  Do I miss something or can the whole DMA offset case
for keystone only happen when CONFIG_LPAE is enabled?  Which means
we could ifdef out this section to avoid the warning?

linux-next: build warning after merge of the dma-mapping tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

Hi all,

After merging the dma-mapping tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/driver-api/infrastructure:50: kernel/dma/mapping.c:258: WARNING: Option list ends without a blank line; unexpected unindent.

Introduced by commit

  7c2645a2a30a ("dma-mapping: allow EREMOTEIO return code for P2PDMA transfers")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the dma-mapping tree

[Logan Gunthorpe]

On 2022-07-27 05:48, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the dma-mapping tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/driver-api/infrastructure:50: kernel/dma/mapping.c:258: WARNING: Option list ends without a blank line; unexpected unindent.
> 
> Introduced by commit
> 
>   7c2645a2a30a ("dma-mapping: allow EREMOTEIO return code for P2PDMA transfers")


Oh, hmm, I thought I addressed this when I added the extra line at the
end of the comment, but it seems the htmldocs is a bit fussier than that
with the white space. 

The only way I can seem to suppress that error is by adding another tab
character in the list; see below.

I'll send a full patch shortly.

Logan

--

diff --git a/kernel/dma/mapping.c b/kernel/dma/mapping.c
index 746d46825d08..99e1e0c9a295 100644
--- a/kernel/dma/mapping.c
+++ b/kernel/dma/mapping.c
@@ -249,15 +249,15 @@ EXPORT_SYMBOL(dma_map_sg_attrs);
  * Returns 0 on success or a negative error code on error. The following
  * error codes are supported with the given meaning:
  *
- *   -EINVAL	An invalid argument, unaligned access or other error
- *		in usage. Will not succeed if retried.
- *   -ENOMEM	Insufficient resources (like memory or IOVA space) to
- *		complete the mapping. Should succeed if retried later.
- *   -EIO	Legacy error code with an unknown meaning. eg. this is
- *		returned if a lower level call returned DMA_MAPPING_ERROR.
- *   -EREMOTEIO	The DMA device cannot access P2PDMA memory specified in
- *		the sg_table. This will not succeed if retried.
- *
+ *   -EINVAL		An invalid argument, unaligned access or other error
+ *			in usage. Will not succeed if retried.
+ *   -ENOMEM		Insufficient resources (like memory or IOVA space) to
+ *			complete the mapping. Should succeed if retried later.
+ *   -EIO		Legacy error code with an unknown meaning. eg. this is
+ *			returned if a lower level call returned
+ *			DMA_MAPPING_ERROR.
+ *   -EREMOTEIO		The DMA device cannot access P2PDMA memory specified
+ *			in the sg_table. This will not succeed if retried.
  */
 int dma_map_sgtable(struct device *dev, struct sg_table *sgt,
 		    enum dma_data_direction dir, unsigned long attrs)

Re: linux-next: build warning after merge of the dma-mapping tree

[Akira Yokosawa]

Hi,

On Wed, 27 Jul 2022 12:32:12 -0600, Logan Gunthorpe wrote:
> On 2022-07-27 05:48, Stephen Rothwell wrote:
>> Hi all,
>> 
>> After merging the dma-mapping tree, today's linux-next build (htmldocs)
>> produced this warning:
>> 
>> Documentation/driver-api/infrastructure:50: kernel/dma/mapping.c:258: WARNING: Option list ends without a blank line; unexpected unindent.
>> 
>> Introduced by commit
>> 
>>   7c2645a2a30a ("dma-mapping: allow EREMOTEIO return code for P2PDMA transfers")
> 
> 
> Oh, hmm, I thought I addressed this when I added the extra line at the
> end of the comment, but it seems the htmldocs is a bit fussier than that
> with the white space. 
> 
> The only way I can seem to suppress that error is by adding another tab
> character in the list; see below.

I think all you need is to see the reference at:
https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#option-lists

There are examples for long options.

        Thanks, Akira

> 
> I'll send a full patch shortly.
> 
> Logan
> 
> --
> 
> diff --git a/kernel/dma/mapping.c b/kernel/dma/mapping.c
> index 746d46825d08..99e1e0c9a295 100644
> --- a/kernel/dma/mapping.c
> +++ b/kernel/dma/mapping.c
> @@ -249,15 +249,15 @@ EXPORT_SYMBOL(dma_map_sg_attrs);
>   * Returns 0 on success or a negative error code on error. The following
>   * error codes are supported with the given meaning:
>   *
> - *   -EINVAL	An invalid argument, unaligned access or other error
> - *		in usage. Will not succeed if retried.
> - *   -ENOMEM	Insufficient resources (like memory or IOVA space) to
> - *		complete the mapping. Should succeed if retried later.
> - *   -EIO	Legacy error code with an unknown meaning. eg. this is
> - *		returned if a lower level call returned DMA_MAPPING_ERROR.
> - *   -EREMOTEIO	The DMA device cannot access P2PDMA memory specified in
> - *		the sg_table. This will not succeed if retried.
> - *
> + *   -EINVAL		An invalid argument, unaligned access or other error
> + *			in usage. Will not succeed if retried.
> + *   -ENOMEM		Insufficient resources (like memory or IOVA space) to
> + *			complete the mapping. Should succeed if retried later.
> + *   -EIO		Legacy error code with an unknown meaning. eg. this is
> + *			returned if a lower level call returned
> + *			DMA_MAPPING_ERROR.
> + *   -EREMOTEIO		The DMA device cannot access P2PDMA memory specified
> + *			in the sg_table. This will not succeed if retried.
>   */
>  int dma_map_sgtable(struct device *dev, struct sg_table *sgt,
>  		    enum dma_data_direction dir, unsigned long attrs)

Re: linux-next: build warning after merge of the dma-mapping tree

[Bagas Sanjaya]

On Thu, Jul 28, 2022 at 11:23:34AM +0900, Akira Yokosawa wrote:
> > Oh, hmm, I thought I addressed this when I added the extra line at the
> > end of the comment, but it seems the htmldocs is a bit fussier than that
> > with the white space. 
> > 
> > The only way I can seem to suppress that error is by adding another tab
> > character in the list; see below.
> 
> I think all you need is to see the reference at:
> https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#option-lists
> 
> There are examples for long options.
> 

Hi Akira,

I read the reference, and for the long option case, I see:

> --very-long-option  A VMS-style option.  Note the adjustment for
>                     the required two spaces.
>
> --an-even-longer-option
>            The description can also start on the next line.

I interpreted that for the first case above, two spaces separator between
the first and second sentence of option description is required, right?

-- 
An old man doll... just what I always wanted! - Clara

linux-next: build warning after merge of the dma-mapping tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

Hi all,

After merging the dma-mapping tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

kernel/dma/coherent.c:325:29: warning: 'dma_reserved_default_memory' defined but not used [-Wunused-variable]
  325 | static struct reserved_mem *dma_reserved_default_memory __initdata;
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  b7987aff1d0c ("dma-mapping: make the global coherent pool conditional")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the dma-mapping tree

[Christoph Hellwig]

Thanks,

fixed.

linux-next: build warning after merge of the dma-mapping tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

Hi all,

After merging the dma-mapping tree, today's linux-next build (htmldocs)
produced this warning:

kernel/dma/mapping.c:224: warning: Function parameter or member 'nents' not described in 'dma_map_sg_attrs'

Caused by commit

  fffe3cc8c219 ("dma-mapping: allow map_sg() ops to return negative error codes")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the dma-mapping tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 499 bytes --]

Hi all,

On Fri, 13 Aug 2021 17:11:34 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> After merging the dma-mapping tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> kernel/dma/mapping.c:224: warning: Function parameter or member 'nents' not described in 'dma_map_sg_attrs'
> 
> Caused by commit
> 
>   fffe3cc8c219 ("dma-mapping: allow map_sg() ops to return negative error codes")

I am still getting this warning.


-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the dma-mapping tree

[Christoph Hellwig]

Thanks,

I've commited a fix.

linux-next: build warning after merge of the dma-mapping tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

Hi Christoph,

After merging the dma-mapping tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/base/platform.c:1182:12: warning: 'dma_default_get_required_mask' defined but not used [-Wunused-function]
 static u64 dma_default_get_required_mask(struct device *dev)
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  dma_default_get_required_mask ("dma-mapping: make the get_required_mask method available unconditionally")

It is only used in the case ARCH_HAS_DMA_GET_REQUIRED_MASK is not defined.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the dma-mapping tree

[Christoph Hellwig]

Thanks,

fixed now.

linux-next: build warning after merge of the dma-mapping tree

[Stephen Rothwell]

Hi Christoph,

After merging the dma-mapping tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/base/dma-coherent.c: In function '__dma_alloc_from_coherent':
drivers/base/dma-coherent.c:160:6: warning: unused variable 'dma_memory_map' [-Wunused-variable]
  int dma_memory_map;
      ^

Introduced by commit

  2436bdcda53f ("dma-coherent: remove the DMA_MEMORY_MAP and DMA_MEMORY_IO flags")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the dma-mapping tree

[Christoph Hellwig]

Thanks Stephen, I'll fix it.