* linux-next: build warning after merge of the dma-mapping tree
@ 2020-09-02 0:03 Stephen Rothwell
2020-09-02 15:25 ` Christoph Hellwig
0 siblings, 1 reply; 15+ messages in thread
From: Stephen Rothwell @ 2020-09-02 0:03 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jim Quinlan
[-- Attachment #1: Type: text/plain, Size: 945 bytes --]
Hi all,
After merging the dma-mapping tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
In file included from arch/arm/mach-keystone/keystone.c:24:
arch/arm/mach-keystone/keystone.c: In function 'keystone_platform_notifier':
arch/arm/mach-keystone/memory.h:17:34: warning: conversion from 'long long unsigned int' to 'phys_addr_t' {aka 'unsigned int'} changes value from '34359738368' to '0' [-Woverflow]
17 | #define KEYSTONE_HIGH_PHYS_START 0x800000000ULL
| ^~~~~~~~~~~~~~
arch/arm/mach-keystone/keystone.c:40:39: note: in expansion of macro 'KEYSTONE_HIGH_PHYS_START'
40 | int ret = dma_set_offset_range(dev, KEYSTONE_HIGH_PHYS_START,
| ^~~~~~~~~~~~~~~~~~~~~~~~
Introduced by commit
eef520b232c6 ("dma-mapping: introduce DMA range map, supplanting dma_pfn_offset")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* linux-next: build warning after merge of the dma-mapping tree
@ 2022-07-27 11:48 Stephen Rothwell
2022-07-27 18:32 ` Logan Gunthorpe
0 siblings, 1 reply; 15+ messages in thread
From: Stephen Rothwell @ 2022-07-27 11:48 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Logan Gunthorpe, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 392 bytes --]
Hi all,
After merging the dma-mapping tree, today's linux-next build (htmldocs)
produced this warning:
Documentation/driver-api/infrastructure:50: kernel/dma/mapping.c:258: WARNING: Option list ends without a blank line; unexpected unindent.
Introduced by commit
7c2645a2a30a ("dma-mapping: allow EREMOTEIO return code for P2PDMA transfers")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: linux-next: build warning after merge of the dma-mapping tree
2022-07-27 11:48 Stephen Rothwell
@ 2022-07-27 18:32 ` Logan Gunthorpe
2022-07-28 2:23 ` Akira Yokosawa
0 siblings, 1 reply; 15+ messages in thread
From: Logan Gunthorpe @ 2022-07-27 18:32 UTC (permalink / raw)
To: Stephen Rothwell, Christoph Hellwig
Cc: Linux Kernel Mailing List, Linux Next Mailing List,
Jonathan Corbet, linux-doc
On 2022-07-27 05:48, Stephen Rothwell wrote:
> Hi all,
>
> After merging the dma-mapping tree, today's linux-next build (htmldocs)
> produced this warning:
>
> Documentation/driver-api/infrastructure:50: kernel/dma/mapping.c:258: WARNING: Option list ends without a blank line; unexpected unindent.
>
> Introduced by commit
>
> 7c2645a2a30a ("dma-mapping: allow EREMOTEIO return code for P2PDMA transfers")
Oh, hmm, I thought I addressed this when I added the extra line at the
end of the comment, but it seems the htmldocs is a bit fussier than that
with the white space.
The only way I can seem to suppress that error is by adding another tab
character in the list; see below.
I'll send a full patch shortly.
Logan
--
diff --git a/kernel/dma/mapping.c b/kernel/dma/mapping.c
index 746d46825d08..99e1e0c9a295 100644
--- a/kernel/dma/mapping.c
+++ b/kernel/dma/mapping.c
@@ -249,15 +249,15 @@ EXPORT_SYMBOL(dma_map_sg_attrs);
* Returns 0 on success or a negative error code on error. The following
* error codes are supported with the given meaning:
*
- * -EINVAL An invalid argument, unaligned access or other error
- * in usage. Will not succeed if retried.
- * -ENOMEM Insufficient resources (like memory or IOVA space) to
- * complete the mapping. Should succeed if retried later.
- * -EIO Legacy error code with an unknown meaning. eg. this is
- * returned if a lower level call returned DMA_MAPPING_ERROR.
- * -EREMOTEIO The DMA device cannot access P2PDMA memory specified in
- * the sg_table. This will not succeed if retried.
- *
+ * -EINVAL An invalid argument, unaligned access or other error
+ * in usage. Will not succeed if retried.
+ * -ENOMEM Insufficient resources (like memory or IOVA space) to
+ * complete the mapping. Should succeed if retried later.
+ * -EIO Legacy error code with an unknown meaning. eg. this is
+ * returned if a lower level call returned
+ * DMA_MAPPING_ERROR.
+ * -EREMOTEIO The DMA device cannot access P2PDMA memory specified
+ * in the sg_table. This will not succeed if retried.
*/
int dma_map_sgtable(struct device *dev, struct sg_table *sgt,
enum dma_data_direction dir, unsigned long attrs)
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: linux-next: build warning after merge of the dma-mapping tree
2022-07-27 18:32 ` Logan Gunthorpe
@ 2022-07-28 2:23 ` Akira Yokosawa
2022-07-28 8:57 ` Bagas Sanjaya
0 siblings, 1 reply; 15+ messages in thread
From: Akira Yokosawa @ 2022-07-28 2:23 UTC (permalink / raw)
To: Logan Gunthorpe; +Cc: corbet, hch, linux-doc, linux-kernel, linux-next, sfr
Hi,
On Wed, 27 Jul 2022 12:32:12 -0600, Logan Gunthorpe wrote:
> On 2022-07-27 05:48, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the dma-mapping tree, today's linux-next build (htmldocs)
>> produced this warning:
>>
>> Documentation/driver-api/infrastructure:50: kernel/dma/mapping.c:258: WARNING: Option list ends without a blank line; unexpected unindent.
>>
>> Introduced by commit
>>
>> 7c2645a2a30a ("dma-mapping: allow EREMOTEIO return code for P2PDMA transfers")
>
>
> Oh, hmm, I thought I addressed this when I added the extra line at the
> end of the comment, but it seems the htmldocs is a bit fussier than that
> with the white space.
>
> The only way I can seem to suppress that error is by adding another tab
> character in the list; see below.
I think all you need is to see the reference at:
https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#option-lists
There are examples for long options.
Thanks, Akira
>
> I'll send a full patch shortly.
>
> Logan
>
> --
>
> diff --git a/kernel/dma/mapping.c b/kernel/dma/mapping.c
> index 746d46825d08..99e1e0c9a295 100644
> --- a/kernel/dma/mapping.c
> +++ b/kernel/dma/mapping.c
> @@ -249,15 +249,15 @@ EXPORT_SYMBOL(dma_map_sg_attrs);
> * Returns 0 on success or a negative error code on error. The following
> * error codes are supported with the given meaning:
> *
> - * -EINVAL An invalid argument, unaligned access or other error
> - * in usage. Will not succeed if retried.
> - * -ENOMEM Insufficient resources (like memory or IOVA space) to
> - * complete the mapping. Should succeed if retried later.
> - * -EIO Legacy error code with an unknown meaning. eg. this is
> - * returned if a lower level call returned DMA_MAPPING_ERROR.
> - * -EREMOTEIO The DMA device cannot access P2PDMA memory specified in
> - * the sg_table. This will not succeed if retried.
> - *
> + * -EINVAL An invalid argument, unaligned access or other error
> + * in usage. Will not succeed if retried.
> + * -ENOMEM Insufficient resources (like memory or IOVA space) to
> + * complete the mapping. Should succeed if retried later.
> + * -EIO Legacy error code with an unknown meaning. eg. this is
> + * returned if a lower level call returned
> + * DMA_MAPPING_ERROR.
> + * -EREMOTEIO The DMA device cannot access P2PDMA memory specified
> + * in the sg_table. This will not succeed if retried.
> */
> int dma_map_sgtable(struct device *dev, struct sg_table *sgt,
> enum dma_data_direction dir, unsigned long attrs)
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: linux-next: build warning after merge of the dma-mapping tree
2022-07-28 2:23 ` Akira Yokosawa
@ 2022-07-28 8:57 ` Bagas Sanjaya
0 siblings, 0 replies; 15+ messages in thread
From: Bagas Sanjaya @ 2022-07-28 8:57 UTC (permalink / raw)
To: Akira Yokosawa
Cc: Logan Gunthorpe, corbet, hch, linux-doc, linux-kernel, linux-next, sfr
On Thu, Jul 28, 2022 at 11:23:34AM +0900, Akira Yokosawa wrote:
> > Oh, hmm, I thought I addressed this when I added the extra line at the
> > end of the comment, but it seems the htmldocs is a bit fussier than that
> > with the white space.
> >
> > The only way I can seem to suppress that error is by adding another tab
> > character in the list; see below.
>
> I think all you need is to see the reference at:
> https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#option-lists
>
> There are examples for long options.
>
Hi Akira,
I read the reference, and for the long option case, I see:
> --very-long-option A VMS-style option. Note the adjustment for
> the required two spaces.
>
> --an-even-longer-option
> The description can also start on the next line.
I interpreted that for the first case above, two spaces separator between
the first and second sentence of option description is required, right?
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 15+ messages in thread
* linux-next: build warning after merge of the dma-mapping tree
@ 2021-08-18 22:54 Stephen Rothwell
2021-08-19 7:02 ` Christoph Hellwig
0 siblings, 1 reply; 15+ messages in thread
From: Stephen Rothwell @ 2021-08-18 22:54 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 513 bytes --]
Hi all,
After merging the dma-mapping tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
kernel/dma/coherent.c:325:29: warning: 'dma_reserved_default_memory' defined but not used [-Wunused-variable]
325 | static struct reserved_mem *dma_reserved_default_memory __initdata;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
Introduced by commit
b7987aff1d0c ("dma-mapping: make the global coherent pool conditional")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* linux-next: build warning after merge of the dma-mapping tree
@ 2021-08-13 7:11 Stephen Rothwell
2021-09-03 6:45 ` Stephen Rothwell
0 siblings, 1 reply; 15+ messages in thread
From: Stephen Rothwell @ 2021-08-13 7:11 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Logan Gunthorpe, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 358 bytes --]
Hi all,
After merging the dma-mapping tree, today's linux-next build (htmldocs)
produced this warning:
kernel/dma/mapping.c:224: warning: Function parameter or member 'nents' not described in 'dma_map_sg_attrs'
Caused by commit
fffe3cc8c219 ("dma-mapping: allow map_sg() ops to return negative error codes")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* linux-next: build warning after merge of the dma-mapping tree
@ 2018-10-01 22:35 Stephen Rothwell
2018-10-02 14:22 ` Christoph Hellwig
0 siblings, 1 reply; 15+ messages in thread
From: Stephen Rothwell @ 2018-10-01 22:35 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 601 bytes --]
Hi Christoph,
After merging the dma-mapping tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
drivers/base/platform.c:1182:12: warning: 'dma_default_get_required_mask' defined but not used [-Wunused-function]
static u64 dma_default_get_required_mask(struct device *dev)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Introduced by commit
dma_default_get_required_mask ("dma-mapping: make the get_required_mask method available unconditionally")
It is only used in the case ARCH_HAS_DMA_GET_REQUIRED_MASK is not defined.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* linux-next: build warning after merge of the dma-mapping tree
@ 2017-09-03 22:34 Stephen Rothwell
2017-09-04 5:51 ` Christoph Hellwig
0 siblings, 1 reply; 15+ messages in thread
From: Stephen Rothwell @ 2017-09-03 22:34 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Marek Szyprowski
Hi Christoph,
After merging the dma-mapping tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
drivers/base/dma-coherent.c: In function '__dma_alloc_from_coherent':
drivers/base/dma-coherent.c:160:6: warning: unused variable 'dma_memory_map' [-Wunused-variable]
int dma_memory_map;
^
Introduced by commit
2436bdcda53f ("dma-coherent: remove the DMA_MEMORY_MAP and DMA_MEMORY_IO flags")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2022-07-28 8:58 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-02 0:03 linux-next: build warning after merge of the dma-mapping tree Stephen Rothwell
2020-09-02 15:25 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2022-07-27 11:48 Stephen Rothwell
2022-07-27 18:32 ` Logan Gunthorpe
2022-07-28 2:23 ` Akira Yokosawa
2022-07-28 8:57 ` Bagas Sanjaya
2021-08-18 22:54 Stephen Rothwell
2021-08-19 7:02 ` Christoph Hellwig
2021-08-13 7:11 Stephen Rothwell
2021-09-03 6:45 ` Stephen Rothwell
2021-09-06 12:41 ` Christoph Hellwig
2018-10-01 22:35 Stephen Rothwell
2018-10-02 14:22 ` Christoph Hellwig
2017-09-03 22:34 Stephen Rothwell
2017-09-04 5:51 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).