From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Michael Ellerman <mpe@ellerman.id.au>,
PowerPC <linuxppc-dev@lists.ozlabs.org>
Cc: Daniel Axtens <dja@axtens.net>,
Nicholas Piggin <npiggin@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: build failure in Linus' tree
Date: Mon, 23 Nov 2020 18:40:16 +1100 [thread overview]
Message-ID: <20201123184016.693fe464@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 3523 bytes --]
Hi all,
After merging most of the trees, today's linux-next build (powerpc64
allnoconfig) failed like this:
In file included from arch/powerpc/include/asm/kup.h:18,
from arch/powerpc/include/asm/uaccess.h:9,
from include/linux/uaccess.h:11,
from include/linux/sched/task.h:11,
from include/linux/sched/signal.h:9,
from include/linux/rcuwait.h:6,
from include/linux/percpu-rwsem.h:7,
from include/linux/fs.h:33,
from include/linux/compat.h:17,
from arch/powerpc/kernel/asm-offsets.c:14:
arch/powerpc/include/asm/book3s/64/kup-radix.h:66:1: warning: data definition has no type or storage class
66 | DECLARE_STATIC_KEY_FALSE(uaccess_flush_key);
| ^~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/book3s/64/kup-radix.h:66:1: error: type defaults to 'int' in declaration of 'DECLARE_STATIC_KEY_FALSE' [-Werror=implicit-int]
arch/powerpc/include/asm/book3s/64/kup-radix.h:66:1: warning: parameter names (without types) in function declaration
arch/powerpc/include/asm/book3s/64/kup-radix.h: In function 'prevent_user_access':
arch/powerpc/include/asm/book3s/64/kup-radix.h:180:6: error: implicit declaration of function 'static_branch_unlikely' [-Werror=implicit-function-declaration]
180 | if (static_branch_unlikely(&uaccess_flush_key))
| ^~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/book3s/64/kup-radix.h:180:30: error: 'uaccess_flush_key' undeclared (first use in this function)
180 | if (static_branch_unlikely(&uaccess_flush_key))
| ^~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/book3s/64/kup-radix.h:180:30: note: each undeclared identifier is reported only once for each function it appears in
arch/powerpc/include/asm/book3s/64/kup-radix.h: In function 'prevent_user_access_return':
arch/powerpc/include/asm/book3s/64/kup-radix.h:189:30: error: 'uaccess_flush_key' undeclared (first use in this function)
189 | if (static_branch_unlikely(&uaccess_flush_key))
| ^~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/book3s/64/kup-radix.h: In function 'restore_user_access':
arch/powerpc/include/asm/book3s/64/kup-radix.h:198:30: error: 'uaccess_flush_key' undeclared (first use in this function)
198 | if (static_branch_unlikely(&uaccess_flush_key) && flags == AMR_KUAP_BLOCKED)
| ^~~~~~~~~~~~~~~~~
Caused by commit
9a32a7e78bd0 ("powerpc/64s: flush L1D after user accesses")
I have applied the following patch for today:
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 23 Nov 2020 18:35:02 +1100
Subject: [PATCH] powerpc/64s: using DECLARE_STATIC_KEY_FALSE needs
linux/jump_table.h
Fixes: 9a32a7e78bd0 ("powerpc/64s: flush L1D after user accesses")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
arch/powerpc/include/asm/book3s/64/kup-radix.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/powerpc/include/asm/book3s/64/kup-radix.h b/arch/powerpc/include/asm/book3s/64/kup-radix.h
index 28716e2f13e3..a39e2d193fdc 100644
--- a/arch/powerpc/include/asm/book3s/64/kup-radix.h
+++ b/arch/powerpc/include/asm/book3s/64/kup-radix.h
@@ -63,6 +63,8 @@
#else /* !__ASSEMBLY__ */
+#include <linux/jump_label.h>
+
DECLARE_STATIC_KEY_FALSE(uaccess_flush_key);
#ifdef CONFIG_PPC_KUAP
--
2.29.2
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2020-11-23 7:40 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 7:40 Stephen Rothwell [this message]
2020-11-23 23:39 ` linux-next: build failure in Linus' tree Michael Ellerman
2020-11-24 0:23 ` Daniel Axtens
2020-11-25 2:47 ` Michael Ellerman
-- strict thread matches above, loose matches on Subject: below --
2022-03-27 22:01 Stephen Rothwell
2022-03-27 22:23 ` Linus Torvalds
2022-03-27 22:31 ` Linus Torvalds
2022-03-27 23:33 ` Stephen Rothwell
2021-11-05 4:54 Stephen Rothwell
2021-11-05 9:25 ` Suzuki K Poulose
2021-11-05 4:49 Stephen Rothwell
2021-09-07 1:02 Stephen Rothwell
2021-09-06 5:57 Stephen Rothwell
2021-07-14 23:50 Stephen Rothwell
2021-07-20 6:45 ` Stephen Rothwell
2021-07-20 12:11 ` Jakub Kicinski
2021-07-22 23:04 ` Stephen Rothwell
2020-06-21 2:05 Stephen Rothwell
2020-04-20 11:46 linux-next: build failure in Linus tree Stephen Rothwell
2020-04-28 8:48 ` Stephen Rothwell
2020-05-18 22:20 ` Stephen Rothwell
2020-04-05 1:22 linux-next: build failure in Linus' tree Stephen Rothwell
2020-04-05 1:27 ` Stephen Rothwell
2020-02-09 21:08 Stephen Rothwell
2020-02-09 21:24 ` Linus Torvalds
2020-02-09 22:57 ` Marc Zyngier
2020-02-09 23:48 ` Linus Torvalds
2020-02-10 2:00 ` Zenghui Yu
2018-10-28 22:45 Stephen Rothwell
2018-10-28 22:35 Stephen Rothwell
2018-10-28 22:45 ` Linus Torvalds
2018-10-29 1:38 ` Hangbin Liu
2018-10-29 2:17 ` David Miller
2018-06-12 2:26 Stephen Rothwell
2018-06-18 3:50 ` Stephen Rothwell
2018-02-04 22:28 Stephen Rothwell
2017-09-17 23:34 Stephen Rothwell
2016-03-27 6:06 Stephen Rothwell
2016-03-28 20:44 ` Arnaldo Carvalho de Melo
2014-11-03 4:09 Stephen Rothwell
2014-11-03 4:16 ` David Miller
2012-07-27 0:15 Stephen Rothwell
2012-07-27 0:23 ` Stephen Rothwell
2012-07-27 1:04 ` Linus Torvalds
2012-06-14 1:47 Stephen Rothwell
2012-06-14 3:06 ` Paul Mundt
2012-06-14 3:40 ` Paul Mundt
2012-06-15 0:14 ` Stephen Rothwell
2012-06-15 0:56 ` Paul Mundt
2012-06-17 23:38 ` Benjamin Herrenschmidt
2012-06-18 4:58 ` Paul Mundt
2012-06-15 9:23 ` Sedat Dilek
2012-06-15 10:15 ` Sedat Dilek
2012-06-15 8:46 ` Richard W.M. Jones
2012-06-15 11:38 ` Arnd Bergmann
2012-05-14 0:50 Stephen Rothwell
2012-05-14 6:57 ` Grant Likely
2012-05-14 8:32 ` Thomas Gleixner
2012-05-07 0:08 Stephen Rothwell
2012-05-07 0:10 ` Al Viro
2012-04-19 0:41 Stephen Rothwell
2012-01-24 0:51 Stephen Rothwell
2011-08-29 0:44 Stephen Rothwell
2011-08-29 22:32 ` Stephen Rothwell
2011-08-29 22:50 ` James Bottomley
2011-08-11 1:59 Stephen Rothwell
2011-08-11 6:43 ` Borislav Petkov
2011-05-26 1:12 Stephen Rothwell
2011-05-20 1:15 Stephen Rothwell
2011-05-20 1:19 ` Linus Torvalds
2011-03-17 23:29 Stephen Rothwell
2011-03-17 23:35 ` Luck, Tony
2011-01-14 23:40 Stephen Rothwell
2011-01-19 3:12 ` Konrad Rzeszutek Wilk
2011-01-19 4:19 ` Stephen Rothwell
2011-01-13 23:43 Stephen Rothwell
2011-01-14 1:24 ` Linus Torvalds
2011-01-14 2:17 ` Al Viro
2010-12-21 1:01 Stephen Rothwell
2010-12-21 4:47 ` Sedat Dilek
2010-10-06 0:09 Stephen Rothwell
2010-05-28 0:57 Stephen Rothwell
2010-05-28 1:09 ` Linus Torvalds
2010-05-30 0:43 ` Stephen Rothwell
2010-06-01 17:04 ` Tony Luck
2010-06-01 17:07 ` Linus Torvalds
2010-05-24 0:40 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123184016.693fe464@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=dja@axtens.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).