From: Bjorn Helgaas <helgaas@kernel.org>
To: Borislav Petkov <bp@suse.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Alex Shi <alex.shi@linux.alibaba.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: manual merge of the tip tree with the pci tree
Date: Mon, 30 Nov 2020 11:40:04 -0600 [thread overview]
Message-ID: <20201130174004.GA1090686@bjorn-Precision-5520> (raw)
In-Reply-To: <20201130102120.GB6586@zn.tnic>
On Mon, Nov 30, 2020 at 11:21:20AM +0100, Borislav Petkov wrote:
> On Mon, Nov 30, 2020 at 03:03:36PM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > Today's linux-next merge of the tip tree got a conflict in:
> >
> > arch/x86/pci/i386.c
> >
> > between commit:
> >
> > ace091d17272 ("x86/PCI: Fix kernel-doc markup")
> >
> > from the pci tree and commit:
> >
> > 638920a66a17 ("x86/PCI: Make a kernel-doc comment a normal one")
> >
> > from the tip tree.
>
> Bjorn, I fixed up the comment too, while picking up, see below. But I
> don't care all that much which one to take so I leave it up to you to
> decide. :-)
I dropped ace091d17272 ("x86/PCI: Fix kernel-doc markup") from my
tree so we keep your comment improvements. Thanks!
> commit 638920a66a17c8e1f4415cbab0d49dc4a344c2a7
> Author: Alex Shi <alex.shi@linux.alibaba.com>
> Date: Fri Nov 13 16:58:14 2020 +0800
>
> x86/PCI: Make a kernel-doc comment a normal one
>
> The comment is using kernel-doc markup but that comment isn't a
> kernel-doc comment so make it a normal one to avoid:
>
> arch/x86/pci/i386.c:373: warning: Function parameter or member \
> 'pcibios_assign_resources' not described in 'fs_initcall'
>
> [ bp: Massage and fixup comment while at it. ]
>
> Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Link: https://lkml.kernel.org/r/1605257895-5536-5-git-send-email-alex.shi@linux.alibaba.com
>
> diff --git a/arch/x86/pci/i386.c b/arch/x86/pci/i386.c
> index fa855bbaebaf..f2f4a5d50b27 100644
> --- a/arch/x86/pci/i386.c
> +++ b/arch/x86/pci/i386.c
> @@ -366,9 +366,9 @@ static int __init pcibios_assign_resources(void)
> return 0;
> }
>
> -/**
> - * called in fs_initcall (one below subsys_initcall),
> - * give a chance for motherboard reserve resources
> +/*
> + * This is an fs_initcall (one below subsys_initcall) in order to reserve
> + * resources properly.
> */
> fs_initcall(pcibios_assign_resources);
>
>
>
> --
> Regards/Gruss,
> Boris.
>
> SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
next prev parent reply other threads:[~2020-11-30 17:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 4:03 linux-next: manual merge of the tip tree with the pci tree Stephen Rothwell
2020-11-30 10:21 ` Borislav Petkov
2020-11-30 17:40 ` Bjorn Helgaas [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-10-09 2:47 Stephen Rothwell
2023-10-31 23:15 ` Stephen Rothwell
2022-11-21 4:11 Stephen Rothwell
2020-10-01 6:38 Stephen Rothwell
2020-10-01 16:06 ` Bjorn Helgaas
2020-09-25 5:35 Stephen Rothwell
2020-10-13 3:34 ` Stephen Rothwell
2020-09-25 5:21 Stephen Rothwell
2020-10-13 3:31 ` Stephen Rothwell
2017-06-28 3:15 Stephen Rothwell
2017-06-29 0:14 ` Christoph Hellwig
2016-12-09 2:38 Stephen Rothwell
2016-12-12 16:09 ` Bjorn Helgaas
2014-11-24 5:18 Stephen Rothwell
2014-11-24 10:51 ` Thomas Gleixner
2014-03-12 22:18 Mark Brown
2014-03-03 6:07 Stephen Rothwell
2014-03-03 6:03 Stephen Rothwell
2014-03-03 9:26 ` Liviu Dudau
2013-10-29 6:33 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130174004.GA1090686@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=alex.shi@linux.alibaba.com \
--cc=bhelgaas@google.com \
--cc=bp@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).