linux-next: Signed-off-by missing for commits in the arm-soc tree

linux-next: Signed-off-by missing for commits in the arm-soc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 584 bytes --]

Hi all,

Commits

  fcc92afad9b5 ("arm64: dts: apple: j274: Expose PCI node for the Ethernet MAC address")
  92038722074e ("arm64: dts: apple: t8103: Add root port interrupt routing")
  1877225c5fa0 ("arm64: dts: apple: t8103: Add PCIe DARTs")
  3ca4ea148ba4 ("arm64: apple: Add PCIe node")
  97f0b33b9d2c ("arm64: apple: Add pinctrl nodes")
  4c929eb8eab4 ("MAINTAINERS: add pinctrl-apple-gpio to ARM/APPLE MACHINE")
  f2434d68992c ("MAINTAINERS: Add pasemi i2c to ARM/APPLE MACHINE")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the arm-soc tree

[Arnd Bergmann]

On Sun, Feb 27, 2022 at 9:45 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> Commits
>
>   4fcfd917c9eb ("ARM: mstar: Add OPP table for infinity3")
>   9affaa4ad7cc ("ARM: mstar: Add OPP table for infinity")
>   79f700c24b13 ("ARM: mstar: Link cpupll to second core")
>   62a2718bf4c2 ("ARM: mstar: Link cpupll to cpu")
>   6979b5fedb92 ("ARM: mstar: Add cpupll to base dtsi")
>   c952e5075de1 ("dt-bindings: clk: mstar msc313 cpupll binding description")
>
> are missing a Signed-off-by from their committer.

Thank you for the report. These are now far down in the history of
my arm/dt branch, so I don't want to rebase that any more.

I see these patches all have Daniel as author and Signoff, with Romain
providing a Reviewed-by and doing the actual commit. As both
Romain and Daniel are maintainers for this platform, my guess is that
Romain ended up rebasing the tree without adding a signoff.

        Arnd

linux-next: Signed-off-by missing for commits in the arm-soc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

Hi all,

Commits

  4fcfd917c9eb ("ARM: mstar: Add OPP table for infinity3")
  9affaa4ad7cc ("ARM: mstar: Add OPP table for infinity")
  79f700c24b13 ("ARM: mstar: Link cpupll to second core")
  62a2718bf4c2 ("ARM: mstar: Link cpupll to cpu")
  6979b5fedb92 ("ARM: mstar: Add cpupll to base dtsi")
  c952e5075de1 ("dt-bindings: clk: mstar msc313 cpupll binding description")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the arm-soc tree

[Arnd Bergmann]

On Sun, Jul 26, 2020 at 11:35 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> Commits
>
>   16730dda542e ("ARM: mstar: Add dts for 70mai midrive d08")
>   22a30e8035c6 ("ARM: mstar: Add dts for msc313(e) based BreadBee boards")
>   b6d785a8410e ("ARM: mstar: Add mercury5 series dtsis")
>   34a6a898b3f4 ("ARM: mstar: Add infinity/infinity3 family dtsis")
>   b968eee1862f ("ARM: mstar: Add Armv7 base dtsi")
>   d1c7f6eb7e48 ("ARM: mstar: Add binding details for mstar,l3bridge")
>   9c2387eeba44 ("ARM: mstar: Add machine for MStar/Sigmastar Armv7 SoCs")
>   04c7bb3695ef ("dt-bindings: arm: Add mstar YAML schema")
>   97771c5bcbe7 ("dt-bindings: vendor-prefixes: Add thingy.jp prefix")
>   9f9b6e5560fe ("dt-bindings: vendor-prefixes: Add 70mai vendor prefix")
>   13fd6dfd3503 ("dt-bindings: vendor-prefixes: Add sstar vendor prefix")
>   cb0d5cba0294 ("dt-bindings: vendor-prefixes: Add mstar vendor prefix")
>
> are missing a Signed-off-by from their committer.

Thanks for the report. I had already noticed this when I added a follow-up
patch and I fixed the arm/newsoc branch (which is the one destined for
inclusion)
that contains these commits, but I failed to rebase the for-next branch, which
now contains both copies of the patches. I'll fix it up with the next
set of merges
and recreate the for-next branch.

      Arnd

linux-next: Signed-off-by missing for commits in the arm-soc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 924 bytes --]

Hi all,

Commits

  16730dda542e ("ARM: mstar: Add dts for 70mai midrive d08")
  22a30e8035c6 ("ARM: mstar: Add dts for msc313(e) based BreadBee boards")
  b6d785a8410e ("ARM: mstar: Add mercury5 series dtsis")
  34a6a898b3f4 ("ARM: mstar: Add infinity/infinity3 family dtsis")
  b968eee1862f ("ARM: mstar: Add Armv7 base dtsi")
  d1c7f6eb7e48 ("ARM: mstar: Add binding details for mstar,l3bridge")
  9c2387eeba44 ("ARM: mstar: Add machine for MStar/Sigmastar Armv7 SoCs")
  04c7bb3695ef ("dt-bindings: arm: Add mstar YAML schema")
  97771c5bcbe7 ("dt-bindings: vendor-prefixes: Add thingy.jp prefix")
  9f9b6e5560fe ("dt-bindings: vendor-prefixes: Add 70mai vendor prefix")
  13fd6dfd3503 ("dt-bindings: vendor-prefixes: Add sstar vendor prefix")
  cb0d5cba0294 ("dt-bindings: vendor-prefixes: Add mstar vendor prefix")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the arm-soc tree

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 851 bytes --]

Hi Stephen,

On Wed, Oct 03, 2018 at 07:21:40AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>   6eeb4180d4b9 ("ARM: dts: sunxi: h3-h5: Add Bananapi M2+ v1.2 device trees")
>   80c21c8c8b8d ("arm64: dts: allwinner: h5: Add device tree for Bananapi M2 Plus H5")
>   aa8fee415f46 ("ARM: dts: sun8i: h3: Split out non-SoC-specific parts of Bananapi M2 Plus")
>   db9fd9d13e30 ("ARM: dts: sun8i: h3: bpi-m2-plus: Fix address for external RGMII Ethernet PHY")
>   6c700289a3e8 ("ARM: dts: sun8i: h3-h5: ir register size should be the whole memory block")
> 
> are missing a Signed-off-by from their committer.

I just sent a new PR with the SoB this time (and I just learnt that
git rebase rewrites the committer...)

Thanks!
Maxime

-- 
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

linux-next: Signed-off-by missing for commits in the arm-soc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 561 bytes --]

Hi all,

Commits

  6eeb4180d4b9 ("ARM: dts: sunxi: h3-h5: Add Bananapi M2+ v1.2 device trees")
  80c21c8c8b8d ("arm64: dts: allwinner: h5: Add device tree for Bananapi M2 Plus H5")
  aa8fee415f46 ("ARM: dts: sun8i: h3: Split out non-SoC-specific parts of Bananapi M2 Plus")
  db9fd9d13e30 ("ARM: dts: sun8i: h3: bpi-m2-plus: Fix address for external RGMII Ethernet PHY")
  6c700289a3e8 ("ARM: dts: sun8i: h3-h5: ir register size should be the whole memory block")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the arm-soc tree

[Florian Fainelli]

On 07/16/2018 02:57 AM, Russell King - ARM Linux wrote:
> On Mon, Jul 16, 2018 at 05:24:08PM +0800, Chen-Yu Tsai wrote:
>> On Mon, Jul 16, 2018 at 5:13 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
>>>
>>>
>>> On 07/15/2018 03:50 PM, Olof Johansson wrote:
>>>> Thanks Stephen, I keep saying every time you catch these that I need
>>>> to run the same script. :(
>>>>
>>>> Florian, I wonder if this happened when you rebased to squash in the fix?
>>>
>>> Humm, could be, all I did (and it was not the first time) was to do an
>>> interactive rebase with --preserve-merges. AFAICT, all of these commits
>>> came from Eric's pull request, so what I typically do is just sign off
>>> on the merge commit, but do not apply my SoB to all commits coming from
>>> that pull request if that makes sense?
>>
>> When you rebase, if the commit is re-applied, the committer changes to
>> you, so you need to add your SoB to all commits you rebased.
>>
>> I suppose you could override it with GIT_COMMITTER_NAME and
>> GIT_COMMITTER_EMAIL environment variables, but that sort of distorts
>> the SoB if any changes were added due to rebasing, such as resolution
>> of merge conflicts.
> 
> A different point: should *anyone* be rebasing commits that they did not
> themselves commit.  Discuss.
> 
> IMHO no - the commits were made public, and anyone could pull the tree
> from which they came in order to do further work before submitting that.
> Rebasing changes the commit IDs, which can lead to duplicate commits
> ending up in mainline.  With other changes on top, this causes totally
> unnecessary conflicts.
> 

Well in that case, I thought it would be cleaner to just squash Arnd's
build fix since the commit had not been merged into arm-soc, but I will
keep in mind not to do that anymore.
-- 
Florian

Re: linux-next: Signed-off-by missing for commits in the arm-soc tree

[Russell King - ARM Linux]

On Mon, Jul 16, 2018 at 05:24:08PM +0800, Chen-Yu Tsai wrote:
> On Mon, Jul 16, 2018 at 5:13 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
> >
> >
> > On 07/15/2018 03:50 PM, Olof Johansson wrote:
> >> Thanks Stephen, I keep saying every time you catch these that I need
> >> to run the same script. :(
> >>
> >> Florian, I wonder if this happened when you rebased to squash in the fix?
> >
> > Humm, could be, all I did (and it was not the first time) was to do an
> > interactive rebase with --preserve-merges. AFAICT, all of these commits
> > came from Eric's pull request, so what I typically do is just sign off
> > on the merge commit, but do not apply my SoB to all commits coming from
> > that pull request if that makes sense?
> 
> When you rebase, if the commit is re-applied, the committer changes to
> you, so you need to add your SoB to all commits you rebased.
> 
> I suppose you could override it with GIT_COMMITTER_NAME and
> GIT_COMMITTER_EMAIL environment variables, but that sort of distorts
> the SoB if any changes were added due to rebasing, such as resolution
> of merge conflicts.

A different point: should *anyone* be rebasing commits that they did not
themselves commit.  Discuss.

IMHO no - the commits were made public, and anyone could pull the tree
from which they came in order to do further work before submitting that.
Rebasing changes the commit IDs, which can lead to duplicate commits
ending up in mainline.  With other changes on top, this causes totally
unnecessary conflicts.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up
According to speedtest.net: 13Mbps down 490kbps up

Re: linux-next: Signed-off-by missing for commits in the arm-soc tree

[Florian Fainelli]

On 07/16/2018 02:24 AM, Chen-Yu Tsai wrote:
> On Mon, Jul 16, 2018 at 5:13 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
>>
>>
>> On 07/15/2018 03:50 PM, Olof Johansson wrote:
>>> Thanks Stephen, I keep saying every time you catch these that I need
>>> to run the same script. :(
>>>
>>> Florian, I wonder if this happened when you rebased to squash in the fix?
>>
>> Humm, could be, all I did (and it was not the first time) was to do an
>> interactive rebase with --preserve-merges. AFAICT, all of these commits
>> came from Eric's pull request, so what I typically do is just sign off
>> on the merge commit, but do not apply my SoB to all commits coming from
>> that pull request if that makes sense?
> 
> When you rebase, if the commit is re-applied, the committer changes to
> you, so you need to add your SoB to all commits you rebased.

Indeed, thanks for bringing that up Chen-Yu.

> 
> I suppose you could override it with GIT_COMMITTER_NAME and
> GIT_COMMITTER_EMAIL environment variables, but that sort of distorts
> the SoB if any changes were added due to rebasing, such as resolution
> of merge conflicts.
> 
> ChenYu
> 

-- 
Florian

Re: linux-next: Signed-off-by missing for commits in the arm-soc tree

[Chen-Yu Tsai]

On Mon, Jul 16, 2018 at 5:13 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
>
>
> On 07/15/2018 03:50 PM, Olof Johansson wrote:
>> Thanks Stephen, I keep saying every time you catch these that I need
>> to run the same script. :(
>>
>> Florian, I wonder if this happened when you rebased to squash in the fix?
>
> Humm, could be, all I did (and it was not the first time) was to do an
> interactive rebase with --preserve-merges. AFAICT, all of these commits
> came from Eric's pull request, so what I typically do is just sign off
> on the merge commit, but do not apply my SoB to all commits coming from
> that pull request if that makes sense?

When you rebase, if the commit is re-applied, the committer changes to
you, so you need to add your SoB to all commits you rebased.

I suppose you could override it with GIT_COMMITTER_NAME and
GIT_COMMITTER_EMAIL environment variables, but that sort of distorts
the SoB if any changes were added due to rebasing, such as resolution
of merge conflicts.

ChenYu

Re: linux-next: Signed-off-by missing for commits in the arm-soc tree

[Florian Fainelli]

On 07/15/2018 03:50 PM, Olof Johansson wrote:
> Thanks Stephen, I keep saying every time you catch these that I need
> to run the same script. :(
> 
> Florian, I wonder if this happened when you rebased to squash in the fix?

Humm, could be, all I did (and it was not the first time) was to do an
interactive rebase with --preserve-merges. AFAICT, all of these commits
came from Eric's pull request, so what I typically do is just sign off
on the merge commit, but do not apply my SoB to all commits coming from
that pull request if that makes sense?

> 
> I'll figure out where to get this into my workflow so we catch it
> before I merge from now on.
> 
> 
> -Olof
> 
> On Sun, Jul 15, 2018 at 2:57 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> Hi all,
>>
>> Commits
>>
>>   b8ccf02a5014 ("ARM: dts: bcm283x: Add the PMU to the devicetree.")
>>   b7dd29b401f5 ("ARM: dts: bcm283x: Add Transposer block")
>>   74d1e007915f ("hwmon: Add support for RPi voltage sensor")
>>   70eea1bbb556 ("firmware: raspberrypi: Register hwmon driver")
>>   a1547e0bca51 ("firmware: raspberrypi: Remove VLA usage")
>>
>> are missing a Signed-off-by from their committer.
>>
>> --
>> Cheers,
>> Stephen Rothwell

-- 
Florian

Re: linux-next: Signed-off-by missing for commits in the arm-soc tree

[Olof Johansson]

Thanks Stephen, I keep saying every time you catch these that I need
to run the same script. :(

Florian, I wonder if this happened when you rebased to squash in the fix?

I'll figure out where to get this into my workflow so we catch it
before I merge from now on.


-Olof

On Sun, Jul 15, 2018 at 2:57 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> Commits
>
>   b8ccf02a5014 ("ARM: dts: bcm283x: Add the PMU to the devicetree.")
>   b7dd29b401f5 ("ARM: dts: bcm283x: Add Transposer block")
>   74d1e007915f ("hwmon: Add support for RPi voltage sensor")
>   70eea1bbb556 ("firmware: raspberrypi: Register hwmon driver")
>   a1547e0bca51 ("firmware: raspberrypi: Remove VLA usage")
>
> are missing a Signed-off-by from their committer.
>
> --
> Cheers,
> Stephen Rothwell

linux-next: Signed-off-by missing for commits in the arm-soc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

Hi all,

Commits

  b8ccf02a5014 ("ARM: dts: bcm283x: Add the PMU to the devicetree.")
  b7dd29b401f5 ("ARM: dts: bcm283x: Add Transposer block")
  74d1e007915f ("hwmon: Add support for RPi voltage sensor")
  70eea1bbb556 ("firmware: raspberrypi: Register hwmon driver")
  a1547e0bca51 ("firmware: raspberrypi: Remove VLA usage")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]