* Coverity: jpeg_v4_0_5_start(): Code maintainability issues
@ 2024-02-14 0:00 coverity-bot
0 siblings, 0 replies; only message in thread
From: coverity-bot @ 2024-02-14 0:00 UTC (permalink / raw)
To: Saleemkhan Jamadar
Cc: Sun peng Li, Mario Limonciello, amd-gfx, Pan, Xinhui,
Daniel Vetter, Roman Li, Veerabadhran Gopalakrishnan,
Horatio Zhang, James Zhu, Harry Wentland, Yifan Zhang,
David Airlie, Aurabindo Pillai, Leo Liu, Bhawanpreet Lakha,
Sonny Jiang, Lang Yu, Alex Deucher, Li Ma, Lijo Lazar,
Morris Zhang, Tao Zhou, dri-devel, Shane Xiao,
Christian König, Ran Sun, Jane Jian, Hawking Zhang,
Ivan Lipski, linux-kernel, Tom Chung, Gustavo A. R. Silva,
linux-next, linux-hardening
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20240213 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
Mon Feb 12 16:09:32 2024 -0500
0a119d53f74a ("drm/amdgpu/jpeg: add support for jpeg DPG mode")
Coverity reported the following:
*** CID 1583635: Code maintainability issues (UNUSED_VALUE)
drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c:461 in jpeg_v4_0_5_start()
455
456 WREG32_SOC15(VCN, i, regVCN_JPEG_DB_CTRL,
457 ring->doorbell_index << VCN_JPEG_DB_CTRL__OFFSET__SHIFT |
458 VCN_JPEG_DB_CTRL__EN_MASK);
459
460 if (adev->pg_flags & AMD_PG_SUPPORT_JPEG_DPG) {
vvv CID 1583635: Code maintainability issues (UNUSED_VALUE)
vvv Assigning value from "jpeg_v4_0_5_start_dpg_mode(adev, i, adev->jpeg.indirect_sram)" to "r" here, but that stored value is overwritten before it can be used.
461 r = jpeg_v4_0_5_start_dpg_mode(adev, i, adev->jpeg.indirect_sram);
462 continue;
463 }
464
465 /* disable power gating */
466 r = jpeg_v4_0_5_disable_static_power_gating(adev, i);
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1583635 ("Code maintainability issues")
Fixes: 0a119d53f74a ("drm/amdgpu/jpeg: add support for jpeg DPG mode")
Thanks for your attention!
--
Coverity-bot
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-02-14 0:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-14 0:00 Coverity: jpeg_v4_0_5_start(): Code maintainability issues coverity-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).