linux-next: Fixes tag needs some work in the ftrace tree

linux-next: Fixes tag needs some work in the ftrace tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

Hi all,

In commit

  2fd814ad5713 ("ring-buffer: Make wake once of ring_buffer_wait() more robust")

Fixes tag

  Fixes: 5b37b7eb98a19 ("ring-buffer: Make wake once of ring_buffer_wait() more robust")

has these problem(s):

  - Target SHA1 does not exist

The Fixes tag seems to be referring to the commit that contains the
Fixes tag :-(

Also, pleas keep all the commit message tags together at the end of the
commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the ftrace tree

[Steven Rostedt]

On Mon, 18 Mar 2024 08:35:35 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> In commit
> 
>   2fd814ad5713 ("ring-buffer: Make wake once of ring_buffer_wait() more robust")
> 
> Fixes tag
> 
>   Fixes: 5b37b7eb98a19 ("ring-buffer: Make wake once of ring_buffer_wait() more robust")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> The Fixes tag seems to be referring to the commit that contains the
> Fixes tag :-(
> 
> Also, pleas keep all the commit message tags together at the end of the
> commit message.
> 

Bah, that looks to me to be a cut and paste error. Anyway, I'm rebasing all
of it as one of the commits was nacked by Linus. :-(

-- Steve

linux-next: Fixes tag needs some work in the ftrace tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

Hi all,

In commit

  b5e7014fe1c4 ("selftests/ftrace: Update synthetic event syntax errors")

Fixes tag

  Fixes: 81ff92a93d95 (selftests/ftrace: Add test case for synthetic

has these problem(s):

  - Subject has leading but no trailing parentheses

Please do not split Fixes tags over more than one line.  Also, keep all
the commit message tags together at the end of the message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the ftrace tree

[Steven Rostedt]

On Fri, 12 Feb 2021 07:57:28 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> In commit
> 
>   b5e7014fe1c4 ("selftests/ftrace: Update synthetic event syntax errors")
> 
> Fixes tag
> 
>   Fixes: 81ff92a93d95 (selftests/ftrace: Add test case for synthetic
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
> 
> Please do not split Fixes tags over more than one line.  Also, keep all
> the commit message tags together at the end of the message.
> 

Thanks, I didn't even notice that :-/

Tom, FYI for next time ;-)

-- Steve

Re: linux-next: Fixes tag needs some work in the ftrace tree

[Tom Zanussi]

On Thu, 2021-02-11 at 16:21 -0500, Steven Rostedt wrote:
> On Fri, 12 Feb 2021 07:57:28 +1100
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > Hi all,
> > 
> > In commit
> > 
> >   b5e7014fe1c4 ("selftests/ftrace: Update synthetic event syntax
> > errors")
> > 
> > Fixes tag
> > 
> >   Fixes: 81ff92a93d95 (selftests/ftrace: Add test case for
> > synthetic
> > 
> > has these problem(s):
> > 
> >   - Subject has leading but no trailing parentheses
> > 
> > Please do not split Fixes tags over more than one line.  Also, keep
> > all
> > the commit message tags together at the end of the message.
> > 
> 
> Thanks, I didn't even notice that :-/
> 
> Tom, FYI for next time ;-)
> 

Yep, thanks, Stephen, for pointing that out, didn't realize it until
now either.

Tom


> -- Steve