* linux-next: Fixes tag needs some work in the ftrace tree
@ 2021-02-11 20:57 Stephen Rothwell
2021-02-11 21:21 ` Steven Rostedt
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2021-02-11 20:57 UTC (permalink / raw)
To: Steven Rostedt
Cc: Tom Zanussi, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 434 bytes --]
Hi all,
In commit
b5e7014fe1c4 ("selftests/ftrace: Update synthetic event syntax errors")
Fixes tag
Fixes: 81ff92a93d95 (selftests/ftrace: Add test case for synthetic
has these problem(s):
- Subject has leading but no trailing parentheses
Please do not split Fixes tags over more than one line. Also, keep all
the commit message tags together at the end of the message.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Fixes tag needs some work in the ftrace tree
2021-02-11 20:57 linux-next: Fixes tag needs some work in the ftrace tree Stephen Rothwell
@ 2021-02-11 21:21 ` Steven Rostedt
2021-02-11 21:27 ` Tom Zanussi
0 siblings, 1 reply; 5+ messages in thread
From: Steven Rostedt @ 2021-02-11 21:21 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Tom Zanussi, Linux Kernel Mailing List, Linux Next Mailing List
On Fri, 12 Feb 2021 07:57:28 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> In commit
>
> b5e7014fe1c4 ("selftests/ftrace: Update synthetic event syntax errors")
>
> Fixes tag
>
> Fixes: 81ff92a93d95 (selftests/ftrace: Add test case for synthetic
>
> has these problem(s):
>
> - Subject has leading but no trailing parentheses
>
> Please do not split Fixes tags over more than one line. Also, keep all
> the commit message tags together at the end of the message.
>
Thanks, I didn't even notice that :-/
Tom, FYI for next time ;-)
-- Steve
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Fixes tag needs some work in the ftrace tree
2021-02-11 21:21 ` Steven Rostedt
@ 2021-02-11 21:27 ` Tom Zanussi
0 siblings, 0 replies; 5+ messages in thread
From: Tom Zanussi @ 2021-02-11 21:27 UTC (permalink / raw)
To: Steven Rostedt, Stephen Rothwell
Cc: Linux Kernel Mailing List, Linux Next Mailing List
On Thu, 2021-02-11 at 16:21 -0500, Steven Rostedt wrote:
> On Fri, 12 Feb 2021 07:57:28 +1100
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> > Hi all,
> >
> > In commit
> >
> > b5e7014fe1c4 ("selftests/ftrace: Update synthetic event syntax
> > errors")
> >
> > Fixes tag
> >
> > Fixes: 81ff92a93d95 (selftests/ftrace: Add test case for
> > synthetic
> >
> > has these problem(s):
> >
> > - Subject has leading but no trailing parentheses
> >
> > Please do not split Fixes tags over more than one line. Also, keep
> > all
> > the commit message tags together at the end of the message.
> >
>
> Thanks, I didn't even notice that :-/
>
> Tom, FYI for next time ;-)
>
Yep, thanks, Stephen, for pointing that out, didn't realize it until
now either.
Tom
> -- Steve
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Fixes tag needs some work in the ftrace tree
2024-03-17 21:35 Stephen Rothwell
@ 2024-03-17 21:46 ` Steven Rostedt
0 siblings, 0 replies; 5+ messages in thread
From: Steven Rostedt @ 2024-03-17 21:46 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Masami Hiramatsu, Linux Kernel Mailing List, Linux Next Mailing List
On Mon, 18 Mar 2024 08:35:35 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> In commit
>
> 2fd814ad5713 ("ring-buffer: Make wake once of ring_buffer_wait() more robust")
>
> Fixes tag
>
> Fixes: 5b37b7eb98a19 ("ring-buffer: Make wake once of ring_buffer_wait() more robust")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> The Fixes tag seems to be referring to the commit that contains the
> Fixes tag :-(
>
> Also, pleas keep all the commit message tags together at the end of the
> commit message.
>
Bah, that looks to me to be a cut and paste error. Anyway, I'm rebasing all
of it as one of the commits was nacked by Linus. :-(
-- Steve
^ permalink raw reply [flat|nested] 5+ messages in thread
* linux-next: Fixes tag needs some work in the ftrace tree
@ 2024-03-17 21:35 Stephen Rothwell
2024-03-17 21:46 ` Steven Rostedt
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2024-03-17 21:35 UTC (permalink / raw)
To: Steven Rostedt, Masami Hiramatsu
Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
Hi all,
In commit
2fd814ad5713 ("ring-buffer: Make wake once of ring_buffer_wait() more robust")
Fixes tag
Fixes: 5b37b7eb98a19 ("ring-buffer: Make wake once of ring_buffer_wait() more robust")
has these problem(s):
- Target SHA1 does not exist
The Fixes tag seems to be referring to the commit that contains the
Fixes tag :-(
Also, pleas keep all the commit message tags together at the end of the
commit message.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-03-17 21:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-11 20:57 linux-next: Fixes tag needs some work in the ftrace tree Stephen Rothwell
2021-02-11 21:21 ` Steven Rostedt
2021-02-11 21:27 ` Tom Zanussi
2024-03-17 21:35 Stephen Rothwell
2024-03-17 21:46 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).