* linux-next: Signed-off-by missing for commit in the rdma tree
@ 2017-08-31 21:50 Stephen Rothwell
2017-09-01 12:06 ` Doug Ledford
0 siblings, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2017-08-31 21:50 UTC (permalink / raw)
To: Doug Ledford
Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
Mike Marciniszyn, Kaike Wan, Dennis Dalessandro
Hi Doug,
Commit
4b9796b0a6fb ("IB/hfi1: Use accessor to determine ring size")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the rdma tree
2017-08-31 21:50 linux-next: Signed-off-by missing for commit in the rdma tree Stephen Rothwell
@ 2017-09-01 12:06 ` Doug Ledford
2017-09-02 16:42 ` Linus Torvalds
0 siblings, 1 reply; 9+ messages in thread
From: Doug Ledford @ 2017-09-01 12:06 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
Mike Marciniszyn, Kaike Wan, Dennis Dalessandro
[-- Attachment #1.1: Type: text/plain, Size: 455 bytes --]
On 8/31/2017 5:50 PM, Stephen Rothwell wrote:
> Hi Doug,
>
> Commit
>
> 4b9796b0a6fb ("IB/hfi1: Use accessor to determine ring size")
>
> is missing a Signed-off-by from its author.
>
What's the best way to fix this? I can rebase, but I know Linus hates
that. What about git note?
--
Doug Ledford <dledford@redhat.com>
GPG Key ID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the rdma tree
2017-09-01 12:06 ` Doug Ledford
@ 2017-09-02 16:42 ` Linus Torvalds
0 siblings, 0 replies; 9+ messages in thread
From: Linus Torvalds @ 2017-09-02 16:42 UTC (permalink / raw)
To: Doug Ledford
Cc: Stephen Rothwell, Linux-Next Mailing List,
Linux Kernel Mailing List, Mike Marciniszyn, Kaike Wan,
Dennis Dalessandro, John Fleck
On Fri, Sep 1, 2017 at 5:06 AM, Doug Ledford <dledford@redhat.com> wrote:
> On 8/31/2017 5:50 PM, Stephen Rothwell wrote:
>> Hi Doug,
>>
>> Commit
>>
>> 4b9796b0a6fb ("IB/hfi1: Use accessor to determine ring size")
>>
>> is missing a Signed-off-by from its author.
>>
>
> What's the best way to fix this? I can rebase, but I know Linus hates
> that. What about git note?
We don't end up using (or forwarding) git notes, so that won't help.
Generally, the answer to missing sign-offs is "don't do that again" if
it's not something major and there isn't a _pattern_ of it happening.
In this case, it's a one-liner patch from a developer who has lots of
other sign-offs, from a company that is very aware of his work and the
GPL, and an active contributor. so it's not like it has any legal
implications.
If it was some big important patch from a more questionable source,
and we'd be worried about covering the legal side, it would be a
different issue. As it is, it falls under "mistakes happen, not a big
deal, try to avoid it in the future".
If it *was* a bigger issue and you really want to make sure that the
chain is there for new contributors etc, rebasing to fix sign-offs
ends up being the best (still bad) solution.
Linus
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the rdma tree
2022-10-27 19:33 Stephen Rothwell
@ 2022-10-28 16:16 ` Jason Gunthorpe
0 siblings, 0 replies; 9+ messages in thread
From: Jason Gunthorpe @ 2022-10-28 16:16 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Doug Ledford, Leon Romanovsky, Linux Kernel Mailing List,
Linux Next Mailing List
On Fri, Oct 28, 2022 at 06:33:28AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> Commits
>
> cca19da0d998 ("RDMA/rxe: Remove unnecessary mr testing")
> 90f0afc4039b ("RDMA/rxe: Handle remote errors in the midst of a Read reply sequence")
> aba632f6e406 ("RDMA/rxe: Make responder handle RDMA Read failures")
>
> are missing a Signed-off-by from their committer.
I fixed it up, thanks
Jason
^ permalink raw reply [flat|nested] 9+ messages in thread
* linux-next: Signed-off-by missing for commit in the rdma tree
@ 2022-10-27 19:33 Stephen Rothwell
2022-10-28 16:16 ` Jason Gunthorpe
0 siblings, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2022-10-27 19:33 UTC (permalink / raw)
To: Doug Ledford, Jason Gunthorpe
Cc: Leon Romanovsky, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
Hi all,
Commits
cca19da0d998 ("RDMA/rxe: Remove unnecessary mr testing")
90f0afc4039b ("RDMA/rxe: Handle remote errors in the midst of a Read reply sequence")
aba632f6e406 ("RDMA/rxe: Make responder handle RDMA Read failures")
are missing a Signed-off-by from their committer.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the rdma tree
2021-04-09 16:20 ` Dennis Dalessandro
@ 2021-04-09 16:46 ` Jason Gunthorpe
0 siblings, 0 replies; 9+ messages in thread
From: Jason Gunthorpe @ 2021-04-09 16:46 UTC (permalink / raw)
To: Dennis Dalessandro
Cc: Stephen Rothwell, Doug Ledford, Mike Marciniszyn,
Linux Kernel Mailing List, Linux Next Mailing List
On Fri, Apr 09, 2021 at 12:20:09PM -0400, Dennis Dalessandro wrote:
> On 4/8/2021 6:00 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Commit
> >
> > 042a00f93aad ("IB/{ipoib,hfi1}: Add a timeout handler for rdma_netdev")
> >
> > is missing a Signed-off-by from its author.
>
> Doh! That's my fault. I must have fat fingered the delete button instead of
> editing the line when I was converting our email addresses to the new name.
>
> Jason do you want a v2 of the patch?
It is a bit late at this point..
Jason
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the rdma tree
2021-04-08 22:00 Stephen Rothwell
@ 2021-04-09 16:20 ` Dennis Dalessandro
2021-04-09 16:46 ` Jason Gunthorpe
0 siblings, 1 reply; 9+ messages in thread
From: Dennis Dalessandro @ 2021-04-09 16:20 UTC (permalink / raw)
To: Stephen Rothwell, Doug Ledford, Jason Gunthorpe
Cc: Mike Marciniszyn, Linux Kernel Mailing List, Linux Next Mailing List
On 4/8/2021 6:00 PM, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> 042a00f93aad ("IB/{ipoib,hfi1}: Add a timeout handler for rdma_netdev")
>
> is missing a Signed-off-by from its author.
Doh! That's my fault. I must have fat fingered the delete button instead
of editing the line when I was converting our email addresses to the new
name.
Jason do you want a v2 of the patch?
-Denny
^ permalink raw reply [flat|nested] 9+ messages in thread
* linux-next: Signed-off-by missing for commit in the rdma tree
@ 2021-04-08 22:00 Stephen Rothwell
2021-04-09 16:20 ` Dennis Dalessandro
0 siblings, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2021-04-08 22:00 UTC (permalink / raw)
To: Doug Ledford, Jason Gunthorpe
Cc: Mike Marciniszyn, Dennis Dalessandro, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 177 bytes --]
Hi all,
Commit
042a00f93aad ("IB/{ipoib,hfi1}: Add a timeout handler for rdma_netdev")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* linux-next: Signed-off-by missing for commit in the rdma tree
@ 2018-11-08 22:13 Stephen Rothwell
0 siblings, 0 replies; 9+ messages in thread
From: Stephen Rothwell @ 2018-11-08 22:13 UTC (permalink / raw)
To: Doug Ledford, Jason Gunthorpe
Cc: Linux-Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 185 bytes --]
Hi all,
Commit
5736c7c499f1 ("RDMA/rxe: Distinguish between down links and disabled links")
is missing a Signed-off-by from its committer.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-10-28 16:18 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-31 21:50 linux-next: Signed-off-by missing for commit in the rdma tree Stephen Rothwell
2017-09-01 12:06 ` Doug Ledford
2017-09-02 16:42 ` Linus Torvalds
2018-11-08 22:13 Stephen Rothwell
2021-04-08 22:00 Stephen Rothwell
2021-04-09 16:20 ` Dennis Dalessandro
2021-04-09 16:46 ` Jason Gunthorpe
2022-10-27 19:33 Stephen Rothwell
2022-10-28 16:16 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).