* linux-next: build failure after merge of the drm tree
@ 2023-04-11 6:47 Stephen Rothwell
2023-04-26 5:59 ` build failure from drm/ttm commit now in mainline (was: linux-next: build failure after merge of the drm tree) Thorsten Leemhuis
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2023-04-11 6:47 UTC (permalink / raw)
To: Dave Airlie, DRI
Cc: Thomas Hellström, Christian König,
Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 1341 bytes --]
Hi all,
After merging the drm tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/gpu/drm/ttm/ttm_pool.c:73:29: error: variably modified 'global_write_combined' at file scope
73 | static struct ttm_pool_type global_write_combined[TTM_DIM_ORDER];
| ^~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/ttm/ttm_pool.c:74:29: error: variably modified 'global_uncached' at file scope
74 | static struct ttm_pool_type global_uncached[TTM_DIM_ORDER];
| ^~~~~~~~~~~~~~~
drivers/gpu/drm/ttm/ttm_pool.c:76:29: error: variably modified 'global_dma32_write_combined' at file scope
76 | static struct ttm_pool_type global_dma32_write_combined[TTM_DIM_ORDER];
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/ttm/ttm_pool.c:77:29: error: variably modified 'global_dma32_uncached' at file scope
77 | static struct ttm_pool_type global_dma32_uncached[TTM_DIM_ORDER];
| ^~~~~~~~~~~~~~~~~~~~~
Caused by commit
322458c2bb1a ("drm/ttm: Reduce the number of used allocation orders for TTM pages")
PMD_SHIFT is not necessarily a constant on ppc (see
arch/powerpc/include/asm/book3s/64/pgtable.h).
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* build failure from drm/ttm commit now in mainline (was: linux-next: build failure after merge of the drm tree)
2023-04-11 6:47 linux-next: build failure after merge of the drm tree Stephen Rothwell
@ 2023-04-26 5:59 ` Thorsten Leemhuis
2023-04-26 23:27 ` Michael Ellerman
0 siblings, 1 reply; 3+ messages in thread
From: Thorsten Leemhuis @ 2023-04-26 5:59 UTC (permalink / raw)
To: Dave Airlie, DRI
Cc: Thomas Hellström, Christian König,
Linux Kernel Mailing List, Linux Next Mailing List,
Linux kernel regressions list, Justin Forbes, Stephen Rothwell
Lo!
Sometimes the regression tracker runs into regressions himself... :-D
On 11.04.23 08:47, Stephen Rothwell wrote:
>
> After merging the drm tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/gpu/drm/ttm/ttm_pool.c:73:29: error: variably modified 'global_write_combined' at file scope
> 73 | static struct ttm_pool_type global_write_combined[TTM_DIM_ORDER];
> | ^~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/ttm/ttm_pool.c:74:29: error: variably modified 'global_uncached' at file scope
> 74 | static struct ttm_pool_type global_uncached[TTM_DIM_ORDER];
> | ^~~~~~~~~~~~~~~
> drivers/gpu/drm/ttm/ttm_pool.c:76:29: error: variably modified 'global_dma32_write_combined' at file scope
> 76 | static struct ttm_pool_type global_dma32_write_combined[TTM_DIM_ORDER];
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/ttm/ttm_pool.c:77:29: error: variably modified 'global_dma32_uncached' at file scope
> 77 | static struct ttm_pool_type global_dma32_uncached[TTM_DIM_ORDER];
> | ^~~~~~~~~~~~~~~~~~~~~
>
> Caused by commit
>
> 322458c2bb1a ("drm/ttm: Reduce the number of used allocation orders for TTM pages")
>
> PMD_SHIFT is not necessarily a constant on ppc (see
> arch/powerpc/include/asm/book3s/64/pgtable.h).
>
> I have reverted that commit for today.
Did anyone look into this? I today ran into what looks like the same
compiler error when building a mainline snapshot using a Fedora rawhide
config for ppc64le:
```
drivers/gpu/drm/ttm/ttm_pool.c:73:29: error: variably modified
'global_write_combined' at file scope
73 | static struct ttm_pool_type global_write_combined[TTM_DIM_ORDER];
| ^~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/ttm/ttm_pool.c:74:29: error: variably modified
'global_uncached' at file scope
74 | static struct ttm_pool_type global_uncached[TTM_DIM_ORDER];
| ^~~~~~~~~~~~~~~
drivers/gpu/drm/ttm/ttm_pool.c:76:29: error: variably modified
'global_dma32_write_combined' at file scope
76 | static struct ttm_pool_type
global_dma32_write_combined[TTM_DIM_ORDER];
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/ttm/ttm_pool.c:77:29: error: variably modified
'global_dma32_uncached' at file scope
77 | static struct ttm_pool_type global_dma32_uncached[TTM_DIM_ORDER];
| ^~~~~~~~~~~~~~~~~~~~~
```
Full build log:
https://copr-be.cloud.fedoraproject.org/results/@kernel-vanilla/mainline/fedora-37-ppc64le/05850588-mainline-mainline-releases/build.log.gz
Ciao, Thorsten
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: build failure from drm/ttm commit now in mainline (was: linux-next: build failure after merge of the drm tree)
2023-04-26 5:59 ` build failure from drm/ttm commit now in mainline (was: linux-next: build failure after merge of the drm tree) Thorsten Leemhuis
@ 2023-04-26 23:27 ` Michael Ellerman
0 siblings, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2023-04-26 23:27 UTC (permalink / raw)
To: Thorsten Leemhuis, Dave Airlie, DRI
Cc: Thomas Hellström, Christian König,
Linux Kernel Mailing List, Linux Next Mailing List,
Linux kernel regressions list, Justin Forbes, Stephen Rothwell
Thorsten Leemhuis <regressions@leemhuis.info> writes:
> Lo!
>
> Sometimes the regression tracker runs into regressions himself... :-D
>
> On 11.04.23 08:47, Stephen Rothwell wrote:
>>
>> After merging the drm tree, today's linux-next build (powerpc
>> allyesconfig) failed like this:
>>
>> drivers/gpu/drm/ttm/ttm_pool.c:73:29: error: variably modified 'global_write_combined' at file scope
>> 73 | static struct ttm_pool_type global_write_combined[TTM_DIM_ORDER];
>> | ^~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/ttm/ttm_pool.c:74:29: error: variably modified 'global_uncached' at file scope
>> 74 | static struct ttm_pool_type global_uncached[TTM_DIM_ORDER];
>> | ^~~~~~~~~~~~~~~
>> drivers/gpu/drm/ttm/ttm_pool.c:76:29: error: variably modified 'global_dma32_write_combined' at file scope
>> 76 | static struct ttm_pool_type global_dma32_write_combined[TTM_DIM_ORDER];
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/ttm/ttm_pool.c:77:29: error: variably modified 'global_dma32_uncached' at file scope
>> 77 | static struct ttm_pool_type global_dma32_uncached[TTM_DIM_ORDER];
>> | ^~~~~~~~~~~~~~~~~~~~~
>>
>> Caused by commit
>>
>> 322458c2bb1a ("drm/ttm: Reduce the number of used allocation orders for TTM pages")
>>
>> PMD_SHIFT is not necessarily a constant on ppc (see
>> arch/powerpc/include/asm/book3s/64/pgtable.h).
>>
>> I have reverted that commit for today.
>
> Did anyone look into this?
Christian sent a revert:
56e51681246e ("drm/ttm: revert "Reduce the number of used allocation orders for TTM pages"")
Which has been in linux-next since the 21st. But I guess it missed being
in the initial DRM pull request.
See also other thread:
https://lore.kernel.org/all/ZEljCgVFnDl%2FC+l3@debian/
Where Christian says the revert is "on the way" to Linus.
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-26 23:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-11 6:47 linux-next: build failure after merge of the drm tree Stephen Rothwell
2023-04-26 5:59 ` build failure from drm/ttm commit now in mainline (was: linux-next: build failure after merge of the drm tree) Thorsten Leemhuis
2023-04-26 23:27 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).