Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* [next] drivers/cdrom/gdrom.c:586:61: error: 'rq' undeclared (first use in this function)
@ 2021-04-09  5:17 Naresh Kamboju
  2021-04-09  5:31 ` Chaitanya Kulkarni
  0 siblings, 1 reply; 6+ messages in thread
From: Naresh Kamboju @ 2021-04-09  5:17 UTC (permalink / raw)
  To: Linux-Next Mailing List, open list, lkft-triage,
	Christoph Hellwig, Jens Axboe, linux-block
  Cc: Johannes Thumshirn, Hannes Reinecke, Damien Le Moal

Linux next tag 20210408 architecture sh builds failed due to these errors.

# to reproduce this build locally:

make --silent --keep-going --jobs=8
O=/home/tuxbuild/.cache/tuxmake/builds/1/tmp ARCH=sh
CROSS_COMPILE=sh4-linux-gnu- 'CC=sccache sh4-linux-gnu-gcc'
'HOSTCC=sccache gcc'


In file included from /builds/linux/include/linux/scatterlist.h:9,
                 from /builds/linux/include/linux/dma-mapping.h:10,
                 from /builds/linux/drivers/cdrom/gdrom.c:16:
/builds/linux/drivers/cdrom/gdrom.c: In function 'gdrom_readdisk_dma':
/builds/linux/drivers/cdrom/gdrom.c:586:61: error: 'rq' undeclared
(first use in this function)
  586 |  __raw_writel(page_to_phys(bio_page(req->bio)) + bio_offset(rq->bio),
      |                                                             ^~

Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>

Regressions found on sh:
  - build/gcc-9-dreamcast_defconfig
  - build/gcc-10-dreamcast_defconfig
  - build/gcc-8-dreamcast_defconfig

--
Linaro LKFT
https://lkft.linaro.org

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [next] drivers/cdrom/gdrom.c:586:61: error: 'rq' undeclared (first use in this function)
  2021-04-09  5:17 [next] drivers/cdrom/gdrom.c:586:61: error: 'rq' undeclared (first use in this function) Naresh Kamboju
@ 2021-04-09  5:31 ` Chaitanya Kulkarni
  2021-04-09  5:33   ` Chaitanya Kulkarni
  2021-04-09  6:23   ` Naresh Kamboju
  0 siblings, 2 replies; 6+ messages in thread
From: Chaitanya Kulkarni @ 2021-04-09  5:31 UTC (permalink / raw)
  To: Naresh Kamboju, Linux-Next Mailing List, open list, lkft-triage,
	Christoph Hellwig, Jens Axboe, linux-block
  Cc: Johannes Thumshirn, Hannes Reinecke, Damien Le Moal

On 4/8/21 22:21, Naresh Kamboju wrote:
> Linux next tag 20210408 architecture sh builds failed due to these errors.
>
> # to reproduce this build locally:
>
> make --silent --keep-going --jobs=8
> O=/home/tuxbuild/.cache/tuxmake/builds/1/tmp ARCH=sh
> CROSS_COMPILE=sh4-linux-gnu- 'CC=sccache sh4-linux-gnu-gcc'
> 'HOSTCC=sccache gcc'
>
>
> In file included from /builds/linux/include/linux/scatterlist.h:9,
>                  from /builds/linux/include/linux/dma-mapping.h:10,
>                  from /builds/linux/drivers/cdrom/gdrom.c:16:
> /builds/linux/drivers/cdrom/gdrom.c: In function 'gdrom_readdisk_dma':
> /builds/linux/drivers/cdrom/gdrom.c:586:61: error: 'rq' undeclared
> (first use in this function)
>   586 |  __raw_writel(page_to_phys(bio_page(req->bio)) + bio_offset(rq->bio),
>       |                                                             ^~
>
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
>
> Regressions found on sh:
>   - build/gcc-9-dreamcast_defconfig
>   - build/gcc-10-dreamcast_defconfig
>   - build/gcc-8-dreamcast_defconfig
>
> --
> Linaro LKFT
> https://lkft.linaro.org
>

This can be fixed by following :-

diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c
index e7717d090868..742b4a0932e3 100644
--- a/drivers/cdrom/gdrom.c
+++ b/drivers/cdrom/gdrom.c
@@ -583,7 +583,7 @@ static blk_status_t gdrom_readdisk_dma(struct
request *req)
        read_command->cmd[1] = 0x20;
        block = blk_rq_pos(req)/GD_TO_BLK + GD_SESSION_OFFSET;
        block_cnt = blk_rq_sectors(req)/GD_TO_BLK;
-       __raw_writel(page_to_phys(bio_page(req->bio)) + bio_offset(rq->bio),
+       __raw_writel(page_to_phys(bio_page(req->bio)) +
bio_offset(req->bio),
                        GDROM_DMA_STARTADDR_REG);
        __raw_writel(block_cnt * GDROM_HARD_SECTOR, GDROM_DMA_LENGTH_REG);
        __raw_writel(1, GDROM_DMA_DIRECTION_REG);

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [next] drivers/cdrom/gdrom.c:586:61: error: 'rq' undeclared (first use in this function)
  2021-04-09  5:31 ` Chaitanya Kulkarni
@ 2021-04-09  5:33   ` Chaitanya Kulkarni
  2021-04-09  6:23   ` Naresh Kamboju
  1 sibling, 0 replies; 6+ messages in thread
From: Chaitanya Kulkarni @ 2021-04-09  5:33 UTC (permalink / raw)
  To: Naresh Kamboju
  Cc: Linux-Next Mailing List, open list, lkft-triage,
	Christoph Hellwig, Jens Axboe, linux-block, Johannes Thumshirn,
	Hannes Reinecke, Damien Le Moal

Naresh,

On 4/8/21 22:31, Chaitanya Kulkarni wrote:
> On 4/8/21 22:21, Naresh Kamboju wrote:
>> Linux next tag 20210408 architecture sh builds failed due to these errors.
>>
>> # to reproduce this build locally:
>>
>> make --silent --keep-going --jobs=8
>> O=/home/tuxbuild/.cache/tuxmake/builds/1/tmp ARCH=sh
>> CROSS_COMPILE=sh4-linux-gnu- 'CC=sccache sh4-linux-gnu-gcc'
>> 'HOSTCC=sccache gcc'
>>
>>
>> In file included from /builds/linux/include/linux/scatterlist.h:9,
>>                  from /builds/linux/include/linux/dma-mapping.h:10,
>>                  from /builds/linux/drivers/cdrom/gdrom.c:16:
>> /builds/linux/drivers/cdrom/gdrom.c: In function 'gdrom_readdisk_dma':
>> /builds/linux/drivers/cdrom/gdrom.c:586:61: error: 'rq' undeclared
>> (first use in this function)
>>   586 |  __raw_writel(page_to_phys(bio_page(req->bio)) + bio_offset(rq->bio),
>>       |                                                             ^~
>>
>> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
>>
>> Regressions found on sh:
>>   - build/gcc-9-dreamcast_defconfig
>>   - build/gcc-10-dreamcast_defconfig
>>   - build/gcc-8-dreamcast_defconfig
>>
>> --
>> Linaro LKFT
>> https://lkft.linaro.org
>>

You can try following fix and see if the error goes away.

> This can be fixed by following :-
>
> diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c
> index e7717d090868..742b4a0932e3 100644
> --- a/drivers/cdrom/gdrom.c
> +++ b/drivers/cdrom/gdrom.c
> @@ -583,7 +583,7 @@ static blk_status_t gdrom_readdisk_dma(struct
> request *req)
>         read_command->cmd[1] = 0x20;
>         block = blk_rq_pos(req)/GD_TO_BLK + GD_SESSION_OFFSET;
>         block_cnt = blk_rq_sectors(req)/GD_TO_BLK;
> -       __raw_writel(page_to_phys(bio_page(req->bio)) + bio_offset(rq->bio),
> +       __raw_writel(page_to_phys(bio_page(req->bio)) +
> bio_offset(req->bio),
>                         GDROM_DMA_STARTADDR_REG);
>         __raw_writel(block_cnt * GDROM_HARD_SECTOR, GDROM_DMA_LENGTH_REG);
>         __raw_writel(1, GDROM_DMA_DIRECTION_REG);
>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [next] drivers/cdrom/gdrom.c:586:61: error: 'rq' undeclared (first use in this function)
  2021-04-09  5:31 ` Chaitanya Kulkarni
  2021-04-09  5:33   ` Chaitanya Kulkarni
@ 2021-04-09  6:23   ` Naresh Kamboju
  2021-04-09  6:31     ` Chaitanya Kulkarni
  1 sibling, 1 reply; 6+ messages in thread
From: Naresh Kamboju @ 2021-04-09  6:23 UTC (permalink / raw)
  To: Chaitanya Kulkarni
  Cc: Linux-Next Mailing List, open list, lkft-triage,
	Christoph Hellwig, Jens Axboe, linux-block, Johannes Thumshirn,
	Hannes Reinecke, Damien Le Moal

Hi Chaitanya,

On Fri, 9 Apr 2021 at 11:01, Chaitanya Kulkarni
<Chaitanya.Kulkarni@wdc.com> wrote:
>
> On 4/8/21 22:21, Naresh Kamboju wrote:
> > Linux next tag 20210408 architecture sh builds failed due to these errors.
> >
> > # to reproduce this build locally:
> >
> > make --silent --keep-going --jobs=8
> > O=/home/tuxbuild/.cache/tuxmake/builds/1/tmp ARCH=sh
> > CROSS_COMPILE=sh4-linux-gnu- 'CC=sccache sh4-linux-gnu-gcc'
> > 'HOSTCC=sccache gcc'
> >
> >
> > In file included from /builds/linux/include/linux/scatterlist.h:9,
> >                  from /builds/linux/include/linux/dma-mapping.h:10,
> >                  from /builds/linux/drivers/cdrom/gdrom.c:16:
> > /builds/linux/drivers/cdrom/gdrom.c: In function 'gdrom_readdisk_dma':
> > /builds/linux/drivers/cdrom/gdrom.c:586:61: error: 'rq' undeclared
> > (first use in this function)
> >   586 |  __raw_writel(page_to_phys(bio_page(req->bio)) + bio_offset(rq->bio),
> >       |                                                             ^~
> >
> > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> >
> > Regressions found on sh:
> >   - build/gcc-9-dreamcast_defconfig
> >   - build/gcc-10-dreamcast_defconfig
> >   - build/gcc-8-dreamcast_defconfig
> >
> > --
> > Linaro LKFT
> > https://lkft.linaro.org
> >
>
> This can be fixed by following :-
>
> diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c
> index e7717d090868..742b4a0932e3 100644
> --- a/drivers/cdrom/gdrom.c
> +++ b/drivers/cdrom/gdrom.c
> @@ -583,7 +583,7 @@ static blk_status_t gdrom_readdisk_dma(struct
> request *req)
>         read_command->cmd[1] = 0x20;
>         block = blk_rq_pos(req)/GD_TO_BLK + GD_SESSION_OFFSET;
>         block_cnt = blk_rq_sectors(req)/GD_TO_BLK;
> -       __raw_writel(page_to_phys(bio_page(req->bio)) + bio_offset(rq->bio),
> +       __raw_writel(page_to_phys(bio_page(req->bio)) +
> bio_offset(req->bio),
>                         GDROM_DMA_STARTADDR_REG);
>         __raw_writel(block_cnt * GDROM_HARD_SECTOR, GDROM_DMA_LENGTH_REG);
>         __raw_writel(1, GDROM_DMA_DIRECTION_REG);

Thanks for your patch.
After applying this typo fix, the build pass now.

- Naresh

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [next] drivers/cdrom/gdrom.c:586:61: error: 'rq' undeclared (first use in this function)
  2021-04-09  6:23   ` Naresh Kamboju
@ 2021-04-09  6:31     ` Chaitanya Kulkarni
  2021-04-09  6:51       ` Naresh Kamboju
  0 siblings, 1 reply; 6+ messages in thread
From: Chaitanya Kulkarni @ 2021-04-09  6:31 UTC (permalink / raw)
  To: Naresh Kamboju
  Cc: Linux-Next Mailing List, open list, lkft-triage,
	Christoph Hellwig, Jens Axboe, linux-block, Johannes Thumshirn,
	Hannes Reinecke, Damien Le Moal

On 4/8/21 23:24, Naresh Kamboju wrote:
>> bio_offset(req->bio),
>>                         GDROM_DMA_STARTADDR_REG);
>>         __raw_writel(block_cnt * GDROM_HARD_SECTOR, GDROM_DMA_LENGTH_REG);
>>         __raw_writel(1, GDROM_DMA_DIRECTION_REG);
> Thanks for your patch.
> After applying this typo fix, the build pass now.
>
> - Naresh
>

are you okay if I add your tested by tag to the official patch ?

Or you want to send it as a reply to that patch ?

plz let me know...





^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [next] drivers/cdrom/gdrom.c:586:61: error: 'rq' undeclared (first use in this function)
  2021-04-09  6:31     ` Chaitanya Kulkarni
@ 2021-04-09  6:51       ` Naresh Kamboju
  0 siblings, 0 replies; 6+ messages in thread
From: Naresh Kamboju @ 2021-04-09  6:51 UTC (permalink / raw)
  To: Chaitanya Kulkarni
  Cc: Linux-Next Mailing List, open list, lkft-triage,
	Christoph Hellwig, Jens Axboe, linux-block, Johannes Thumshirn,
	Hannes Reinecke, Damien Le Moal

On Fri, 9 Apr 2021 at 12:02, Chaitanya Kulkarni
<Chaitanya.Kulkarni@wdc.com> wrote:
>
> On 4/8/21 23:24, Naresh Kamboju wrote:
> >> bio_offset(req->bio),
> >>                         GDROM_DMA_STARTADDR_REG);
> >>         __raw_writel(block_cnt * GDROM_HARD_SECTOR, GDROM_DMA_LENGTH_REG);
> >>         __raw_writel(1, GDROM_DMA_DIRECTION_REG);
> > Thanks for your patch.
> > After applying this typo fix, the build pass now.
> >
> > - Naresh
> >
>
> are you okay if I add your tested by tag to the official patch ?
>
> Or you want to send it as a reply to that patch ?

Please create a patch and add my Reported-by / Tested-by tags.

- Naresh

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09  5:17 [next] drivers/cdrom/gdrom.c:586:61: error: 'rq' undeclared (first use in this function) Naresh Kamboju
2021-04-09  5:31 ` Chaitanya Kulkarni
2021-04-09  5:33   ` Chaitanya Kulkarni
2021-04-09  6:23   ` Naresh Kamboju
2021-04-09  6:31     ` Chaitanya Kulkarni
2021-04-09  6:51       ` Naresh Kamboju

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git