linux-next: build failure after merge of the final tree (gpio tree related)

linux-next: build failure after merge of the final tree (gpio tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1671 bytes --]

Hi all,

After merging the final tree, today's linux-next build (sparc32 defconfig)
failed like this:

In file included from drivers/spi/spi.c:33:0:
include/linux/of_gpio.h: In function 'of_get_named_gpio_flags':
include/linux/of_gpio.h:93:3: error: implicit declaration of function 'desc_to_gpio' [-Werror=implicit-function-declaration]

Caused by commit af8b6375a829 ("gpiolib: port of_ functions to use
gpiod") from the gpio tree.

I have applied the following patch for today (it should go into the gpio
tree if it is considered correct):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 29 Oct 2013 20:05:12 +1100
Subject: [PATCH] gpiolib: include gpio/consumer.h in of_gpio.h for
 desc_to_gpio()

Fixes this build error on sparc:

In file included from drivers/spi/spi.c:33:0:
include/linux/of_gpio.h: In function 'of_get_named_gpio_flags':
include/linux/of_gpio.h:93:3: error: implicit declaration of function 'desc_to_gpio' [-Werror=implicit-function-declaration]

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/of_gpio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/of_gpio.h b/include/linux/of_gpio.h
index d71f2cc141ae..f14123a5a9df 100644
--- a/include/linux/of_gpio.h
+++ b/include/linux/of_gpio.h
@@ -19,9 +19,9 @@
 #include <linux/errno.h>
 #include <linux/gpio.h>
 #include <linux/of.h>
+#include <linux/gpio/consumer.h>
 
 struct device_node;
-struct gpio_desc;
 
 /*
  * This is Linux-specific flags. By default controllers' and Linux' mapping
-- 
1.8.4.rc3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (gpio tree related)

[Linus Walleij]

On Tue, Oct 29, 2013 at 10:10 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> I have applied the following patch for today (it should go into the gpio
> tree if it is considered correct):
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 29 Oct 2013 20:05:12 +1100
> Subject: [PATCH] gpiolib: include gpio/consumer.h in of_gpio.h for
>  desc_to_gpio()
>
> Fixes this build error on sparc:
>
> In file included from drivers/spi/spi.c:33:0:
> include/linux/of_gpio.h: In function 'of_get_named_gpio_flags':
> include/linux/of_gpio.h:93:3: error: implicit declaration of function 'desc_to_gpio' [-Werror=implicit-function-declaration]
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Patch applied, unless Alexandre has any considerations.

Yours,
Linus Walleij

Re: linux-next: build failure after merge of the final tree (gpio tree related)

[Alex Courbot]

On 10/29/2013 10:25 PM, Linus Walleij wrote:
> On Tue, Oct 29, 2013 at 10:10 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
>> I have applied the following patch for today (it should go into the gpio
>> tree if it is considered correct):
>>
>> From: Stephen Rothwell <sfr@canb.auug.org.au>
>> Date: Tue, 29 Oct 2013 20:05:12 +1100
>> Subject: [PATCH] gpiolib: include gpio/consumer.h in of_gpio.h for
>>   desc_to_gpio()
>>
>> Fixes this build error on sparc:
>>
>> In file included from drivers/spi/spi.c:33:0:
>> include/linux/of_gpio.h: In function 'of_get_named_gpio_flags':
>> include/linux/of_gpio.h:93:3: error: implicit declaration of function 'desc_to_gpio' [-Werror=implicit-function-declaration]
>>
>> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> Patch applied, unless Alexandre has any considerations.

Nope, that include should definitely be there, actually I was convinced 
it was already...

Alex.

linux-next: build failure after merge of the final tree (gpio tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1863 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/gpio/gpio-zevio.c: In function 'zevio_gpio_port_get':
drivers/gpio/gpio-zevio.c:70:2: error: implicit declaration of function 'IOMEM' [-Werror=implicit-function-declaration]
  return readl(IOMEM(c->chip.regs + section_offset + port_offset));
  ^
drivers/gpio/gpio-zevio.c:70:2: warning: passing argument 1 of 'readl' makes pointer from integer without a cast [enabled by default]
In file included from include/linux/io.h:22:0,
                 from drivers/gpio/gpio-zevio.c:15:
arch/powerpc/include/asm/io-defs.h:6:16: note: expected 'const volatile void *' but argument is of type 'int'
 DEF_PCI_AC_RET(readl, u32, (const PCI_IO_ADDR addr), (addr), mem, addr)
                ^
arch/powerpc/include/asm/io.h:577:19: note: in definition of macro 'DEF_PCI_AC_RET'
 static inline ret name at     \
                   ^
drivers/gpio/gpio-zevio.c: In function 'zevio_gpio_port_set':
drivers/gpio/gpio-zevio.c:77:2: warning: passing argument 2 of 'writel' makes pointer from integer without a cast [enabled by default]
  writel(val, IOMEM(c->chip.regs + section_offset + port_offset));
  ^
In file included from include/linux/io.h:22:0,
                 from drivers/gpio/gpio-zevio.c:15:
arch/powerpc/include/asm/io-defs.h:11:18: note: expected 'volatile void *' but argument is of type 'int'
 DEF_PCI_AC_NORET(writel, (u32 val, PCI_IO_ADDR addr), (val, addr), mem, addr)
                  ^
arch/powerpc/include/asm/io.h:585:20: note: in definition of macro 'DEF_PCI_AC_NORET'
 static inline void name at     \
                    ^

Caused by commit 9af4d80ba566 ("gpio: New driver for LSI ZEVIO SoCs").

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (gpio tree related)

[Linus Walleij]

On Wed, Mar 5, 2014 at 2:35 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/gpio/gpio-zevio.c: In function 'zevio_gpio_port_get':
> drivers/gpio/gpio-zevio.c:70:2: error: implicit declaration of function 'IOMEM' [-Werror=implicit-function-declaration]
>   return readl(IOMEM(c->chip.regs + section_offset + port_offset));
>   ^
> drivers/gpio/gpio-zevio.c:70:2: warning: passing argument 1 of 'readl' makes pointer from integer without a cast [enabled by default]
> In file included from include/linux/io.h:22:0,
>                  from drivers/gpio/gpio-zevio.c:15:
> arch/powerpc/include/asm/io-defs.h:6:16: note: expected 'const volatile void *' but argument is of type 'int'
>  DEF_PCI_AC_RET(readl, u32, (const PCI_IO_ADDR addr), (addr), mem, addr)
>                 ^

Fabian can you suggest a patch adding the proper depends added to
the Kconfig. Check what things bring in the IOMEM etc that is needed
to compile this.

Yours,
Linus Walleij

Re: linux-next: build failure after merge of the final tree (gpio tree related)

[Fabian Vogt]

Hi,

On Wed, Mar 5, 2014, 3:16 PM, Linus Walleij wrote:
> On Wed, Mar 5, 2014 at 2:35 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > drivers/gpio/gpio-zevio.c: In function 'zevio_gpio_port_get':
> > drivers/gpio/gpio-zevio.c:70:2: error: implicit declaration of function 'IOMEM' [-Werror=implicit-function-declaration]
> >   return readl(IOMEM(c->chip.regs + section_offset + port_offset));
> >   ^
> > drivers/gpio/gpio-zevio.c:70:2: warning: passing argument 1 of 'readl' makes pointer from integer without a cast [enabled by default]
> > In file included from include/linux/io.h:22:0,
> >                  from drivers/gpio/gpio-zevio.c:15:
> > arch/powerpc/include/asm/io-defs.h:6:16: note: expected 'const volatile void *' but argument is of type 'int'
> >  DEF_PCI_AC_RET(readl, u32, (const PCI_IO_ADDR addr), (addr), mem, addr)
> >                 ^
> 
> Fabian can you suggest a patch adding the proper depends added to
> the Kconfig. Check what things bring in the IOMEM etc that is needed
> to compile this.

It looks like powerpc doesn't have the IOMEM macro (which just casts to "void __iomem*").
Would "depends on ARM && OF_GPIO" be ok?

> Yours,
> Linus Walleij

Bye,
Fabian

linux-next: build failure after merge of the final tree (gpio tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 786 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/gpio/gpio-sch311x.c: In function 'sch311x_sio_enter':
drivers/gpio/gpio-sch311x.c:115:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]
  outb(SIO_CONFIG_KEY_ENTER, sio_config_port);
  ^
drivers/gpio/gpio-sch311x.c: In function 'sch311x_sio_inb':
drivers/gpio/gpio-sch311x.c:128:2: error: implicit declaration of function 'inb' [-Werror=implicit-function-declaration]
  return inb(sio_config_port + 1);
  ^

Caused by commit 12262bef8f46 ("gpio: add GPIO support for SMSC SCH311x")
from the gpio tree.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the final tree (gpio tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1920 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

In file included from include/asm-generic/gpio.h:13:0,
                 from include/linux/gpio.h:51,
                 from include/linux/of_gpio.h:20,
                 from arch/powerpc/sysdev/ppc4xx_gpio.c:29:
include/linux/gpio/driver.h:85:14: error: 'struct seq_file' declared inside parameter list [-Werror]
include/linux/gpio/driver.h:85:14: error: its scope is only this definition or declaration, which is probably not what you want [-Werror]

Caused by commit 79a9becda894 ("gpiolib: export descriptor-based GPIO
interface") from the gpio tree.

I have applied this fix up patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 29 Oct 2013 01:06:23 +1100
Subject: [PATCH] gpiolib: provide a declaration of seq_file in gpio/driver.h

Fixes this build error:

In file included from include/asm-generic/gpio.h:13:0,
                 from include/linux/gpio.h:51,
                 from include/linux/of_gpio.h:20,
                 from arch/powerpc/sysdev/ppc4xx_gpio.c:29:
include/linux/gpio/driver.h:85:14: error: 'struct seq_file' declared inside parameter list [-Werror]
include/linux/gpio/driver.h:85:14: error: its scope is only this definition or declaration, which is probably not what you want [-Werror]

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/gpio/driver.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index cd9da3885d79..656a27efb2c8 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -5,6 +5,7 @@
 
 struct device;
 struct gpio_desc;
+struct seq_file;
 
 /**
  * struct gpio_chip - abstract a GPIO controller
-- 
1.8.4.rc3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (gpio tree related)

[Linus Walleij]

On Mon, Oct 28, 2013 at 3:12 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Caused by commit 79a9becda894 ("gpiolib: export descriptor-based GPIO
> interface") from the gpio tree.
>
> I have applied this fix up patch for today:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 29 Oct 2013 01:06:23 +1100
> Subject: [PATCH] gpiolib: provide a declaration of seq_file in gpio/driver.h
>
> Fixes this build error:
>
> In file included from include/asm-generic/gpio.h:13:0,
>                  from include/linux/gpio.h:51,
>                  from include/linux/of_gpio.h:20,
>                  from arch/powerpc/sysdev/ppc4xx_gpio.c:29:
> include/linux/gpio/driver.h:85:14: error: 'struct seq_file' declared inside parameter list [-Werror]
> include/linux/gpio/driver.h:85:14: error: its scope is only this definition or declaration, which is probably not what you want [-Werror]
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Patch applied to the GPIO tree, thanks for fixing up our mess!

Yours,
Linus Walleij

linux-next: build failure after merge of the final tree (gpio tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]

Hi Grant,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/gpio/gpio-sodaville.c:130:2: error: unknown field 'dt_translate' specified in initializer
drivers/gpio/gpio-sodaville.c:130:2: warning: initialization from incompatible pointer type [enabled by default]
drivers/gpio/gpio-sodaville.c:130:2: warning: (near initialization for 'irq_domain_sdv_ops.match') [enabled by default]
drivers/gpio/gpio-sodaville.c: In function 'sdv_register_irqsupport':
drivers/gpio/gpio-sodaville.c:152:8: error: 'struct irq_domain' has no member named 'irq_base'
drivers/gpio/gpio-sodaville.c:182:2: error: implicit declaration of function 'irq_domain_add' [-Werror=implicit-function-declaration]
drivers/gpio/gpio-sodaville.c: In function 'sdv_gpio_remove':
drivers/gpio/gpio-sodaville.c:263:2: error: implicit declaration of function 'irq_domain_del' [-Werror=implicit-function-declaration]

Caused by commit 8b26c833d229 ("gpio: Add a driver for Sodaville GPIO
controller") interacting with the irqdomain tree changes.

I have reverted that commit for today.  I am not sure how you should
handle this ... you could send me a fixup patch that I should apply as a
merge fix when merging the irqdomain tree.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (gpio tree related)

[Grant Likely]

On Mon, Feb 06, 2012 at 03:23:46PM +1100, Stephen Rothwell wrote:
> Hi Grant,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/gpio/gpio-sodaville.c:130:2: error: unknown field 'dt_translate' specified in initializer
> drivers/gpio/gpio-sodaville.c:130:2: warning: initialization from incompatible pointer type [enabled by default]
> drivers/gpio/gpio-sodaville.c:130:2: warning: (near initialization for 'irq_domain_sdv_ops.match') [enabled by default]
> drivers/gpio/gpio-sodaville.c: In function 'sdv_register_irqsupport':
> drivers/gpio/gpio-sodaville.c:152:8: error: 'struct irq_domain' has no member named 'irq_base'
> drivers/gpio/gpio-sodaville.c:182:2: error: implicit declaration of function 'irq_domain_add' [-Werror=implicit-function-declaration]
> drivers/gpio/gpio-sodaville.c: In function 'sdv_gpio_remove':
> drivers/gpio/gpio-sodaville.c:263:2: error: implicit declaration of function 'irq_domain_del' [-Werror=implicit-function-declaration]
> 
> Caused by commit 8b26c833d229 ("gpio: Add a driver for Sodaville GPIO
> controller") interacting with the irqdomain tree changes.
> 
> I have reverted that commit for today.  I am not sure how you should
> handle this ... you could send me a fixup patch that I should apply as a
> merge fix when merging the irqdomain tree.

The sodavile is an x86 driver only.  This problem can be solved by
making it depend on x86, which I'll do now.  When x86 is converted to the
new irq_domain code the problem will go even further away.

g.

Re: linux-next: build failure after merge of the final tree (gpio tree related)

[Mark Brown]

On Sun, Feb 05, 2012 at 11:07:08PM -0700, Grant Likely wrote:
> On Mon, Feb 06, 2012 at 03:23:46PM +1100, Stephen Rothwell wrote:

> > drivers/gpio/gpio-sodaville.c: In function 'sdv_register_irqsupport':
> > drivers/gpio/gpio-sodaville.c:152:8: error: 'struct irq_domain' has no member named 'irq_base'

> The sodavile is an x86 driver only.  This problem can be solved by
> making it depend on x86, which I'll do now.  When x86 is converted to the
> new irq_domain code the problem will go even further away.

IIRC I saw a similar issue trying to build the twl-core driver on
Samsung platforms (or possibly x86).