From: "Hefty, Sean" <sean.hefty@intel.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Roland Dreier <roland@kernel.org>
Cc: "linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Eric Dumazet <eric.dumazet@gmail.com>, Tejun Heo <tj@kernel.org>,
Changli Gao <xiaosuo@gmail.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: [PATCH] rdma/addr: Initialize ret to fix build warning
Date: Thu, 17 Mar 2011 16:35:39 -0700 [thread overview]
Message-ID: <CF9C39F99A89134C9CF9C4CCB68B8DDF25CCC10249@orsmsx501.amr.corp.intel.com> (raw)
In-Reply-To: <20110318100418.6556c92c.sfr@canb.auug.org.au>
Commit b23dd4fe42b455af5c6e20966b7d6959fa8352ea (ipv4: Make output
route lookup return rtable directly) resulted in leaving
ret uninitialized, where it may later be returned.
Signed-off-by: Sean Hefty <sean.hefty@intel.com>
---
I didn't actually test this, but it looks correct.
drivers/infiniband/core/addr.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c
index e0ef5fd..4ffc224 100644
--- a/drivers/infiniband/core/addr.c
+++ b/drivers/infiniband/core/addr.c
@@ -204,7 +204,7 @@ static int addr4_resolve(struct sockaddr_in *src_in,
/* If the device does ARP internally, return 'done' */
if (rt->dst.dev->flags & IFF_NOARP) {
- rdma_copy_addr(addr, rt->dst.dev, NULL);
+ ret = rdma_copy_addr(addr, rt->dst.dev, NULL);
goto put;
}
next prev parent reply other threads:[~2011-03-17 23:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 23:04 linux-next: build warning in Linus' tree Stephen Rothwell
2011-03-17 23:35 ` Hefty, Sean [this message]
[not found] ` <CF9C39F99A89134C9CF9C4CCB68B8DDF25CCC10249-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2011-03-17 23:56 ` [PATCH] rdma/addr: Initialize ret to fix build warning Roland Dreier
[not found] ` <AANLkTikB=ZQQG18sDbD2kfFMWdVuUqnzYWOf7KtuBKVc-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-18 1:12 ` David Miller
2011-03-18 1:13 ` linux-next: build warning in Linus' tree David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CF9C39F99A89134C9CF9C4CCB68B8DDF25CCC10249@orsmsx501.amr.corp.intel.com \
--to=sean.hefty@intel.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hal.rosenstock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=roland@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tj@kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).