* linux-next: build warning in Linus' tree
@ 2011-03-17 23:04 Stephen Rothwell
2011-03-17 23:35 ` [PATCH] rdma/addr: Initialize ret to fix build warning Hefty, Sean
2011-03-18 1:13 ` linux-next: build warning in Linus' tree David Miller
0 siblings, 2 replies; 5+ messages in thread
From: Stephen Rothwell @ 2011-03-17 23:04 UTC (permalink / raw)
To: Roland Dreier
Cc: linux-next, linux-kernel, David S. Miller, Hal Rosenstock,
Eric Dumazet, Tejun Heo, Changli Gao, linux-rdma
[-- Attachment #1: Type: text/plain, Size: 545 bytes --]
Hi all,
After merging the Linus' tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
drivers/infiniband/core/addr.c: In function 'addr4_resolve':
drivers/infiniband/core/addr.c:188: warning: 'ret' may be used uninitialized in this function
I didn't notice this one before, sorry.
I don't know what introduced it, but the third if statement in the
function will make us use "ret" uninitialised.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] rdma/addr: Initialize ret to fix build warning
2011-03-17 23:04 linux-next: build warning in Linus' tree Stephen Rothwell
@ 2011-03-17 23:35 ` Hefty, Sean
[not found] ` <CF9C39F99A89134C9CF9C4CCB68B8DDF25CCC10249-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2011-03-18 1:13 ` linux-next: build warning in Linus' tree David Miller
1 sibling, 1 reply; 5+ messages in thread
From: Hefty, Sean @ 2011-03-17 23:35 UTC (permalink / raw)
To: Stephen Rothwell, Roland Dreier
Cc: linux-next, linux-kernel, David S. Miller, Hal Rosenstock,
Eric Dumazet, Tejun Heo, Changli Gao, linux-rdma
Commit b23dd4fe42b455af5c6e20966b7d6959fa8352ea (ipv4: Make output
route lookup return rtable directly) resulted in leaving
ret uninitialized, where it may later be returned.
Signed-off-by: Sean Hefty <sean.hefty@intel.com>
---
I didn't actually test this, but it looks correct.
drivers/infiniband/core/addr.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c
index e0ef5fd..4ffc224 100644
--- a/drivers/infiniband/core/addr.c
+++ b/drivers/infiniband/core/addr.c
@@ -204,7 +204,7 @@ static int addr4_resolve(struct sockaddr_in *src_in,
/* If the device does ARP internally, return 'done' */
if (rt->dst.dev->flags & IFF_NOARP) {
- rdma_copy_addr(addr, rt->dst.dev, NULL);
+ ret = rdma_copy_addr(addr, rt->dst.dev, NULL);
goto put;
}
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] rdma/addr: Initialize ret to fix build warning
[not found] ` <CF9C39F99A89134C9CF9C4CCB68B8DDF25CCC10249-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
@ 2011-03-17 23:56 ` Roland Dreier
[not found] ` <AANLkTikB=ZQQG18sDbD2kfFMWdVuUqnzYWOf7KtuBKVc-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Roland Dreier @ 2011-03-17 23:56 UTC (permalink / raw)
To: Hefty, Sean
Cc: Stephen Rothwell, linux-next-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, David S. Miller,
Hal Rosenstock, Eric Dumazet, Tejun Heo, Changli Gao,
linux-rdma-u79uwXL29TY76Z2rM5mHXA
On Thu, Mar 17, 2011 at 4:35 PM, Hefty, Sean <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
> Commit b23dd4fe42b455af5c6e20966b7d6959fa8352ea (ipv4: Make output
> route lookup return rtable directly) resulted in leaving
> ret uninitialized, where it may later be returned.
Looks good to me, I'll merge this.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] rdma/addr: Initialize ret to fix build warning
[not found] ` <AANLkTikB=ZQQG18sDbD2kfFMWdVuUqnzYWOf7KtuBKVc-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2011-03-18 1:12 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2011-03-18 1:12 UTC (permalink / raw)
To: roland-DgEjT+Ai2ygdnm+yROfE0A
Cc: sean.hefty-ral2JQCrhuEAvxtiuMwx3w, sfr-3FnU+UHB4dNDw9hX6IcOSA,
linux-next-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w,
eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w, tj-DgEjT+Ai2ygdnm+yROfE0A,
xiaosuo-Re5JQEeQqe8AvxtiuMwx3w,
linux-rdma-u79uwXL29TY76Z2rM5mHXA
From: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Date: Thu, 17 Mar 2011 16:56:27 -0700
> On Thu, Mar 17, 2011 at 4:35 PM, Hefty, Sean <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
>> Commit b23dd4fe42b455af5c6e20966b7d6959fa8352ea (ipv4: Make output
>> route lookup return rtable directly) resulted in leaving
>> ret uninitialized, where it may later be returned.
>
> Looks good to me, I'll merge this.
Thanks Roland.
Acked-by: David S. Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: build warning in Linus' tree
2011-03-17 23:04 linux-next: build warning in Linus' tree Stephen Rothwell
2011-03-17 23:35 ` [PATCH] rdma/addr: Initialize ret to fix build warning Hefty, Sean
@ 2011-03-18 1:13 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2011-03-18 1:13 UTC (permalink / raw)
To: sfr
Cc: roland, linux-next, linux-kernel, hal.rosenstock, eric.dumazet,
tj, xiaosuo, linux-rdma
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 18 Mar 2011 10:04:18 +1100
> Hi all,
>
> After merging the Linus' tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> drivers/infiniband/core/addr.c: In function 'addr4_resolve':
> drivers/infiniband/core/addr.c:188: warning: 'ret' may be used uninitialized in this function
>
> I didn't notice this one before, sorry.
>
> I don't know what introduced it, but the third if statement in the
> function will make us use "ret" uninitialised.
It was the ipv4 route lookup interface changes.
Roland has received a fix already, and will merge it via the infiniband
tree.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-03-18 1:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-17 23:04 linux-next: build warning in Linus' tree Stephen Rothwell
2011-03-17 23:35 ` [PATCH] rdma/addr: Initialize ret to fix build warning Hefty, Sean
[not found] ` <CF9C39F99A89134C9CF9C4CCB68B8DDF25CCC10249-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2011-03-17 23:56 ` Roland Dreier
[not found] ` <AANLkTikB=ZQQG18sDbD2kfFMWdVuUqnzYWOf7KtuBKVc-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-18 1:12 ` David Miller
2011-03-18 1:13 ` linux-next: build warning in Linus' tree David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).