* linux-next: build failure after merge of the kspp tree
@ 2022-03-16 7:32 Stephen Rothwell
2022-03-16 12:00 ` linux-next: build failure after merge of the kspp tree (in pinctrl-npcm7xx) Jonathan Neuschäfer
2022-03-17 1:01 ` linux-next: build failure after merge of the kspp tree Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Rothwell @ 2022-03-16 7:32 UTC (permalink / raw)
To: Kees Cook
Cc: Jonathan Neuschäfer, Linus Walleij, Tomer Maimon,
Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 2882 bytes --]
Hi all,
After merging the kspp tree, today's linux-next build (x86_64
allmodconfig) failed like this:
In file included from include/linux/bitmap.h:9,
from include/linux/cpumask.h:12,
from arch/x86/include/asm/paravirt.h:17,
from arch/x86/include/asm/irqflags.h:63,
from include/linux/irqflags.h:16,
from include/linux/rcupdate.h:26,
from include/linux/rculist.h:11,
from include/linux/pid.h:5,
from include/linux/sched.h:14,
from include/linux/ratelimit.h:6,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c:5:
drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c: In function 'npcmgpio_irq_handler':
include/linux/find.h:40:23: error: array subscript 'long unsigned int[0]' is partly outside array bounds of 'u32[1]' {aka 'unsigned int[1]'} [-Werror=array-bounds]
40 | val = *addr & GENMASK(size - 1, offset);
| ^~~~~
drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c:219:13: note: while referencing 'sts'
219 | u32 sts, en, bit;
| ^~~
Caused by commit
3b588e43ee5c ("pinctrl: nuvoton: add NPCM7xx pinctrl and GPIO driver")
probably exposed by commit
a1d1e0e3d80a ("pinctrl: nuvoton: Add driver for WPCM450")
from the pinctrl tree and enabling -Werror=array-bounds.
I have applied the following hack patch for today.
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 16 Mar 2022 18:12:14 +1100
Subject: [PATCH] fixup for "pinctrl: nuvoton: add NPCM7xx pinctrl and GPIO driver"
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
index 41136f63014a..fddcb7d6bdf4 100644
--- a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
+++ b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
@@ -216,7 +216,8 @@ static void npcmgpio_irq_handler(struct irq_desc *desc)
struct gpio_chip *gc;
struct irq_chip *chip;
struct npcm7xx_gpio *bank;
- u32 sts, en, bit;
+ unsigned long sts, bit;
+ u32 en;
gc = irq_desc_get_handler_data(desc);
bank = gpiochip_get_data(gc);
@@ -225,7 +226,7 @@ static void npcmgpio_irq_handler(struct irq_desc *desc)
chained_irq_enter(chip, desc);
sts = ioread32(bank->base + NPCM7XX_GP_N_EVST);
en = ioread32(bank->base + NPCM7XX_GP_N_EVEN);
- dev_dbg(bank->gc.parent, "==> got irq sts %.8x %.8x\n", sts,
+ dev_dbg(bank->gc.parent, "==> got irq sts %.8lx %.8x\n", sts,
en);
sts &= en;
--
2.34.1
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: linux-next: build failure after merge of the kspp tree (in pinctrl-npcm7xx)
2022-03-16 7:32 linux-next: build failure after merge of the kspp tree Stephen Rothwell
@ 2022-03-16 12:00 ` Jonathan Neuschäfer
2022-03-17 1:01 ` linux-next: build failure after merge of the kspp tree Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Jonathan Neuschäfer @ 2022-03-16 12:00 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Kees Cook, Jonathan Neuschäfer, Linus Walleij, Tomer Maimon,
Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 2911 bytes --]
Hello Stephen, Tomer, and others,
On Wed, Mar 16, 2022 at 06:32:27PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the kspp tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
[...]
> drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c: In function 'npcmgpio_irq_handler':
> include/linux/find.h:40:23: error: array subscript 'long unsigned int[0]' is partly outside array bounds of 'u32[1]' {aka 'unsigned int[1]'} [-Werror=array-bounds]
> 40 | val = *addr & GENMASK(size - 1, offset);
> | ^~~~~
> drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c:219:13: note: while referencing 'sts'
> 219 | u32 sts, en, bit;
> | ^~~
Quoting the code in pinctrl-npcm7xx:
for_each_set_bit(bit, (const void *)&sts, NPCM7XX_GPIO_PER_BANK)
generic_handle_domain_irq(gc->irq.domain, bit);
The cast is indeed already a bit suspicious, because such casts can hide
type mismatch bugs.
The pinctrl-npcm7xx driver probably won't actually *run* on a 64-bit
platform (I guess there will be a separate pinctrl-npcm8xx driver for
the upcoming 64-bit platform from Nuvoton) but it's better not to have
unnecessary 32bit-isms.
>
> Caused by commit
>
> 3b588e43ee5c ("pinctrl: nuvoton: add NPCM7xx pinctrl and GPIO driver")
>
> probably exposed by commit
>
> a1d1e0e3d80a ("pinctrl: nuvoton: Add driver for WPCM450")
>
> from the pinctrl tree and enabling -Werror=array-bounds.
>
> I have applied the following hack patch for today.
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 16 Mar 2022 18:12:14 +1100
> Subject: [PATCH] fixup for "pinctrl: nuvoton: add NPCM7xx pinctrl and GPIO driver"
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
> index 41136f63014a..fddcb7d6bdf4 100644
> --- a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
> +++ b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
> @@ -216,7 +216,8 @@ static void npcmgpio_irq_handler(struct irq_desc *desc)
> struct gpio_chip *gc;
> struct irq_chip *chip;
> struct npcm7xx_gpio *bank;
> - u32 sts, en, bit;
> + unsigned long sts, bit;
> + u32 en;
>
> gc = irq_desc_get_handler_data(desc);
> bank = gpiochip_get_data(gc);
> @@ -225,7 +226,7 @@ static void npcmgpio_irq_handler(struct irq_desc *desc)
> chained_irq_enter(chip, desc);
> sts = ioread32(bank->base + NPCM7XX_GP_N_EVST);
> en = ioread32(bank->base + NPCM7XX_GP_N_EVEN);
> - dev_dbg(bank->gc.parent, "==> got irq sts %.8x %.8x\n", sts,
> + dev_dbg(bank->gc.parent, "==> got irq sts %.8lx %.8x\n", sts,
> en);
This fix looks reasonable to me.
Thanks,
Jonathan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: build failure after merge of the kspp tree
2022-03-16 7:32 linux-next: build failure after merge of the kspp tree Stephen Rothwell
2022-03-16 12:00 ` linux-next: build failure after merge of the kspp tree (in pinctrl-npcm7xx) Jonathan Neuschäfer
@ 2022-03-17 1:01 ` Linus Walleij
2022-03-17 8:24 ` Marc Zyngier
1 sibling, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2022-03-17 1:01 UTC (permalink / raw)
To: Stephen Rothwell, Marc Zyngier, Bartosz Golaszewski
Cc: Kees Cook, Jonathan Neuschäfer, Tomer Maimon,
Linux Kernel Mailing List, Linux Next Mailing List
On Wed, Mar 16, 2022 at 8:32 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> After merging the kspp tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
(...)
> I have applied the following hack patch for today.
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 16 Mar 2022 18:12:14 +1100
> Subject: [PATCH] fixup for "pinctrl: nuvoton: add NPCM7xx pinctrl and GPIO driver"
Patch looks good but didn't apply to he pinctrl tree when I
tried to simply apply it there.
Since it is touching IRQ handlers, I suspect this could maybe
apply to Marc Z:s or Bartosz trees? Or can you see which one
needs this?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: build failure after merge of the kspp tree
2022-03-17 1:01 ` linux-next: build failure after merge of the kspp tree Linus Walleij
@ 2022-03-17 8:24 ` Marc Zyngier
0 siblings, 0 replies; 4+ messages in thread
From: Marc Zyngier @ 2022-03-17 8:24 UTC (permalink / raw)
To: Linus Walleij
Cc: Stephen Rothwell, Bartosz Golaszewski, Kees Cook,
Jonathan Neuschäfer, Tomer Maimon,
Linux Kernel Mailing List, Linux Next Mailing List
On 2022-03-17 01:01, Linus Walleij wrote:
> On Wed, Mar 16, 2022 at 8:32 AM Stephen Rothwell <sfr@canb.auug.org.au>
> wrote:
>
>> After merging the kspp tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
> (...)
>> I have applied the following hack patch for today.
>>
>> From: Stephen Rothwell <sfr@canb.auug.org.au>
>> Date: Wed, 16 Mar 2022 18:12:14 +1100
>> Subject: [PATCH] fixup for "pinctrl: nuvoton: add NPCM7xx pinctrl and
>> GPIO driver"
>
> Patch looks good but didn't apply to he pinctrl tree when I
> tried to simply apply it there.
>
> Since it is touching IRQ handlers, I suspect this could maybe
> apply to Marc Z:s or Bartosz trees? Or can you see which one
> needs this?
Yes, I've now picked this up.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-17 8:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-16 7:32 linux-next: build failure after merge of the kspp tree Stephen Rothwell
2022-03-16 12:00 ` linux-next: build failure after merge of the kspp tree (in pinctrl-npcm7xx) Jonathan Neuschäfer
2022-03-17 1:01 ` linux-next: build failure after merge of the kspp tree Linus Walleij
2022-03-17 8:24 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).