linux-next: Fixes tag needs some work in the mm-hotfixes tree

linux-next: Fixes tag needs some work in the mm-hotfixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

Hi all,

In commit

  f8ff23429c62 ("kernel/Kconfig.kexec: drop select of KEXEC for CRASH_DUMP")

Fixes tag

  Fixes: commit 89cde455915f ("kexec: consolidate kexec and crash options into kernel/Kconfig.kexec")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the mm-hotfixes tree

[Baoquan He]

On 11/30/23 at 07:43am, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   f8ff23429c62 ("kernel/Kconfig.kexec: drop select of KEXEC for CRASH_DUMP")
> 
> Fixes tag
> 
>   Fixes: commit 89cde455915f ("kexec: consolidate kexec and crash options into kernel/Kconfig.kexec")
           ~~~~~~
Sorry, my fault. I didn't read the
Documentation/process/submitting-patches.rst carefully.

Maybe Andrew can help remove the 'commit' after 'Fixes:', thanks.

> 
> has these problem(s):
> 
>   - leading word 'commit' unexpected

linux-next: Fixes tag needs some work in the mm-hotfixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

Hi all,

In commit

  ade5d74c84d4 ("lazy tlb: consolidate lazy tlb mm switching fix")

Fixes tag

  Fixes: a665eec0a22e1 ("powerpc/64s/radix: Fix mm_cpumask trimming race vs k>

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes
  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

I guess this is just a quoted commit message in this commit message that
has confused my script :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the mm-hotfixes tree

[Peter Xu]

On Mon, Aug 08, 2022 at 07:19:41AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   b2f4c6e29531 ("mm/smaps: don't access young/dirty bit if pte unpresent")
> 
> Fixes tag
> 
>   Fixes: b1d4d9e0cbd0 ("proc/smaps: carefully handle migration entries", 2012-05-31)
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing quotes
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> 
> Please do not include the date part - it adds nothing.

The date confused the script.  I'd only rely on the 1st column (which
should definitely be the commit ID) normally for Fixes, but will remember
to use the general format in the future..

Thanks.

-- 
Peter Xu

linux-next: Fixes tag needs some work in the mm-hotfixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

Hi all,

In commit

  b2f4c6e29531 ("mm/smaps: don't access young/dirty bit if pte unpresent")

Fixes tag

  Fixes: b1d4d9e0cbd0 ("proc/smaps: carefully handle migration entries", 2012-05-31)

has these problem(s):

  - Subject has leading but no trailing quotes
  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Please do not include the date part - it adds nothing.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the mm-hotfixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 793 bytes --]

Hi all,

In commit

  9d4dacd9cc3f ("Revert "mm/memory-failure.c: skip huge_zero_page in memory_failure()"")

Fixes tag

  Fixes: d173d5417fb ("mm/memory-failure.c: skip huge_zero_page in memory_failure()")

has these problem(s):

  - SHA1 should be at least 12 digits long

In commit

  7b5cc291112f ("mm/huge_memory: do not overkill when splitting huge_zero_page")

Fixes tag

  Fixes: d173d5417fb ("mm/memory-failure.c: skip huge_zero_page in memory_failure()")

has these problem(s):

  - SHA1 should be at least 12 digits long

These are probably not worth rebasing for but this can be fixed for the
future by setting core.abbrev to 12 (or more) or (for git v2.11 or later)
just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]