* [PATCH] sunrpc: Remove unnecessary variable
@ 2016-08-08 9:13 Amitoj Kaur Chawla
2016-08-08 13:49 ` Anna Schumaker
0 siblings, 1 reply; 2+ messages in thread
From: Amitoj Kaur Chawla @ 2016-08-08 9:13 UTC (permalink / raw)
To: bfields, jlayton, trond.myklebust, anna.schumaker, davem,
linux-nfs, netdev, linux-kernel
Cc: julia.lawall
The variable `err` is not used anywhere and just returns the
predefined value `0` at the end of the function. Hence, remove the
variable and return 0 explicitly.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
net/sunrpc/clnt.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
index b7f2104..0a775fa 100644
--- a/net/sunrpc/clnt.c
+++ b/net/sunrpc/clnt.c
@@ -184,7 +184,6 @@ static int __rpc_clnt_handle_event(struct rpc_clnt *clnt, unsigned long event,
struct super_block *sb)
{
struct dentry *dentry;
- int err = 0;
switch (event) {
case RPC_PIPEFS_MOUNT:
@@ -201,7 +200,7 @@ static int __rpc_clnt_handle_event(struct rpc_clnt *clnt, unsigned long event,
printk(KERN_ERR "%s: unknown event: %ld\n", __func__, event);
return -ENOTSUPP;
}
- return err;
+ return 0;
}
static int __rpc_pipefs_event(struct rpc_clnt *clnt, unsigned long event,
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] sunrpc: Remove unnecessary variable
2016-08-08 9:13 [PATCH] sunrpc: Remove unnecessary variable Amitoj Kaur Chawla
@ 2016-08-08 13:49 ` Anna Schumaker
0 siblings, 0 replies; 2+ messages in thread
From: Anna Schumaker @ 2016-08-08 13:49 UTC (permalink / raw)
To: Amitoj Kaur Chawla, bfields, jlayton, trond.myklebust, davem,
linux-nfs, netdev, linux-kernel
Cc: julia.lawall
On 08/08/2016 05:13 AM, Amitoj Kaur Chawla wrote:
> The variable `err` is not used anywhere and just returns the
> predefined value `0` at the end of the function. Hence, remove the
> variable and return 0 explicitly.
Makes sense to me. Thanks!
Anna
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> net/sunrpc/clnt.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
> index b7f2104..0a775fa 100644
> --- a/net/sunrpc/clnt.c
> +++ b/net/sunrpc/clnt.c
> @@ -184,7 +184,6 @@ static int __rpc_clnt_handle_event(struct rpc_clnt *clnt, unsigned long event,
> struct super_block *sb)
> {
> struct dentry *dentry;
> - int err = 0;
>
> switch (event) {
> case RPC_PIPEFS_MOUNT:
> @@ -201,7 +200,7 @@ static int __rpc_clnt_handle_event(struct rpc_clnt *clnt, unsigned long event,
> printk(KERN_ERR "%s: unknown event: %ld\n", __func__, event);
> return -ENOTSUPP;
> }
> - return err;
> + return 0;
> }
>
> static int __rpc_pipefs_event(struct rpc_clnt *clnt, unsigned long event,
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-08 13:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-08 9:13 [PATCH] sunrpc: Remove unnecessary variable Amitoj Kaur Chawla
2016-08-08 13:49 ` Anna Schumaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).