* [PATCH] libtirpc: add missing extern
@ 2022-09-19 23:59 Rosen Penev
2022-09-20 19:28 ` Steve Dickson
2022-10-25 16:36 ` Steve Dickson
0 siblings, 2 replies; 5+ messages in thread
From: Rosen Penev @ 2022-09-19 23:59 UTC (permalink / raw)
To: linux-nfs
Fixes compilation warning.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
src/svc_auth.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/svc_auth.c b/src/svc_auth.c
index ce8bbd8..789d6af 100644
--- a/src/svc_auth.c
+++ b/src/svc_auth.c
@@ -66,6 +66,9 @@ static struct authsvc *Auths = NULL;
extern SVCAUTH svc_auth_none;
+#ifdef AUTHDES_SUPPORT
+extern enum auth_stat _svcauth_des(struct svc_req *rqst, struct rpc_msg *msg);
+#endif
/*
* The call rpc message, msg has been obtained from the wire. The msg contains
* the raw form of credentials and verifiers. authenticate returns AUTH_OK
--
2.37.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] libtirpc: add missing extern
2022-09-19 23:59 [PATCH] libtirpc: add missing extern Rosen Penev
@ 2022-09-20 19:28 ` Steve Dickson
2022-09-20 20:31 ` Rosen Penev
2022-10-25 16:36 ` Steve Dickson
1 sibling, 1 reply; 5+ messages in thread
From: Steve Dickson @ 2022-09-20 19:28 UTC (permalink / raw)
To: Rosen Penev, linux-nfs
On 9/19/22 7:59 PM, Rosen Penev wrote:
> Fixes compilation warning.
What was the warning? Plus AUTH_DES is no longer supported.
steved.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> src/svc_auth.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/svc_auth.c b/src/svc_auth.c
> index ce8bbd8..789d6af 100644
> --- a/src/svc_auth.c
> +++ b/src/svc_auth.c
> @@ -66,6 +66,9 @@ static struct authsvc *Auths = NULL;
>
> extern SVCAUTH svc_auth_none;
>
> +#ifdef AUTHDES_SUPPORT
> +extern enum auth_stat _svcauth_des(struct svc_req *rqst, struct rpc_msg *msg);
> +#endif
> /*
> * The call rpc message, msg has been obtained from the wire. The msg contains
> * the raw form of credentials and verifiers. authenticate returns AUTH_OK
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libtirpc: add missing extern
2022-09-20 19:28 ` Steve Dickson
@ 2022-09-20 20:31 ` Rosen Penev
2022-10-24 19:39 ` Rosen Penev
0 siblings, 1 reply; 5+ messages in thread
From: Rosen Penev @ 2022-09-20 20:31 UTC (permalink / raw)
To: Steve Dickson; +Cc: linux-nfs
On Tue, Sep 20, 2022 at 12:28 PM Steve Dickson <steved@redhat.com> wrote:
>
>
>
> On 9/19/22 7:59 PM, Rosen Penev wrote:
> > Fixes compilation warning.
> What was the warning? Plus AUTH_DES is no longer supported.
Implicit function declaration as it's not in a header file or anything.
I found the issue from doing a meson conversion for libtirpc:
https://github.com/mesonbuild/wrapdb/pull/644
I have no idea about AUTH_DES or what it's used for.
>
> steved.
> >
> > Signed-off-by: Rosen Penev <rosenp@gmail.com>
> > ---
> > src/svc_auth.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/src/svc_auth.c b/src/svc_auth.c
> > index ce8bbd8..789d6af 100644
> > --- a/src/svc_auth.c
> > +++ b/src/svc_auth.c
> > @@ -66,6 +66,9 @@ static struct authsvc *Auths = NULL;
> >
> > extern SVCAUTH svc_auth_none;
> >
> > +#ifdef AUTHDES_SUPPORT
> > +extern enum auth_stat _svcauth_des(struct svc_req *rqst, struct rpc_msg *msg);
> > +#endif
> > /*
> > * The call rpc message, msg has been obtained from the wire. The msg contains
> > * the raw form of credentials and verifiers. authenticate returns AUTH_OK
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libtirpc: add missing extern
2022-09-20 20:31 ` Rosen Penev
@ 2022-10-24 19:39 ` Rosen Penev
0 siblings, 0 replies; 5+ messages in thread
From: Rosen Penev @ 2022-10-24 19:39 UTC (permalink / raw)
To: Steve Dickson; +Cc: linux-nfs
On Tue, Sep 20, 2022 at 1:31 PM Rosen Penev <rosenp@gmail.com> wrote:
>
> On Tue, Sep 20, 2022 at 12:28 PM Steve Dickson <steved@redhat.com> wrote:
> >
> >
> >
> > On 9/19/22 7:59 PM, Rosen Penev wrote:
> > > Fixes compilation warning.
> > What was the warning? Plus AUTH_DES is no longer supported.
> Implicit function declaration as it's not in a header file or anything.
>
> I found the issue from doing a meson conversion for libtirpc:
> https://github.com/mesonbuild/wrapdb/pull/644
>
> I have no idea about AUTH_DES or what it's used for.
ping.
> >
> > steved.
> > >
> > > Signed-off-by: Rosen Penev <rosenp@gmail.com>
> > > ---
> > > src/svc_auth.c | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/src/svc_auth.c b/src/svc_auth.c
> > > index ce8bbd8..789d6af 100644
> > > --- a/src/svc_auth.c
> > > +++ b/src/svc_auth.c
> > > @@ -66,6 +66,9 @@ static struct authsvc *Auths = NULL;
> > >
> > > extern SVCAUTH svc_auth_none;
> > >
> > > +#ifdef AUTHDES_SUPPORT
> > > +extern enum auth_stat _svcauth_des(struct svc_req *rqst, struct rpc_msg *msg);
> > > +#endif
> > > /*
> > > * The call rpc message, msg has been obtained from the wire. The msg contains
> > > * the raw form of credentials and verifiers. authenticate returns AUTH_OK
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libtirpc: add missing extern
2022-09-19 23:59 [PATCH] libtirpc: add missing extern Rosen Penev
2022-09-20 19:28 ` Steve Dickson
@ 2022-10-25 16:36 ` Steve Dickson
1 sibling, 0 replies; 5+ messages in thread
From: Steve Dickson @ 2022-10-25 16:36 UTC (permalink / raw)
To: Rosen Penev, linux-nfs
On 9/19/22 7:59 PM, Rosen Penev wrote:
> Fixes compilation warning.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Committed...
steved.
> ---
> src/svc_auth.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/svc_auth.c b/src/svc_auth.c
> index ce8bbd8..789d6af 100644
> --- a/src/svc_auth.c
> +++ b/src/svc_auth.c
> @@ -66,6 +66,9 @@ static struct authsvc *Auths = NULL;
>
> extern SVCAUTH svc_auth_none;
>
> +#ifdef AUTHDES_SUPPORT
> +extern enum auth_stat _svcauth_des(struct svc_req *rqst, struct rpc_msg *msg);
> +#endif
> /*
> * The call rpc message, msg has been obtained from the wire. The msg contains
> * the raw form of credentials and verifiers. authenticate returns AUTH_OK
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-10-25 16:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-19 23:59 [PATCH] libtirpc: add missing extern Rosen Penev
2022-09-20 19:28 ` Steve Dickson
2022-09-20 20:31 ` Rosen Penev
2022-10-24 19:39 ` Rosen Penev
2022-10-25 16:36 ` Steve Dickson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).