Linux-NFS Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH net-next] xprtrdma: Use struct_size() in kzalloc()
@ 2019-01-31  0:46 Gustavo A. R. Silva
  2019-01-31 14:11 ` Chuck Lever
  0 siblings, 1 reply; 9+ messages in thread
From: Gustavo A. R. Silva @ 2019-01-31  0:46 UTC (permalink / raw)
  To: Trond Myklebust, Anna Schumaker, J. Bruce Fields, Jeff Layton,
	David S. Miller
  Cc: linux-nfs, netdev, linux-kernel, Gustavo A. R. Silva

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    struct boo entry[];
};

instance = kzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 net/sunrpc/xprtrdma/verbs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
index 4994e75945b8..9e8cf7456840 100644
--- a/net/sunrpc/xprtrdma/verbs.c
+++ b/net/sunrpc/xprtrdma/verbs.c
@@ -811,8 +811,7 @@ static struct rpcrdma_sendctx *rpcrdma_sendctx_create(struct rpcrdma_ia *ia)
 {
 	struct rpcrdma_sendctx *sc;
 
-	sc = kzalloc(sizeof(*sc) +
-		     ia->ri_max_send_sges * sizeof(struct ib_sge),
+	sc = kzalloc(struct_size(sc, sc_sges, ia->ri_max_send_sges),
 		     GFP_KERNEL);
 	if (!sc)
 		return NULL;
-- 
2.20.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH net-next] xprtrdma: Use struct_size() in kzalloc()
  2019-01-31  0:46 [PATCH net-next] xprtrdma: Use struct_size() in kzalloc() Gustavo A. R. Silva
@ 2019-01-31 14:11 ` Chuck Lever
  2019-02-08  3:49   ` Gustavo A. R. Silva
  2019-03-28 20:41   ` Gustavo A. R. Silva
  0 siblings, 2 replies; 9+ messages in thread
From: Chuck Lever @ 2019-01-31 14:11 UTC (permalink / raw)
  To: Gustavo A. R. Silva
  Cc: Trond Myklebust, Anna Schumaker, Bruce Fields, Jeff Layton,
	David S. Miller, Linux NFS Mailing List, netdev, linux-kernel



> On Jan 30, 2019, at 7:46 PM, Gustavo A. R. Silva <gustavo@embeddedor.com> wrote:
> 
> One of the more common cases of allocation size calculations is finding
> the size of a structure that has a zero-sized array at the end, along
> with memory for some number of elements for that array. For example:
> 
> struct foo {
>    int stuff;
>    struct boo entry[];
> };
> 
> instance = kzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);
> 
> Instead of leaving these open-coded and prone to type mistakes, we can
> now use the new struct_size() helper:
> 
> instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);
> 
> This code was detected with the help of Coccinelle.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Reviewed-by: Chuck Lever <chuck.lever@oracle.com>


> ---
> net/sunrpc/xprtrdma/verbs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
> index 4994e75945b8..9e8cf7456840 100644
> --- a/net/sunrpc/xprtrdma/verbs.c
> +++ b/net/sunrpc/xprtrdma/verbs.c
> @@ -811,8 +811,7 @@ static struct rpcrdma_sendctx *rpcrdma_sendctx_create(struct rpcrdma_ia *ia)
> {
> 	struct rpcrdma_sendctx *sc;
> 
> -	sc = kzalloc(sizeof(*sc) +
> -		     ia->ri_max_send_sges * sizeof(struct ib_sge),
> +	sc = kzalloc(struct_size(sc, sc_sges, ia->ri_max_send_sges),
> 		     GFP_KERNEL);
> 	if (!sc)
> 		return NULL;
> -- 
> 2.20.1
> 

--
Chuck Lever




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH net-next] xprtrdma: Use struct_size() in kzalloc()
  2019-01-31 14:11 ` Chuck Lever
@ 2019-02-08  3:49   ` Gustavo A. R. Silva
  2019-03-28 20:41   ` Gustavo A. R. Silva
  1 sibling, 0 replies; 9+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-08  3:49 UTC (permalink / raw)
  To: Chuck Lever
  Cc: Trond Myklebust, Anna Schumaker, Bruce Fields, Jeff Layton,
	David S. Miller, Linux NFS Mailing List, netdev, linux-kernel



On 1/31/19 8:11 AM, Chuck Lever wrote:
> 
> 
>> On Jan 30, 2019, at 7:46 PM, Gustavo A. R. Silva <gustavo@embeddedor.com> wrote:
>>
>> One of the more common cases of allocation size calculations is finding
>> the size of a structure that has a zero-sized array at the end, along
>> with memory for some number of elements for that array. For example:
>>
>> struct foo {
>>    int stuff;
>>    struct boo entry[];
>> };
>>
>> instance = kzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);
>>
>> Instead of leaving these open-coded and prone to type mistakes, we can
>> now use the new struct_size() helper:
>>
>> instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);
>>
>> This code was detected with the help of Coccinelle.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> 
> Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
> 

Thanks, Chuck.

--
Gustavo

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH net-next] xprtrdma: Use struct_size() in kzalloc()
  2019-01-31 14:11 ` Chuck Lever
  2019-02-08  3:49   ` Gustavo A. R. Silva
@ 2019-03-28 20:41   ` Gustavo A. R. Silva
  2019-05-23 22:36     ` Gustavo A. R. Silva
  1 sibling, 1 reply; 9+ messages in thread
From: Gustavo A. R. Silva @ 2019-03-28 20:41 UTC (permalink / raw)
  To: Chuck Lever
  Cc: Trond Myklebust, Anna Schumaker, Bruce Fields, Jeff Layton,
	David S. Miller, Linux NFS Mailing List, netdev, linux-kernel

Hi all,

Friendly ping:

Who can take this?

Thanks
--
Gustavo

On 1/31/19 8:11 AM, Chuck Lever wrote:
> 
> 
>> On Jan 30, 2019, at 7:46 PM, Gustavo A. R. Silva <gustavo@embeddedor.com> wrote:
>>
>> One of the more common cases of allocation size calculations is finding
>> the size of a structure that has a zero-sized array at the end, along
>> with memory for some number of elements for that array. For example:
>>
>> struct foo {
>>    int stuff;
>>    struct boo entry[];
>> };
>>
>> instance = kzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);
>>
>> Instead of leaving these open-coded and prone to type mistakes, we can
>> now use the new struct_size() helper:
>>
>> instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);
>>
>> This code was detected with the help of Coccinelle.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> 
> Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
> 
> 
>> ---
>> net/sunrpc/xprtrdma/verbs.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
>> index 4994e75945b8..9e8cf7456840 100644
>> --- a/net/sunrpc/xprtrdma/verbs.c
>> +++ b/net/sunrpc/xprtrdma/verbs.c
>> @@ -811,8 +811,7 @@ static struct rpcrdma_sendctx *rpcrdma_sendctx_create(struct rpcrdma_ia *ia)
>> {
>> 	struct rpcrdma_sendctx *sc;
>>
>> -	sc = kzalloc(sizeof(*sc) +
>> -		     ia->ri_max_send_sges * sizeof(struct ib_sge),
>> +	sc = kzalloc(struct_size(sc, sc_sges, ia->ri_max_send_sges),
>> 		     GFP_KERNEL);
>> 	if (!sc)
>> 		return NULL;
>> -- 
>> 2.20.1
>>
> 
> --
> Chuck Lever
> 
> 
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH net-next] xprtrdma: Use struct_size() in kzalloc()
  2019-03-28 20:41   ` Gustavo A. R. Silva
@ 2019-05-23 22:36     ` Gustavo A. R. Silva
  2019-05-23 23:02       ` Chuck Lever
  2019-05-23 23:32       ` David Miller
  0 siblings, 2 replies; 9+ messages in thread
From: Gustavo A. R. Silva @ 2019-05-23 22:36 UTC (permalink / raw)
  To: Chuck Lever
  Cc: Trond Myklebust, Anna Schumaker, Bruce Fields, Jeff Layton,
	David S. Miller, Linux NFS Mailing List, netdev, linux-kernel

Hi Dave,

I wonder if you can take this patch.

Thanks
--
Gustavo

On 3/28/19 3:41 PM, Gustavo A. R. Silva wrote:
> Hi all,
> 
> Friendly ping:
> 
> Who can take this?
> 
> Thanks
> --
> Gustavo
> 
> On 1/31/19 8:11 AM, Chuck Lever wrote:
>>
>>
>>> On Jan 30, 2019, at 7:46 PM, Gustavo A. R. Silva <gustavo@embeddedor.com> wrote:
>>>
>>> One of the more common cases of allocation size calculations is finding
>>> the size of a structure that has a zero-sized array at the end, along
>>> with memory for some number of elements for that array. For example:
>>>
>>> struct foo {
>>>    int stuff;
>>>    struct boo entry[];
>>> };
>>>
>>> instance = kzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);
>>>
>>> Instead of leaving these open-coded and prone to type mistakes, we can
>>> now use the new struct_size() helper:
>>>
>>> instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);
>>>
>>> This code was detected with the help of Coccinelle.
>>>
>>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>>
>> Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
>>
>>
>>> ---
>>> net/sunrpc/xprtrdma/verbs.c | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
>>> index 4994e75945b8..9e8cf7456840 100644
>>> --- a/net/sunrpc/xprtrdma/verbs.c
>>> +++ b/net/sunrpc/xprtrdma/verbs.c
>>> @@ -811,8 +811,7 @@ static struct rpcrdma_sendctx *rpcrdma_sendctx_create(struct rpcrdma_ia *ia)
>>> {
>>> 	struct rpcrdma_sendctx *sc;
>>>
>>> -	sc = kzalloc(sizeof(*sc) +
>>> -		     ia->ri_max_send_sges * sizeof(struct ib_sge),
>>> +	sc = kzalloc(struct_size(sc, sc_sges, ia->ri_max_send_sges),
>>> 		     GFP_KERNEL);
>>> 	if (!sc)
>>> 		return NULL;
>>> -- 
>>> 2.20.1
>>>
>>
>> --
>> Chuck Lever
>>
>>
>>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH net-next] xprtrdma: Use struct_size() in kzalloc()
  2019-05-23 22:36     ` Gustavo A. R. Silva
@ 2019-05-23 23:02       ` Chuck Lever
  2019-05-23 23:32       ` David Miller
  1 sibling, 0 replies; 9+ messages in thread
From: Chuck Lever @ 2019-05-23 23:02 UTC (permalink / raw)
  To: Gustavo A. R. Silva, Anna Schumaker
  Cc: Trond Myklebust, Bruce Fields, Jeff Layton, David S. Miller,
	Linux NFS Mailing List, netdev, Linux Kernel Mailing List

Hi Gustavo-

Anna is supposed to take patches for xprtrdma/ .


> On May 23, 2019, at 6:36 PM, Gustavo A. R. Silva <gustavo@embeddedor.com> wrote:
> 
> Hi Dave,
> 
> I wonder if you can take this patch.
> 
> Thanks
> --
> Gustavo
> 
> On 3/28/19 3:41 PM, Gustavo A. R. Silva wrote:
>> Hi all,
>> 
>> Friendly ping:
>> 
>> Who can take this?
>> 
>> Thanks
>> --
>> Gustavo
>> 
>> On 1/31/19 8:11 AM, Chuck Lever wrote:
>>> 
>>> 
>>>> On Jan 30, 2019, at 7:46 PM, Gustavo A. R. Silva <gustavo@embeddedor.com> wrote:
>>>> 
>>>> One of the more common cases of allocation size calculations is finding
>>>> the size of a structure that has a zero-sized array at the end, along
>>>> with memory for some number of elements for that array. For example:
>>>> 
>>>> struct foo {
>>>>   int stuff;
>>>>   struct boo entry[];
>>>> };
>>>> 
>>>> instance = kzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);
>>>> 
>>>> Instead of leaving these open-coded and prone to type mistakes, we can
>>>> now use the new struct_size() helper:
>>>> 
>>>> instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);
>>>> 
>>>> This code was detected with the help of Coccinelle.
>>>> 
>>>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>>> 
>>> Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
>>> 
>>> 
>>>> ---
>>>> net/sunrpc/xprtrdma/verbs.c | 3 +--
>>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>> 
>>>> diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
>>>> index 4994e75945b8..9e8cf7456840 100644
>>>> --- a/net/sunrpc/xprtrdma/verbs.c
>>>> +++ b/net/sunrpc/xprtrdma/verbs.c
>>>> @@ -811,8 +811,7 @@ static struct rpcrdma_sendctx *rpcrdma_sendctx_create(struct rpcrdma_ia *ia)
>>>> {
>>>> 	struct rpcrdma_sendctx *sc;
>>>> 
>>>> -	sc = kzalloc(sizeof(*sc) +
>>>> -		     ia->ri_max_send_sges * sizeof(struct ib_sge),
>>>> +	sc = kzalloc(struct_size(sc, sc_sges, ia->ri_max_send_sges),
>>>> 		     GFP_KERNEL);
>>>> 	if (!sc)
>>>> 		return NULL;
>>>> -- 
>>>> 2.20.1
>>>> 
>>> 
>>> --
>>> Chuck Lever
>>> 
>>> 
>>> 

--
Chuck Lever




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH net-next] xprtrdma: Use struct_size() in kzalloc()
  2019-05-23 22:36     ` Gustavo A. R. Silva
  2019-05-23 23:02       ` Chuck Lever
@ 2019-05-23 23:32       ` David Miller
  2019-05-23 23:43         ` Gustavo A. R. Silva
  1 sibling, 1 reply; 9+ messages in thread
From: David Miller @ 2019-05-23 23:32 UTC (permalink / raw)
  To: gustavo
  Cc: chuck.lever, trond.myklebust, anna.schumaker, bfields, jlayton,
	linux-nfs, netdev, linux-kernel

From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Thu, 23 May 2019 17:36:00 -0500

> Hi Dave,
> 
> I wonder if you can take this patch.

The sunrpc/nfs maintainer should take this.  I never take patches in that
area.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH net-next] xprtrdma: Use struct_size() in kzalloc()
  2019-05-23 23:32       ` David Miller
@ 2019-05-23 23:43         ` Gustavo A. R. Silva
  2019-05-28 13:56           ` Schumaker, Anna
  0 siblings, 1 reply; 9+ messages in thread
From: Gustavo A. R. Silva @ 2019-05-23 23:43 UTC (permalink / raw)
  To: David Miller
  Cc: chuck.lever, trond.myklebust, anna.schumaker, bfields, jlayton,
	linux-nfs, netdev, linux-kernel



On 5/23/19 6:32 PM, David Miller wrote:
> From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
> Date: Thu, 23 May 2019 17:36:00 -0500
> 
>> Hi Dave,
>>
>> I wonder if you can take this patch.
> 
> The sunrpc/nfs maintainer should take this.  I never take patches in that
> area.
> 

Yep. Chuck just let me know that Anna is who take these patches.

Hopefully, she will take this one soon.

Thanks
--
Gustavo

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH net-next] xprtrdma: Use struct_size() in kzalloc()
  2019-05-23 23:43         ` Gustavo A. R. Silva
@ 2019-05-28 13:56           ` Schumaker, Anna
  0 siblings, 0 replies; 9+ messages in thread
From: Schumaker, Anna @ 2019-05-28 13:56 UTC (permalink / raw)
  To: davem, gustavo
  Cc: bfields, linux-nfs, jlayton, netdev, trond.myklebust,
	chuck.lever, linux-kernel


On Thu, 2019-05-23 at 18:43 -0500, Gustavo A. R. Silva wrote:
> 
> On 5/23/19 6:32 PM, David Miller wrote:
> > From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
> > Date: Thu, 23 May 2019 17:36:00 -0500
> > 
> > > Hi Dave,
> > > 
> > > I wonder if you can take this patch.
> > 
> > The sunrpc/nfs maintainer should take this.  I never take patches in that
> > area.
> > 
> 
> Yep. Chuck just let me know that Anna is who take these patches.
> 
> Hopefully, she will take this one soon.

I've applied this to push out later in the week. Thanks for pointing it out to
me!

Anna

> 
> Thanks
> --
> Gustavo

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, back to index

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-31  0:46 [PATCH net-next] xprtrdma: Use struct_size() in kzalloc() Gustavo A. R. Silva
2019-01-31 14:11 ` Chuck Lever
2019-02-08  3:49   ` Gustavo A. R. Silva
2019-03-28 20:41   ` Gustavo A. R. Silva
2019-05-23 22:36     ` Gustavo A. R. Silva
2019-05-23 23:02       ` Chuck Lever
2019-05-23 23:32       ` David Miller
2019-05-23 23:43         ` Gustavo A. R. Silva
2019-05-28 13:56           ` Schumaker, Anna

Linux-NFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nfs/0 linux-nfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nfs linux-nfs/ https://lore.kernel.org/linux-nfs \
		linux-nfs@vger.kernel.org linux-nfs@archiver.kernel.org
	public-inbox-index linux-nfs


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-nfs


AGPL code for this site: git clone https://public-inbox.org/ public-inbox