* [ndctl PATCH] ndctl: add util/filter.{c,h} to ndctl_SOURCES in Makefile.am
@ 2020-01-31 22:47 Vishal Verma
2020-01-31 23:33 ` Dan Williams
0 siblings, 1 reply; 2+ messages in thread
From: Vishal Verma @ 2020-01-31 22:47 UTC (permalink / raw)
To: linux-nvdimm; +Cc: Vishal Verma, Dan Williams
ndctl/Makefile.am neglected to explicitly add util/filter.{c,h} to
ndctl_SOURCES. In the past, this has been a cause for distro build
failures.
Cc: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
ndctl/Makefile.am | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ndctl/Makefile.am b/ndctl/Makefile.am
index 264c4ed..49c6c4a 100644
--- a/ndctl/Makefile.am
+++ b/ndctl/Makefile.am
@@ -18,7 +18,9 @@ ndctl_SOURCES = ndctl.c \
check.c \
region.c \
dimm.c \
- ../util/log.c \
+ ../util/log.c \
+ ../util/filter.c \
+ ../util/filter.h \
list.c \
../util/json.c \
../util/json.h \
--
2.21.1
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [ndctl PATCH] ndctl: add util/filter.{c,h} to ndctl_SOURCES in Makefile.am
2020-01-31 22:47 [ndctl PATCH] ndctl: add util/filter.{c,h} to ndctl_SOURCES in Makefile.am Vishal Verma
@ 2020-01-31 23:33 ` Dan Williams
0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2020-01-31 23:33 UTC (permalink / raw)
To: Vishal Verma; +Cc: linux-nvdimm
On Fri, Jan 31, 2020 at 2:48 PM Vishal Verma <vishal.l.verma@intel.com> wrote:
>
> ndctl/Makefile.am neglected to explicitly add util/filter.{c,h} to
> ndctl_SOURCES. In the past, this has been a cause for distro build
> failures.
>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> ---
> ndctl/Makefile.am | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/ndctl/Makefile.am b/ndctl/Makefile.am
> index 264c4ed..49c6c4a 100644
> --- a/ndctl/Makefile.am
> +++ b/ndctl/Makefile.am
> @@ -18,7 +18,9 @@ ndctl_SOURCES = ndctl.c \
> check.c \
> region.c \
> dimm.c \
> - ../util/log.c \
> + ../util/log.c \
> + ../util/filter.c \
> + ../util/filter.h \
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Not sure why 'make distcheck' did not hit this previously.
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-31 23:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-31 22:47 [ndctl PATCH] ndctl: add util/filter.{c,h} to ndctl_SOURCES in Makefile.am Vishal Verma
2020-01-31 23:33 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).