From: Akinobu Mita <akinobu.mita@gmail.com> To: linux-nvme@lists.infradead.org, linux-hwmon@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Amit Kucheria <amit.kucheria@verdurent.com>, Jean Delvare <jdelvare@suse.com>, Sagi Grimberg <sagi@grimberg.me>, Sujith Thomas <sujith.thomas@intel.com>, Daniel Lezcano <daniel.lezcano@linaro.org>, Akinobu Mita <akinobu.mita@gmail.com>, Jens Axboe <axboe@fb.com>, Guenter Roeck <linux@roeck-us.net>, Keith Busch <kbusch@kernel.org>, Darren Hart <dvhart@infradead.org>, Zhang Rui <rui.zhang@intel.com>, Christoph Hellwig <hch@lst.de>, Andy Shevchenko <andy@infradead.org> Subject: [PATCH v2 3/8] platform/x86: asus-wmi: switch to use <linux/temperature.h> helpers Date: Thu, 28 Nov 2019 23:54:34 +0900 [thread overview] Message-ID: <1574952879-7200-4-git-send-email-akinobu.mita@gmail.com> (raw) In-Reply-To: <1574952879-7200-1-git-send-email-akinobu.mita@gmail.com> The asus-wmi driver doesn't implement the thermal device functionality directly, so including <linux/thermal.h> just for DECI_KELVIN_TO_CELSIUS() is a bit odd. This switches the asus-wmi driver to use deci_kelvin_to_millicelsius() in <linux/temperature.h>. Cc: Sujith Thomas <sujith.thomas@intel.com> Cc: Darren Hart <dvhart@infradead.org> Cc: Andy Shevchenko <andy@infradead.org> Cc: Zhang Rui <rui.zhang@intel.com> Cc: Daniel Lezcano <daniel.lezcano@linaro.org> Cc: Amit Kucheria <amit.kucheria@verdurent.com> Cc: Jean Delvare <jdelvare@suse.com> Cc: Guenter Roeck <linux@roeck-us.net> Cc: Keith Busch <kbusch@kernel.org> Cc: Jens Axboe <axboe@fb.com> Cc: Christoph Hellwig <hch@lst.de> Cc: Sagi Grimberg <sagi@grimberg.me> Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> --- * v2 - add Acked-by tag drivers/platform/x86/asus-wmi.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c index 821b08e..6a1a2f9 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -33,7 +33,7 @@ #include <linux/seq_file.h> #include <linux/platform_data/x86/asus-wmi.h> #include <linux/platform_device.h> -#include <linux/thermal.h> +#include <linux/temperature.h> #include <linux/acpi.h> #include <linux/dmi.h> @@ -1512,9 +1512,8 @@ static ssize_t asus_hwmon_temp1(struct device *dev, if (err < 0) return err; - value = DECI_KELVIN_TO_CELSIUS((value & 0xFFFF)) * 1000; - - return sprintf(buf, "%d\n", value); + return sprintf(buf, "%ld\n", + deci_kelvin_to_millicelsius(value & 0xFFFF)); } /* Fan1 */ -- 2.7.4 _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-11-28 14:55 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-28 14:54 [PATCH v2 0/8] add header file for kelvin to/from Celsius conversion helpers Akinobu Mita 2019-11-28 14:54 ` [PATCH v2 1/8] " Akinobu Mita 2019-12-06 16:49 ` Daniel Lezcano 2019-12-07 15:57 ` Akinobu Mita 2019-11-28 14:54 ` [PATCH v2 2/8] ACPI: thermal: switch to use <linux/temperature.h> helpers Akinobu Mita 2019-11-28 14:54 ` Akinobu Mita [this message] 2019-11-28 14:54 ` [PATCH v2 4/8] platform/x86: intel_menlow: " Akinobu Mita 2019-11-28 15:02 ` Andy Shevchenko 2019-11-28 14:54 ` [PATCH v2 5/8] thermal: int340x: " Akinobu Mita 2019-11-28 14:54 ` [PATCH v2 6/8] thermal: intel_pch: " Akinobu Mita 2019-11-28 14:54 ` [PATCH v2 7/8] nvme: hwmon: " Akinobu Mita 2019-11-28 15:14 ` Guenter Roeck 2019-12-11 18:33 ` Keith Busch 2019-11-28 14:54 ` [PATCH v2 8/8] thermal: remove kelvin to/from Celsius conversion helpers from <linux/thermal.h> Akinobu Mita
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1574952879-7200-4-git-send-email-akinobu.mita@gmail.com \ --to=akinobu.mita@gmail.com \ --cc=amit.kucheria@verdurent.com \ --cc=andy@infradead.org \ --cc=axboe@fb.com \ --cc=daniel.lezcano@linaro.org \ --cc=dvhart@infradead.org \ --cc=hch@lst.de \ --cc=jdelvare@suse.com \ --cc=kbusch@kernel.org \ --cc=linux-hwmon@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=rui.zhang@intel.com \ --cc=sagi@grimberg.me \ --cc=sujith.thomas@intel.com \ --subject='Re: [PATCH v2 3/8] platform/x86: asus-wmi: switch to use <linux/temperature.h> helpers' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).