[PATCH] nvme-core: get rid of the unused variable

[PATCH] nvme-core: get rid of the unused variable

[Chaitanya Kulkarni]

This patch fixes the following compilation warning:-

drivers/nvme//host/core.c: In function ‘nvme_complete_rq’:
drivers/nvme//host/core.c:264:18: warning: unused variable ‘ns’
[-Wunused-variable]
  struct nvme_ns *ns = req->q->queuedata;

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
 drivers/nvme/host/core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 0b1ff8d54e48..ddf99345e3d8 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -261,7 +261,6 @@ static void nvme_retry_req(struct request *req)
 void nvme_complete_rq(struct request *req)
 {
 	blk_status_t status = nvme_error_status(req);
-	struct nvme_ns *ns = req->q->queuedata;
 
 	trace_nvme_complete_rq(req);
 
-- 
2.17.0


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

Re: [PATCH] nvme-core: get rid of the unused variable

[Max Gurtovoy]

On 8/31/2019 3:10 AM, Chaitanya Kulkarni wrote:
> This patch fixes the following compilation warning:-
>
> drivers/nvme//host/core.c: In function ‘nvme_complete_rq’:
> drivers/nvme//host/core.c:264:18: warning: unused variable ‘ns’
> [-Wunused-variable]
>    struct nvme_ns *ns = req->q->queuedata;
>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
>   drivers/nvme/host/core.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 0b1ff8d54e48..ddf99345e3d8 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -261,7 +261,6 @@ static void nvme_retry_req(struct request *req)
>   void nvme_complete_rq(struct request *req)
>   {
>   	blk_status_t status = nvme_error_status(req);
> -	struct nvme_ns *ns = req->q->queuedata;


I can't find this code anywhere, but anyway this must go out.

Reviewed-by: Max Gurtovoy <maxg@mellanox.com>


>   
>   	trace_nvme_complete_rq(req);
>   

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

Re: [PATCH] nvme-core: get rid of the unused variable

[Christoph Hellwig]

On Fri, Aug 30, 2019 at 05:10:13PM -0700, Chaitanya Kulkarni wrote:
>  void nvme_complete_rq(struct request *req)
>  {
>  	blk_status_t status = nvme_error_status(req);
> -	struct nvme_ns *ns = req->q->queuedata;
>  
>  	trace_nvme_complete_rq(req);

I don't actually see this variable in Linus' tree or the nvme-5.4
branch, what tree is this against?

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

Re: [PATCH] nvme-core: get rid of the unused variable

[Chaitanya Kulkarni]

Please ignore this, I've messed up the pull-merge, sorry for the noise.

On 9/2/19 12:14 PM, Christoph Hellwig wrote:
> On Fri, Aug 30, 2019 at 05:10:13PM -0700, Chaitanya Kulkarni wrote:
>>   void nvme_complete_rq(struct request *req)
>>   {
>>   	blk_status_t status = nvme_error_status(req);
>> -	struct nvme_ns *ns = req->q->queuedata;
>>   
>>   	trace_nvme_complete_rq(req);
> I don't actually see this variable in Linus' tree or the nvme-5.4
> branch, what tree is this against?
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme