linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Balbir Singh <sblbir@amazon.com>
To: <linux-kernel@vger.kernel.org>, <linux-block@vger.kernel.org>,
	<linux-nvme@lists.infradead.org>
Cc: axboe@kernel.dk, Chaitanya.Kulkarni@wdc.com, mst@redhat.com,
	jejb@linux.ibm.com, ssomesh@amazon.com,
	Balbir Singh <sblbir@amazon.com>,
	hch@lst.de
Subject: [resend v1 1/5] block/genhd: Notify udev about capacity change
Date: Thu, 2 Jan 2020 07:53:11 +0000	[thread overview]
Message-ID: <20200102075315.22652-2-sblbir@amazon.com> (raw)
In-Reply-To: <20200102075315.22652-1-sblbir@amazon.com>

Allow block/genhd to notify user space (via udev) about disk size changes
using a new helper disk_set_capacity(), which is a wrapper on top
of set_capacity(). disk_set_capacity() will only notify via udev if
the current capacity or the target capacity is not zero.

Suggested-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Someswarudu Sangaraju <ssomesh@amazon.com>
Signed-off-by: Balbir Singh <sblbir@amazon.com>
---
 block/genhd.c         | 19 +++++++++++++++++++
 include/linux/genhd.h |  1 +
 2 files changed, 20 insertions(+)

diff --git a/block/genhd.c b/block/genhd.c
index ff6268970ddc..94faec98607b 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -46,6 +46,25 @@ static void disk_add_events(struct gendisk *disk);
 static void disk_del_events(struct gendisk *disk);
 static void disk_release_events(struct gendisk *disk);
 
+/*
+ * Set disk capacity and notify if the size is not currently
+ * zero and will not be set to zero
+ */
+void disk_set_capacity(struct gendisk *disk, sector_t size)
+{
+	sector_t capacity = get_capacity(disk);
+
+	set_capacity(disk, size);
+	if (capacity != 0 && size != 0) {
+		char *envp[] = { "RESIZE=1", NULL };
+
+		kobject_uevent_env(&disk_to_dev(disk)->kobj, KOBJ_CHANGE, envp);
+	}
+}
+
+EXPORT_SYMBOL_GPL(disk_set_capacity);
+
+
 void part_inc_in_flight(struct request_queue *q, struct hd_struct *part, int rw)
 {
 	if (queue_is_mq(q))
diff --git a/include/linux/genhd.h b/include/linux/genhd.h
index a927829bb73a..f1a5ddcc781d 100644
--- a/include/linux/genhd.h
+++ b/include/linux/genhd.h
@@ -449,6 +449,7 @@ static inline int get_disk_ro(struct gendisk *disk)
 extern void disk_block_events(struct gendisk *disk);
 extern void disk_unblock_events(struct gendisk *disk);
 extern void disk_flush_events(struct gendisk *disk, unsigned int mask);
+extern void disk_set_capacity(struct gendisk *disk, sector_t size);
 extern unsigned int disk_clear_events(struct gendisk *disk, unsigned int mask);
 
 /* drivers/char/random.c */
-- 
2.16.5


_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2020-01-02  7:53 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-02  7:53 [resend v1 0/5] Add support for block disk resize notification Balbir Singh
2020-01-02  7:53 ` Balbir Singh [this message]
2020-01-03  6:16   ` [resend v1 1/5] block/genhd: Notify udev about capacity change Chaitanya Kulkarni
2020-01-04  4:44     ` Singh, Balbir
2020-01-04 22:32       ` Chaitanya Kulkarni
2020-01-08 15:02     ` hch
2020-01-07  3:32   ` Martin K. Petersen
2020-01-07 22:30     ` Singh, Balbir
2020-01-08  3:15       ` Martin K. Petersen
2020-01-08 15:04         ` hch
2020-01-21 19:57           ` Singh, Balbir
2020-01-02  7:53 ` [resend v1 2/5] drivers/block/virtio_blk.c: Convert to use disk_set_capacity Balbir Singh
2020-01-02  7:53 ` [resend v1 3/5] drivers/block/xen-blkfront.c: " Balbir Singh
2020-01-02  7:53 ` [resend v1 4/5] drivers/nvme/host/core.c: " Balbir Singh
2020-01-04 22:27   ` Chaitanya Kulkarni
2020-01-06  0:46     ` Singh, Balbir
2020-01-08 15:04       ` hch
2020-01-09  3:33         ` Martin K. Petersen
2020-01-09 13:12           ` Ewan D. Milne
2020-01-21 19:52         ` Singh, Balbir
2020-01-02  7:53 ` [resend v1 5/5] drivers/scsi/sd.c: " Balbir Singh
2020-01-02 22:21   ` Chaitanya Kulkarni
2020-01-03  0:23     ` Singh, Balbir
2020-01-07  3:48   ` Martin K. Petersen
2020-01-07  3:57     ` James Bottomley
2020-01-07  4:39       ` Martin K. Petersen
2020-01-07 21:37         ` Ewan D. Milne
2020-01-08  2:59           ` Martin K. Petersen
2020-01-08 21:27             ` Ewan D. Milne
2020-01-07 22:28     ` Singh, Balbir
2020-01-08  3:15       ` Martin K. Petersen
2020-01-08  4:20         ` Singh, Balbir
2020-01-08 21:32         ` Ewan D. Milne
2020-01-08 15:06     ` Christoph Hellwig
2020-01-09  2:53       ` Martin K. Petersen
2020-01-06  5:59 ` [resend v1 0/5] Add support for block disk resize notification Bob Liu
2020-01-06  8:47   ` Singh, Balbir
2020-01-06  9:08     ` Bob Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200102075315.22652-2-sblbir@amazon.com \
    --to=sblbir@amazon.com \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=jejb@linux.ibm.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mst@redhat.com \
    --cc=ssomesh@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).