From: Jean Delvare <jdelvare@suse.de>
To: linux-nvme@lists.infradead.org
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH] nvme: Don't deter users from enabling hwmon support
Date: Tue, 11 Feb 2020 13:41:36 +0100 [thread overview]
Message-ID: <20200211134136.099ac9eb@endymion> (raw)
I see no good reason for the "If unsure, say N" advice in the
description of the NVME_HWMON configuration option. It is not
dangerous, it does not select any other option, and has a fairly low
overhead.
As the option is already not enabled by default, further suggesting
hesitant users to not enable it is not useful anyway. Unlike some
other options where the description alone may not be sufficient for
users to make a decision, NVME_HWMON is pretty simple to grasp in my
opinion, so just let the user do what they want.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Keith Busch <kbusch@kernel.org>
---
drivers/nvme/host/Kconfig | 2 --
1 file changed, 2 deletions(-)
--- linux-5.5.orig/drivers/nvme/host/Kconfig 2020-01-27 01:23:03.000000000 +0100
+++ linux-5.5/drivers/nvme/host/Kconfig 2020-02-11 13:31:31.595715936 +0100
@@ -31,8 +31,6 @@ config NVME_HWMON
a hardware monitoring device will be created for each NVMe drive
in the system.
- If unsure, say N.
-
config NVME_FABRICS
tristate
--
Jean Delvare
SUSE L3 Support
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next reply other threads:[~2020-02-11 12:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 12:41 Jean Delvare [this message]
2020-02-11 13:30 ` [PATCH] nvme: Don't deter users from enabling hwmon support Guenter Roeck
2020-02-11 16:55 ` Chaitanya Kulkarni
2020-02-11 20:43 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200211134136.099ac9eb@endymion \
--to=jdelvare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).