* [PATCH] nvme: Don't deter users from enabling hwmon support
@ 2020-02-11 12:41 Jean Delvare
2020-02-11 13:30 ` Guenter Roeck
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jean Delvare @ 2020-02-11 12:41 UTC (permalink / raw)
To: linux-nvme; +Cc: Keith Busch, Christoph Hellwig, Guenter Roeck
I see no good reason for the "If unsure, say N" advice in the
description of the NVME_HWMON configuration option. It is not
dangerous, it does not select any other option, and has a fairly low
overhead.
As the option is already not enabled by default, further suggesting
hesitant users to not enable it is not useful anyway. Unlike some
other options where the description alone may not be sufficient for
users to make a decision, NVME_HWMON is pretty simple to grasp in my
opinion, so just let the user do what they want.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Keith Busch <kbusch@kernel.org>
---
drivers/nvme/host/Kconfig | 2 --
1 file changed, 2 deletions(-)
--- linux-5.5.orig/drivers/nvme/host/Kconfig 2020-01-27 01:23:03.000000000 +0100
+++ linux-5.5/drivers/nvme/host/Kconfig 2020-02-11 13:31:31.595715936 +0100
@@ -31,8 +31,6 @@ config NVME_HWMON
a hardware monitoring device will be created for each NVMe drive
in the system.
- If unsure, say N.
-
config NVME_FABRICS
tristate
--
Jean Delvare
SUSE L3 Support
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme: Don't deter users from enabling hwmon support
2020-02-11 12:41 [PATCH] nvme: Don't deter users from enabling hwmon support Jean Delvare
@ 2020-02-11 13:30 ` Guenter Roeck
2020-02-11 16:55 ` Chaitanya Kulkarni
2020-02-11 20:43 ` Keith Busch
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2020-02-11 13:30 UTC (permalink / raw)
To: Jean Delvare, linux-nvme; +Cc: Keith Busch, Christoph Hellwig
On 2/11/20 4:41 AM, Jean Delvare wrote:
> I see no good reason for the "If unsure, say N" advice in the
> description of the NVME_HWMON configuration option. It is not
> dangerous, it does not select any other option, and has a fairly low
> overhead.
>
> As the option is already not enabled by default, further suggesting
> hesitant users to not enable it is not useful anyway. Unlike some
> other options where the description alone may not be sufficient for
> users to make a decision, NVME_HWMON is pretty simple to grasp in my
> opinion, so just let the user do what they want.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Keith Busch <kbusch@kernel.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/nvme/host/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> --- linux-5.5.orig/drivers/nvme/host/Kconfig 2020-01-27 01:23:03.000000000 +0100
> +++ linux-5.5/drivers/nvme/host/Kconfig 2020-02-11 13:31:31.595715936 +0100
> @@ -31,8 +31,6 @@ config NVME_HWMON
> a hardware monitoring device will be created for each NVMe drive
> in the system.
>
> - If unsure, say N.
> -
> config NVME_FABRICS
> tristate
>
>
>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme: Don't deter users from enabling hwmon support
2020-02-11 12:41 [PATCH] nvme: Don't deter users from enabling hwmon support Jean Delvare
2020-02-11 13:30 ` Guenter Roeck
@ 2020-02-11 16:55 ` Chaitanya Kulkarni
2020-02-11 20:43 ` Keith Busch
2 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2020-02-11 16:55 UTC (permalink / raw)
To: Jean Delvare, linux-nvme; +Cc: Keith Busch, Christoph Hellwig, Guenter Roeck
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
On 02/11/2020 04:41 AM, Jean Delvare wrote:
> I see no good reason for the "If unsure, say N" advice in the
> description of the NVME_HWMON configuration option. It is not
> dangerous, it does not select any other option, and has a fairly low
> overhead.
>
> As the option is already not enabled by default, further suggesting
> hesitant users to not enable it is not useful anyway. Unlike some
> other options where the description alone may not be sufficient for
> users to make a decision, NVME_HWMON is pretty simple to grasp in my
> opinion, so just let the user do what they want.
>
> Signed-off-by: Jean Delvare<jdelvare@suse.de>
> Cc: Christoph Hellwig<hch@lst.de>
> Cc: Guenter Roeck<linux@roeck-us.net>
> Cc: Keith Busch<kbusch@kernel.org>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme: Don't deter users from enabling hwmon support
2020-02-11 12:41 [PATCH] nvme: Don't deter users from enabling hwmon support Jean Delvare
2020-02-11 13:30 ` Guenter Roeck
2020-02-11 16:55 ` Chaitanya Kulkarni
@ 2020-02-11 20:43 ` Keith Busch
2 siblings, 0 replies; 4+ messages in thread
From: Keith Busch @ 2020-02-11 20:43 UTC (permalink / raw)
To: Jean Delvare; +Cc: Guenter Roeck, Christoph Hellwig, linux-nvme
On Tue, Feb 11, 2020 at 01:41:36PM +0100, Jean Delvare wrote:
> I see no good reason for the "If unsure, say N" advice in the
> description of the NVME_HWMON configuration option. It is not
> dangerous, it does not select any other option, and has a fairly low
> overhead.
The initial commit probably used one of the other Kconfig options that
contained the same wording as a template. But okay, the overly cautious
description here looks fine to remove.
> As the option is already not enabled by default, further suggesting
> hesitant users to not enable it is not useful anyway. Unlike some
> other options where the description alone may not be sufficient for
> users to make a decision, NVME_HWMON is pretty simple to grasp in my
> opinion, so just let the user do what they want.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
Added to nvme-5.7 with the reviewer's tags. Thanks!
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-11 20:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-11 12:41 [PATCH] nvme: Don't deter users from enabling hwmon support Jean Delvare
2020-02-11 13:30 ` Guenter Roeck
2020-02-11 16:55 ` Chaitanya Kulkarni
2020-02-11 20:43 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).