From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, Martin.Belanger@dell.com
Subject: Re: [PATCH 2/2] nvme: don't set iosqes,iocqes for discovery controllers
Date: Thu, 11 Feb 2021 19:31:24 +0100 [thread overview]
Message-ID: <20210211183124.GA26045@lst.de> (raw)
In-Reply-To: <f279bd6a-d4e3-52b6-740b-66f90434cf69@grimberg.me>
On Thu, Feb 11, 2021 at 02:43:27AM -0800, Sagi Grimberg wrote:
> The annoying thing here is that this issue will manifest in the host
> waiting on nvme_wait_ready for a long 7.5 seconds to understand that
> its maybe incompatible and re-attempt (nvme_enable_ctrl writes to cap
> and then polls CSTS)...
>
> What I have now looks like:
In terms of what to do about the retry this is what we'll have to
do. That being said I think for existing controllers we should just
stick to the existing wrong value, and only set the correct one
for versions > 1.3. This isn't exactly correct, but probably causes
the least harm. It will need an extensive comment, and maybe we need
to add an option to override it if controllers show up that do not
like the wrong value.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-02-11 18:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 10:12 [PATCH 1/2] nvmet: don't check iosqes, iocqes for discovery controllers Sagi Grimberg
2021-02-09 10:12 ` [PATCH 2/2] nvme: don't set iosqes,iocqes " Sagi Grimberg
2021-02-10 10:11 ` Christoph Hellwig
2021-02-10 22:37 ` Sagi Grimberg
2021-02-11 7:02 ` Christoph Hellwig
2021-02-11 10:43 ` Sagi Grimberg
2021-02-11 18:31 ` Christoph Hellwig [this message]
2021-02-11 19:44 ` Sagi Grimberg
2021-02-24 9:08 ` Christoph Hellwig
2021-02-10 10:10 ` [PATCH 1/2] nvmet: don't check " Christoph Hellwig
2021-02-10 22:34 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210211183124.GA26045@lst.de \
--to=hch@lst.de \
--cc=Martin.Belanger@dell.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).