From: Sagi Grimberg <sagi@grimberg.me>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>,
Martin.Belanger@dell.com, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 2/2] nvme: don't set iosqes,iocqes for discovery controllers
Date: Thu, 11 Feb 2021 11:44:44 -0800 [thread overview]
Message-ID: <a5ea738a-44c4-e953-3271-a0b97668000e@grimberg.me> (raw)
In-Reply-To: <20210211183124.GA26045@lst.de>
>> The annoying thing here is that this issue will manifest in the host
>> waiting on nvme_wait_ready for a long 7.5 seconds to understand that
>> its maybe incompatible and re-attempt (nvme_enable_ctrl writes to cap
>> and then polls CSTS)...
>>
>> What I have now looks like:
>
> In terms of what to do about the retry this is what we'll have to
> do. That being said I think for existing controllers we should just
> stick to the existing wrong value, and only set the correct one
> for versions > 1.3. This isn't exactly correct, but probably causes
> the least harm. It will need an extensive comment, and maybe we need
> to add an option to override it if controllers show up that do not
> like the wrong value.
So you suggest that we keep the retry w.a. but continue to send the
wrong value in 1.3 or lower?
I personally think that this would be extremely confusing to users, if
they do trip on this, but I agree that they are less likely to hit
it because existing controllers obviously accept wrong values...
As for option to override. I really hate it.. What is the least exposure
we can get for this but still allow the user to control this?
Wish we had a good and reliable quirk mechanism for fabrics...
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-02-11 19:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 10:12 [PATCH 1/2] nvmet: don't check iosqes, iocqes for discovery controllers Sagi Grimberg
2021-02-09 10:12 ` [PATCH 2/2] nvme: don't set iosqes,iocqes " Sagi Grimberg
2021-02-10 10:11 ` Christoph Hellwig
2021-02-10 22:37 ` Sagi Grimberg
2021-02-11 7:02 ` Christoph Hellwig
2021-02-11 10:43 ` Sagi Grimberg
2021-02-11 18:31 ` Christoph Hellwig
2021-02-11 19:44 ` Sagi Grimberg [this message]
2021-02-24 9:08 ` Christoph Hellwig
2021-02-10 10:10 ` [PATCH 1/2] nvmet: don't check " Christoph Hellwig
2021-02-10 22:34 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5ea738a-44c4-e953-3271-a0b97668000e@grimberg.me \
--to=sagi@grimberg.me \
--cc=Martin.Belanger@dell.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).