From: Sagi Grimberg <sagi@grimberg.me>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>,
Martin.Belanger@dell.com, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/2] nvmet: don't check iosqes,iocqes for discovery controllers
Date: Wed, 10 Feb 2021 14:34:54 -0800 [thread overview]
Message-ID: <bf05392c-8c92-d6c2-d9f9-a22ac23bc338@grimberg.me> (raw)
In-Reply-To: <20210210101037.GA26576@lst.de>
>> + if (!ctrl->subsys->type == NVME_NQN_DISC &&
>
> I think the normal way to write this would be a !=.
:)
>> + (nvmet_cc_iosqes(ctrl->cc) != NVME_NVM_IOSQES ||
>> + nvmet_cc_iocqes(ctrl->cc) != NVME_NVM_IOCQES)) {
>
> By the spec we'd need to check these are 0, but of course we'd break
> the existing Linux host. Maybe throw in a comment?
Sure, I'll add it.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2021-02-10 22:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 10:12 [PATCH 1/2] nvmet: don't check iosqes, iocqes for discovery controllers Sagi Grimberg
2021-02-09 10:12 ` [PATCH 2/2] nvme: don't set iosqes,iocqes " Sagi Grimberg
2021-02-10 10:11 ` Christoph Hellwig
2021-02-10 22:37 ` Sagi Grimberg
2021-02-11 7:02 ` Christoph Hellwig
2021-02-11 10:43 ` Sagi Grimberg
2021-02-11 18:31 ` Christoph Hellwig
2021-02-11 19:44 ` Sagi Grimberg
2021-02-24 9:08 ` Christoph Hellwig
2021-02-10 10:10 ` [PATCH 1/2] nvmet: don't check " Christoph Hellwig
2021-02-10 22:34 ` Sagi Grimberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf05392c-8c92-d6c2-d9f9-a22ac23bc338@grimberg.me \
--to=sagi@grimberg.me \
--cc=Martin.Belanger@dell.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).