* [PATCH] nvme-pci: mark Seagate Nytro XM1440 as QUIRK_NO_NS_DESC_LIST.
@ 2021-02-16 12:25 jeinwag-nvme
2021-02-16 17:54 ` Keith Busch
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: jeinwag-nvme @ 2021-02-16 12:25 UTC (permalink / raw)
To: linux-nvme; +Cc: Julian Einwag
From: Julian Einwag <jeinwag-nvme@marcapo.com>
The kernel fails to fully detect these SSDs, only the character devices are present:
[ 10.785605] nvme nvme0: pci function 0000:04:00.0
[ 10.876787] nvme nvme1: pci function 0000:81:00.0
[ 13.198614] nvme nvme0: missing or invalid SUBNQN field.
[ 13.198658] nvme nvme1: missing or invalid SUBNQN field.
[ 13.206896] nvme nvme0: Shutdown timeout set to 20 seconds
[ 13.215035] nvme nvme1: Shutdown timeout set to 20 seconds
[ 13.225407] nvme nvme0: 16/0/0 default/read/poll queues
[ 13.233602] nvme nvme1: 16/0/0 default/read/poll queues
[ 13.239627] nvme nvme0: Identify Descriptors failed (8194)
[ 13.246315] nvme nvme1: Identify Descriptors failed (8194)
Adding the NVME_QUIRK_NO_NS_DESC_LIST fixes this problem.
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205679
---
drivers/nvme/host/pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 0045c5edf629..91cefa40543f 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3233,7 +3233,8 @@ static const struct pci_device_id nvme_id_table[] = {
{ PCI_DEVICE(0x126f, 0x2263), /* Silicon Motion unidentified */
.driver_data = NVME_QUIRK_NO_NS_DESC_LIST, },
{ PCI_DEVICE(0x1bb1, 0x0100), /* Seagate Nytro Flash Storage */
- .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
+ .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY |
+ NVME_QUIRK_NO_NS_DESC_LIST, },
{ PCI_DEVICE(0x1c58, 0x0003), /* HGST adapter */
.driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
{ PCI_DEVICE(0x1c58, 0x0023), /* WDC SN200 adapter */
--
2.30.0
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] nvme-pci: mark Seagate Nytro XM1440 as QUIRK_NO_NS_DESC_LIST.
2021-02-16 12:25 [PATCH] nvme-pci: mark Seagate Nytro XM1440 as QUIRK_NO_NS_DESC_LIST jeinwag-nvme
@ 2021-02-16 17:54 ` Keith Busch
2021-02-24 9:12 ` Christoph Hellwig
2021-03-05 7:44 ` Christoph Hellwig
2 siblings, 0 replies; 6+ messages in thread
From: Keith Busch @ 2021-02-16 17:54 UTC (permalink / raw)
To: jeinwag-nvme; +Cc: linux-nvme
On Tue, Feb 16, 2021 at 01:25:43PM +0100, jeinwag-nvme@marcapo.com wrote:
> From: Julian Einwag <jeinwag-nvme@marcapo.com>
>
> The kernel fails to fully detect these SSDs, only the character devices are present:
>
> [ 10.785605] nvme nvme0: pci function 0000:04:00.0
> [ 10.876787] nvme nvme1: pci function 0000:81:00.0
> [ 13.198614] nvme nvme0: missing or invalid SUBNQN field.
> [ 13.198658] nvme nvme1: missing or invalid SUBNQN field.
> [ 13.206896] nvme nvme0: Shutdown timeout set to 20 seconds
> [ 13.215035] nvme nvme1: Shutdown timeout set to 20 seconds
> [ 13.225407] nvme nvme0: 16/0/0 default/read/poll queues
> [ 13.233602] nvme nvme1: 16/0/0 default/read/poll queues
> [ 13.239627] nvme nvme0: Identify Descriptors failed (8194)
> [ 13.246315] nvme nvme1: Identify Descriptors failed (8194)
>
> Adding the NVME_QUIRK_NO_NS_DESC_LIST fixes this problem.
>
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205679
The code looks fine, but you need to add your Signed-off-by: tag in the
commit message.
Also, the first line in your commit log is too long and should be
wrapped to 72 characters.
> ---
> drivers/nvme/host/pci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 0045c5edf629..91cefa40543f 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3233,7 +3233,8 @@ static const struct pci_device_id nvme_id_table[] = {
> { PCI_DEVICE(0x126f, 0x2263), /* Silicon Motion unidentified */
> .driver_data = NVME_QUIRK_NO_NS_DESC_LIST, },
> { PCI_DEVICE(0x1bb1, 0x0100), /* Seagate Nytro Flash Storage */
> - .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
> + .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY |
> + NVME_QUIRK_NO_NS_DESC_LIST, },
> { PCI_DEVICE(0x1c58, 0x0003), /* HGST adapter */
> .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
> { PCI_DEVICE(0x1c58, 0x0023), /* WDC SN200 adapter */
> --
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nvme-pci: mark Seagate Nytro XM1440 as QUIRK_NO_NS_DESC_LIST.
2021-02-16 12:25 [PATCH] nvme-pci: mark Seagate Nytro XM1440 as QUIRK_NO_NS_DESC_LIST jeinwag-nvme
2021-02-16 17:54 ` Keith Busch
@ 2021-02-24 9:12 ` Christoph Hellwig
2021-03-05 7:44 ` Christoph Hellwig
2 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2021-02-24 9:12 UTC (permalink / raw)
To: jeinwag-nvme; +Cc: linux-nvme
Thanks,
applied to nvme-5.12 with the slight commit message tweak.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nvme-pci: mark Seagate Nytro XM1440 as QUIRK_NO_NS_DESC_LIST.
2021-02-16 12:25 [PATCH] nvme-pci: mark Seagate Nytro XM1440 as QUIRK_NO_NS_DESC_LIST jeinwag-nvme
2021-02-16 17:54 ` Keith Busch
2021-02-24 9:12 ` Christoph Hellwig
@ 2021-03-05 7:44 ` Christoph Hellwig
2021-03-05 8:42 ` AW: " Julian Einwag
2 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2021-03-05 7:44 UTC (permalink / raw)
To: jeinwag-nvme; +Cc: linux-nvme
Julian,
we'll need your signoff to include this patch, can you send it?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 6+ messages in thread
* AW: [PATCH] nvme-pci: mark Seagate Nytro XM1440 as QUIRK_NO_NS_DESC_LIST.
2021-03-05 7:44 ` Christoph Hellwig
@ 2021-03-05 8:42 ` Julian Einwag
0 siblings, 0 replies; 6+ messages in thread
From: Julian Einwag @ 2021-03-05 8:42 UTC (permalink / raw)
To: 'Christoph Hellwig'; +Cc: 'linux-nvme@lists.infradead.org'
Christoph,
I'm sorry - I already sent a re-formatted patch with the added sign-off, but it looks like the message didn't go through. So here it is, again:
---
The kernel fails to fully detect these SSDs, only the character devices
are present:
[ 10.785605] nvme nvme0: pci function 0000:04:00.0
[ 10.876787] nvme nvme1: pci function 0000:81:00.0
[ 13.198614] nvme nvme0: missing or invalid SUBNQN field.
[ 13.198658] nvme nvme1: missing or invalid SUBNQN field.
[ 13.206896] nvme nvme0: Shutdown timeout set to 20 seconds
[ 13.215035] nvme nvme1: Shutdown timeout set to 20 seconds
[ 13.225407] nvme nvme0: 16/0/0 default/read/poll queues
[ 13.233602] nvme nvme1: 16/0/0 default/read/poll queues
[ 13.239627] nvme nvme0: Identify Descriptors failed (8194)
[ 13.246315] nvme nvme1: Identify Descriptors failed (8194)
Adding the NVME_QUIRK_NO_NS_DESC_LIST fixes this problem.
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205679
Signed-off-by: Julian Einwag <jeinwag-nvme@marcapo.com>
---
drivers/nvme/host/pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 0045c5edf629..91cefa40543f 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3233,7 +3233,8 @@ static const struct pci_device_id nvme_id_table[] = {
{ PCI_DEVICE(0x126f, 0x2263), /* Silicon Motion unidentified */
.driver_data = NVME_QUIRK_NO_NS_DESC_LIST, },
{ PCI_DEVICE(0x1bb1, 0x0100), /* Seagate Nytro Flash Storage */
- .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
+ .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY |
+ NVME_QUIRK_NO_NS_DESC_LIST, },
{ PCI_DEVICE(0x1c58, 0x0003), /* HGST adapter */
.driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
{ PCI_DEVICE(0x1c58, 0x0023), /* WDC SN200 adapter */
--
2.30.0
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] nvme-pci: mark Seagate Nytro XM1440 as QUIRK_NO_NS_DESC_LIST.
[not found] <38eae52a15c5474dbdf85defcf6a29fa@marcapo.com>
@ 2021-02-17 20:23 ` Keith Busch
0 siblings, 0 replies; 6+ messages in thread
From: Keith Busch @ 2021-02-17 20:23 UTC (permalink / raw)
To: Julian Einwag; +Cc: 'linux-nvme@lists.infradead.org'
On Wed, Feb 17, 2021 at 07:33:32AM +0000, Julian Einwag wrote:
> The kernel fails to fully detect these SSDs, only the character devices
> are present:
>
> [ 10.785605] nvme nvme0: pci function 0000:04:00.0
> [ 10.876787] nvme nvme1: pci function 0000:81:00.0
> [ 13.198614] nvme nvme0: missing or invalid SUBNQN field.
> [ 13.198658] nvme nvme1: missing or invalid SUBNQN field.
> [ 13.206896] nvme nvme0: Shutdown timeout set to 20 seconds
> [ 13.215035] nvme nvme1: Shutdown timeout set to 20 seconds
> [ 13.225407] nvme nvme0: 16/0/0 default/read/poll queues
> [ 13.233602] nvme nvme1: 16/0/0 default/read/poll queues
> [ 13.239627] nvme nvme0: Identify Descriptors failed (8194)
> [ 13.246315] nvme nvme1: Identify Descriptors failed (8194)
>
> Adding the NVME_QUIRK_NO_NS_DESC_LIST fixes this problem.
>
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205679
>
> Signed-off-by: Julian Einwag <jeinwag-nvme@marcapo.com>
Looks fine.
Reviewed-by: Keith Busch <kbusch@kernel.org>
> ---
> drivers/nvme/host/pci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 0045c5edf629..91cefa40543f 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3233,7 +3233,8 @@ static const struct pci_device_id nvme_id_table[] = {
> { PCI_DEVICE(0x126f, 0x2263), /* Silicon Motion unidentified */
> .driver_data = NVME_QUIRK_NO_NS_DESC_LIST, },
> { PCI_DEVICE(0x1bb1, 0x0100), /* Seagate Nytro Flash Storage */
> - .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
> + .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY |
> + NVME_QUIRK_NO_NS_DESC_LIST, },
> { PCI_DEVICE(0x1c58, 0x0003), /* HGST adapter */
> .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
> { PCI_DEVICE(0x1c58, 0x0023), /* WDC SN200 adapter */
> --
> 2.30.0
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-05 8:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-16 12:25 [PATCH] nvme-pci: mark Seagate Nytro XM1440 as QUIRK_NO_NS_DESC_LIST jeinwag-nvme
2021-02-16 17:54 ` Keith Busch
2021-02-24 9:12 ` Christoph Hellwig
2021-03-05 7:44 ` Christoph Hellwig
2021-03-05 8:42 ` AW: " Julian Einwag
[not found] <38eae52a15c5474dbdf85defcf6a29fa@marcapo.com>
2021-02-17 20:23 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).