From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Daniel Wagner <dwagner@suse.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Sagi Grimberg <sagi@grimberg.me>, Hannes Reinecke <hare@suse.de>
Subject: Re: [RFC v1] nvme: add cse, ds, ms, nsze and nuse to sysfs
Date: Mon, 27 Nov 2023 17:33:33 +0100 [thread overview]
Message-ID: <20231127163333.GA2273@lst.de> (raw)
In-Reply-To: <ZWTEFvYbI1bFTXyZ@kbusch-mbp.dhcp.thefacebook.com>
On Mon, Nov 27, 2023 at 09:30:14AM -0700, Keith Busch wrote:
> > > Should this even be an nvme specific attribute? I thought we should have
> > > blk-integrity.c report its 'tuple_size' attribute instead. That should
> > > work as long as we're not dealing with extended metadata at least, but
> > > that's kind of a special format that doesn't have block layer support.
> >
> > Reporting the tuple size is a good idea. But is that enough for
> > the existing nvme-cli use case?
>
> nvme-cli currently queries with admin passthrough identify command, so
> adding a new attribute won't break that. I assume Daniel would have it
> fallback to that same command for backward compatibilty if a desired
> sysfs attribute doesn't exist.
Yes. But does it care about the tuple size, or the actual size of the
metadata field even if is bigger than the PI tuple?
next prev parent reply other threads:[~2023-11-27 16:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 10:32 [RFC v1] nvme: add cse, ds, ms, nsze and nuse to sysfs Daniel Wagner
2023-11-27 10:44 ` Keith Busch
2023-11-27 12:07 ` Daniel Wagner
2023-11-27 13:57 ` Christoph Hellwig
2023-11-27 14:18 ` Christoph Hellwig
2023-11-27 15:44 ` Keith Busch
2023-11-27 15:56 ` Christoph Hellwig
2023-11-27 16:30 ` Keith Busch
2023-11-27 16:33 ` Christoph Hellwig [this message]
2023-11-27 16:46 ` Keith Busch
2023-11-28 8:21 ` Daniel Wagner
2023-11-28 10:06 ` Sagi Grimberg
2023-11-28 13:05 ` Christoph Hellwig
2023-11-28 19:02 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231127163333.GA2273@lst.de \
--to=hch@lst.de \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).