From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Daniel Wagner <dwagner@suse.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Sagi Grimberg <sagi@grimberg.me>, Hannes Reinecke <hare@suse.de>
Subject: Re: [RFC v1] nvme: add cse, ds, ms, nsze and nuse to sysfs
Date: Tue, 28 Nov 2023 14:05:08 +0100 [thread overview]
Message-ID: <20231128130508.GA8221@lst.de> (raw)
In-Reply-To: <ZWTH85bmw0cdePXf@kbusch-mbp.dhcp.thefacebook.com>
On Mon, Nov 27, 2023 at 09:46:43AM -0700, Keith Busch wrote:
> >
> > Yes. But does it care about the tuple size, or the actual size of the
> > metadata field even if is bigger than the PI tuple?
>
> tuple_size is the same value as metadata size regardless of PI usage.
> See nvme_init_integrity() for how this driver sets it:
>
> integrity.tuple_size = ns->ms;
Yes, for the case where we actually support integrity in the kernel
for a given device. But if the device has a metadata size larger than
the PI size we still support it, and just let the device strip/insert
the PI. And if nvme-cli wants to report detailed information about
the namespace it probably needs to report the actual metadata size
as the tuple size won't be reported given that we're never initializing
the kernel PI support.
next prev parent reply other threads:[~2023-11-28 13:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 10:32 [RFC v1] nvme: add cse, ds, ms, nsze and nuse to sysfs Daniel Wagner
2023-11-27 10:44 ` Keith Busch
2023-11-27 12:07 ` Daniel Wagner
2023-11-27 13:57 ` Christoph Hellwig
2023-11-27 14:18 ` Christoph Hellwig
2023-11-27 15:44 ` Keith Busch
2023-11-27 15:56 ` Christoph Hellwig
2023-11-27 16:30 ` Keith Busch
2023-11-27 16:33 ` Christoph Hellwig
2023-11-27 16:46 ` Keith Busch
2023-11-28 8:21 ` Daniel Wagner
2023-11-28 10:06 ` Sagi Grimberg
2023-11-28 13:05 ` Christoph Hellwig [this message]
2023-11-28 19:02 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128130508.GA8221@lst.de \
--to=hch@lst.de \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).