From: Daniel Wagner <dwagner@suse.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Sagi Grimberg <sagi@grimberg.me>, Hannes Reinecke <hare@suse.de>
Subject: Re: [RFC v1] nvme: add cse, ds, ms, nsze and nuse to sysfs
Date: Tue, 28 Nov 2023 09:21:45 +0100 [thread overview]
Message-ID: <n57gxockmm4iqt53olerr52rgxg3mvgdp4wfshyci2r7dohxfg@22mqtj3ya3g3> (raw)
In-Reply-To: <ZWTH85bmw0cdePXf@kbusch-mbp.dhcp.thefacebook.com>
On Mon, Nov 27, 2023 at 09:46:43AM -0700, Keith Busch wrote:
> On Mon, Nov 27, 2023 at 05:33:33PM +0100, Christoph Hellwig wrote:
> > On Mon, Nov 27, 2023 at 09:30:14AM -0700, Keith Busch wrote:
> > > > > Should this even be an nvme specific attribute? I thought we should have
> > > > > blk-integrity.c report its 'tuple_size' attribute instead. That should
> > > > > work as long as we're not dealing with extended metadata at least, but
> > > > > that's kind of a special format that doesn't have block layer support.
> > > >
> > > > Reporting the tuple size is a good idea. But is that enough for
> > > > the existing nvme-cli use case?
'nvme list' is just listening the block size and the meta size in the
'Format' field. So nothing really crazy going on:
Usage Format
-------------------------- ----------------
343.33 GB / 512.11 GB 512 B + 0 B
nvme-cli commands like 'nmve ns-id' etc will always issue a command so
that is not a concern. It's just the libnvme nvme_scan_topology() call
which should stop issuing any commands.
I'll add the missing tuple_size to the integrity sysfs dir in this case.
> > > nvme-cli currently queries with admin passthrough identify command, so
> > > adding a new attribute won't break that. I assume Daniel would have it
> > > fallback to that same command for backward compatibilty if a desired
> > > sysfs attribute doesn't exist.
Yes, a fallback will exist. There is no need to break existing users.
In summary, the only missing entries are
- csi
- tuple_size
- nuse
next prev parent reply other threads:[~2023-11-28 8:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 10:32 [RFC v1] nvme: add cse, ds, ms, nsze and nuse to sysfs Daniel Wagner
2023-11-27 10:44 ` Keith Busch
2023-11-27 12:07 ` Daniel Wagner
2023-11-27 13:57 ` Christoph Hellwig
2023-11-27 14:18 ` Christoph Hellwig
2023-11-27 15:44 ` Keith Busch
2023-11-27 15:56 ` Christoph Hellwig
2023-11-27 16:30 ` Keith Busch
2023-11-27 16:33 ` Christoph Hellwig
2023-11-27 16:46 ` Keith Busch
2023-11-28 8:21 ` Daniel Wagner [this message]
2023-11-28 10:06 ` Sagi Grimberg
2023-11-28 13:05 ` Christoph Hellwig
2023-11-28 19:02 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=n57gxockmm4iqt53olerr52rgxg3mvgdp4wfshyci2r7dohxfg@22mqtj3ya3g3 \
--to=dwagner@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).