From: Hannes Reinecke <hare@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, Hannes Reinecke <hare@kernel.org>
Subject: [PATCH 0/4] nvme: fixes for authentication errors
Date: Fri, 1 Mar 2024 12:28:19 +0100 [thread overview]
Message-ID: <20240301112823.132570-1-hare@kernel.org> (raw)
Hi all,
here's a set of fixes we've encountered during blktest runs.
Turns out that any authentication error we're generating
internally a in fact non-retryable, so we should map them
onto the appropriate NVMe status.
That caused some fallout on the target side, which gets
fixed with the remainder of this patchset.
As usual, comments and reviews are welcome.
Hannes Reinecke (4):
nvme: authentication error are always non-retryable
nvmet: lock config semaphore when accessing DH-HMAC-CHAP key
nvmet: return DHCHAP status codes from nvmet_setup_auth()
nvmet-loop: do not call nvme_ctrl_put() after nvme_ctrl_uninit()
drivers/nvme/host/core.c | 6 +++---
drivers/nvme/host/fabrics.c | 29 +++++++++++++++-----------
drivers/nvme/host/nvme.h | 2 +-
drivers/nvme/target/auth.c | 19 ++++++++---------
drivers/nvme/target/configfs.c | 22 ++++++++++++++-----
drivers/nvme/target/fabrics-cmd-auth.c | 11 +++++-----
drivers/nvme/target/loop.c | 1 -
7 files changed, 53 insertions(+), 37 deletions(-)
--
2.35.3
next reply other threads:[~2024-03-01 11:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 11:28 Hannes Reinecke [this message]
2024-03-01 11:28 ` [PATCH 1/4] nvme: authentication error are always non-retryable Hannes Reinecke
2024-03-01 13:12 ` Christoph Hellwig
2024-03-01 15:26 ` Hannes Reinecke
2024-03-07 8:51 ` Sagi Grimberg
2024-03-07 10:32 ` Hannes Reinecke
2024-03-07 11:37 ` Sagi Grimberg
2024-03-01 11:28 ` [PATCH 2/4] nvmet: lock config semaphore when accessing DH-HMAC-CHAP key Hannes Reinecke
2024-03-01 13:13 ` Christoph Hellwig
2024-03-07 8:53 ` Sagi Grimberg
2024-03-01 11:28 ` [PATCH 3/4] nvmet: return DHCHAP status codes from nvmet_setup_auth() Hannes Reinecke
2024-03-01 13:13 ` Christoph Hellwig
2024-03-07 8:56 ` Sagi Grimberg
2024-03-07 11:19 ` Hannes Reinecke
2024-03-07 12:03 ` Sagi Grimberg
2024-03-01 11:28 ` [PATCH 4/4] nvmet-loop: do not call nvme_ctrl_put() after nvme_ctrl_uninit() Hannes Reinecke
2024-03-01 13:14 ` Christoph Hellwig
2024-03-07 8:58 ` Sagi Grimberg
2024-03-01 12:24 ` [PATCH 0/4] nvme: fixes for authentication errors Daniel Wagner
2024-03-03 2:58 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240301112823.132570-1-hare@kernel.org \
--to=hare@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).