From: Sagi Grimberg <sagi@grimberg.me>
To: Hannes Reinecke <hare@suse.de>, Hannes Reinecke <hare@kernel.org>,
Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 3/4] nvmet: return DHCHAP status codes from nvmet_setup_auth()
Date: Thu, 7 Mar 2024 14:03:47 +0200 [thread overview]
Message-ID: <66a4f2b8-9e2b-4734-b1a1-083bd69411c7@grimberg.me> (raw)
In-Reply-To: <90c1e888-af15-4c89-9839-68d128d963d6@suse.de>
On 07/03/2024 13:19, Hannes Reinecke wrote:
> On 3/7/24 09:56, Sagi Grimberg wrote:
>>
>>
>> On 01/03/2024 13:28, Hannes Reinecke wrote:
>>> A failure in nvmet_setup_auth() does not mean that the NVMe
>>> authentication command failed, so we should rather return a
>>> protocol error with a 'failure1' response than an NVMe status.
>>
>> Shouldn't nvmet reply NVME_SC_INTERNAL like in other similar
>> cases?
>
> No. NVME_SC_INTERNAL will be converted into a status code for the
> authentication _command_, indicating that the authentication
> _command_ encountered an error.
> But authentication _command_ is fine (ie it got send and received
> okay). It's the authentication itself which failed, so we need to
> return an authentication protocol failure state.
Yes, I guess I was specifically asking about the failure to setup_auth
in the re-auth case...
next prev parent reply other threads:[~2024-03-07 12:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 11:28 [PATCH 0/4] nvme: fixes for authentication errors Hannes Reinecke
2024-03-01 11:28 ` [PATCH 1/4] nvme: authentication error are always non-retryable Hannes Reinecke
2024-03-01 13:12 ` Christoph Hellwig
2024-03-01 15:26 ` Hannes Reinecke
2024-03-07 8:51 ` Sagi Grimberg
2024-03-07 10:32 ` Hannes Reinecke
2024-03-07 11:37 ` Sagi Grimberg
2024-03-01 11:28 ` [PATCH 2/4] nvmet: lock config semaphore when accessing DH-HMAC-CHAP key Hannes Reinecke
2024-03-01 13:13 ` Christoph Hellwig
2024-03-07 8:53 ` Sagi Grimberg
2024-03-01 11:28 ` [PATCH 3/4] nvmet: return DHCHAP status codes from nvmet_setup_auth() Hannes Reinecke
2024-03-01 13:13 ` Christoph Hellwig
2024-03-07 8:56 ` Sagi Grimberg
2024-03-07 11:19 ` Hannes Reinecke
2024-03-07 12:03 ` Sagi Grimberg [this message]
2024-03-01 11:28 ` [PATCH 4/4] nvmet-loop: do not call nvme_ctrl_put() after nvme_ctrl_uninit() Hannes Reinecke
2024-03-01 13:14 ` Christoph Hellwig
2024-03-07 8:58 ` Sagi Grimberg
2024-03-01 12:24 ` [PATCH 0/4] nvme: fixes for authentication errors Daniel Wagner
2024-03-03 2:58 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66a4f2b8-9e2b-4734-b1a1-083bd69411c7@grimberg.me \
--to=sagi@grimberg.me \
--cc=hare@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).