From: Daniel Wagner <dwagner@suse.de>
To: Hannes Reinecke <hare@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 0/4] nvme: fixes for authentication errors
Date: Fri, 1 Mar 2024 13:24:35 +0100 [thread overview]
Message-ID: <a7ihwblvakwllis5v3qwt2vte2v4kqovhhn3r3k4gfokxo7xuq@olxcg3ncyd52> (raw)
In-Reply-To: <20240301112823.132570-1-hare@kernel.org>
On Fri, Mar 01, 2024 at 12:28:19PM +0100, Hannes Reinecke wrote:
> Hi all,
>
> here's a set of fixes we've encountered during blktest runs.
> Turns out that any authentication error we're generating
> internally a in fact non-retryable, so we should map them
> onto the appropriate NVMe status.
> That caused some fallout on the target side, which gets
> fixed with the remainder of this patchset.
>
> As usual, comments and reviews are welcome.
I've tested this with all transports and the results are pretty good.
Only rdma has some random fallouts (UAFs and lockdep warnings) but this
has nothing to do with this series.
With this series applied and my nvme/048 fixes from today, we finally
have fully working blktests for all transports.
Tested-by: Daniel Wagner <dwagner@suse.de>
Reviewed-by: Daniel Wagner <dwagner@suse.de>
next prev parent reply other threads:[~2024-03-01 12:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 11:28 [PATCH 0/4] nvme: fixes for authentication errors Hannes Reinecke
2024-03-01 11:28 ` [PATCH 1/4] nvme: authentication error are always non-retryable Hannes Reinecke
2024-03-01 13:12 ` Christoph Hellwig
2024-03-01 15:26 ` Hannes Reinecke
2024-03-07 8:51 ` Sagi Grimberg
2024-03-07 10:32 ` Hannes Reinecke
2024-03-07 11:37 ` Sagi Grimberg
2024-03-01 11:28 ` [PATCH 2/4] nvmet: lock config semaphore when accessing DH-HMAC-CHAP key Hannes Reinecke
2024-03-01 13:13 ` Christoph Hellwig
2024-03-07 8:53 ` Sagi Grimberg
2024-03-01 11:28 ` [PATCH 3/4] nvmet: return DHCHAP status codes from nvmet_setup_auth() Hannes Reinecke
2024-03-01 13:13 ` Christoph Hellwig
2024-03-07 8:56 ` Sagi Grimberg
2024-03-07 11:19 ` Hannes Reinecke
2024-03-07 12:03 ` Sagi Grimberg
2024-03-01 11:28 ` [PATCH 4/4] nvmet-loop: do not call nvme_ctrl_put() after nvme_ctrl_uninit() Hannes Reinecke
2024-03-01 13:14 ` Christoph Hellwig
2024-03-07 8:58 ` Sagi Grimberg
2024-03-01 12:24 ` Daniel Wagner [this message]
2024-03-03 2:58 ` [PATCH 0/4] nvme: fixes for authentication errors Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7ihwblvakwllis5v3qwt2vte2v4kqovhhn3r3k4gfokxo7xuq@olxcg3ncyd52 \
--to=dwagner@suse.de \
--cc=hare@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).