Linux-NVME Archive on lore.kernel.org
 help / color / Atom feed
From: "Meneghini, John" <John.Meneghini@netapp.com>
To: Keith Busch <kbusch@kernel.org>, Hannes Reinecke <hare@suse.de>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"Meneghini, John" <John.Meneghini@netapp.com>
Subject: Re: [PATCH V2] nvme: Add support for ACRE Command Interrupted status
Date: Wed, 4 Dec 2019 18:33:25 +0000
Message-ID: <79C46A7F-246A-4161-A7E4-ECACDCEC4A8A@netapp.com> (raw)
In-Reply-To: <20191204160737.GA1791@redsun51.ssa.fujisawa.hgst.com>

On 12/4/19, 11:12 AM, "linux-nvme on behalf of Keith Busch" <linux-nvme-bounces@lists.infradead.org on behalf of kbusch@kernel.org> wrote:
    
    I just don't understand this follow-up from John that I cropped it out
    of my original reply:
    
    > The alternative is to stop incrementing nvme_req(req)->retries in nvme_retry_req() when CRD is set.
    >
    >  @@ -258,8 +258,8 @@ static void nvme_retry_req(struct request *req)
    >        crd = (nvme_req(req)->status & NVME_SC_CRD) >> 11;
    >        if (ns && crd)
    >                delay = ns->ctrl->crdt[crd - 1] * 100;
    >-
    >-       nvme_req(req)->retries++;
    >+       else
    >+               nvme_req(req)->retries++;

Sorry for the confusion Keith.  This was not a part of my patch.
Just a diff to illustrate what would need to be done to handle
NVME_SC_CMD_INTERRUPTED internally in the nvme layer...
so that it never returned an error to the block layer.

I agree this is not the right thing to do.

/John  
 
    _______________________________________________
    linux-nvme mailing list
    linux-nvme@lists.infradead.org
    http://lists.infradead.org/mailman/listinfo/linux-nvme
    

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

      reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27 19:12 Meneghini, John
2019-12-03 17:38 ` Meneghini, John
2019-12-03 21:00   ` Keith Busch
2019-12-04 13:26     ` Hannes Reinecke
2019-12-04 14:48       ` Meneghini, John
2019-12-04 16:07       ` Keith Busch
2019-12-04 18:33         ` Meneghini, John [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79C46A7F-246A-4161-A7E4-ECACDCEC4A8A@netapp.com \
    --to=john.meneghini@netapp.com \
    --cc=hare@suse.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-NVME Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nvme/0 linux-nvme/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nvme linux-nvme/ https://lore.kernel.org/linux-nvme \
		linux-nvme@lists.infradead.org
	public-inbox-index linux-nvme

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-nvme


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git