From: Felipe Contreras <felipe.contreras@gmail.com>
To: linux-omap@vger.kernel.org
Cc: Hari Kanigeri <h-kanigeri2@ti.com>,
Hiroshi DOYU <hiroshi.doyu@nokia.com>,
Ameya Palande <ameya.palande@nokia.com>,
Fernando Guzman Lugo <x0095840@ti.com>,
Felipe Contreras <felipe.contreras@nokia.com>
Subject: [PATCH B 2/3] tidspbridge: cleanup and remove HW_MMU_TLBFlushAll
Date: Wed, 18 Mar 2009 03:26:44 +0200 [thread overview]
Message-ID: <1237339605-20697-3-git-send-email-felipe.contreras@gmail.com> (raw)
In-Reply-To: <1237339605-20697-2-git-send-email-felipe.contreras@gmail.com>
From: Felipe Contreras <felipe.contreras@nokia.com>
It doesn't make sense to have layers and layers of constants and defines
to turn one bit on.
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
---
drivers/dsp/bridge/hw/MMUAccInt.h | 3 ---
drivers/dsp/bridge/hw/MMURegAcM.h | 14 --------------
drivers/dsp/bridge/hw/hw_mmu.c | 9 ---------
drivers/dsp/bridge/hw/hw_mmu.h | 2 --
drivers/dsp/bridge/wmd/tiomap3430.c | 12 ++++++++++--
5 files changed, 10 insertions(+), 30 deletions(-)
diff --git a/drivers/dsp/bridge/hw/MMUAccInt.h b/drivers/dsp/bridge/hw/MMUAccInt.h
index 78e1d15..6ca1573 100644
--- a/drivers/dsp/bridge/hw/MMUAccInt.h
+++ b/drivers/dsp/bridge/hw/MMUAccInt.h
@@ -41,7 +41,6 @@
#define EASIL1_MMUMMU_LD_TLBWriteRegister32 (MMU_BASE_EASIL1 + 214)
#define EASIL1_MMUMMU_CAMWriteRegister32 (MMU_BASE_EASIL1 + 226)
#define EASIL1_MMUMMU_RAMWriteRegister32 (MMU_BASE_EASIL1 + 268)
-#define EASIL1_MMUMMU_GFLUSHGlobalFlushWrite32 (MMU_BASE_EASIL1 + 317)
#define EASIL1_MMUMMU_FLUSH_ENTRYWriteRegister32 (MMU_BASE_EASIL1 + 322)
/* Register offset address definitions */
@@ -73,7 +72,5 @@
#define MMU_MMU_LOCK_BaseValue_OFFSET 10
#define MMU_MMU_LOCK_CurrentVictim_MASK 0x3f0
#define MMU_MMU_LOCK_CurrentVictim_OFFSET 4
-#define MMU_MMU_GFLUSH_GlobalFlush_MASK 0x1
-#define MMU_MMU_GFLUSH_GlobalFlush_OFFSET 0
#endif /* _MMU_ACC_INT_H */
diff --git a/drivers/dsp/bridge/hw/MMURegAcM.h b/drivers/dsp/bridge/hw/MMURegAcM.h
index a130b1a..e46fdcb 100644
--- a/drivers/dsp/bridge/hw/MMURegAcM.h
+++ b/drivers/dsp/bridge/hw/MMURegAcM.h
@@ -239,20 +239,6 @@
}
-#define MMUMMU_GFLUSHGlobalFlushWrite32(baseAddress, value)\
-{\
- const u32 offset = MMU_MMU_GFLUSH_OFFSET;\
- register u32 data = RD_MEM_32_VOLATILE((baseAddress)+offset);\
- register u32 newValue = (value);\
- _DEBUG_LEVEL_1_EASI(EASIL1_MMUMMU_GFLUSHGlobalFlushWrite32);\
- data &= ~(MMU_MMU_GFLUSH_GlobalFlush_MASK);\
- newValue <<= MMU_MMU_GFLUSH_GlobalFlush_OFFSET;\
- newValue &= MMU_MMU_GFLUSH_GlobalFlush_MASK;\
- newValue |= data;\
- WR_MEM_32_VOLATILE(baseAddress+offset, newValue);\
-}
-
-
#define MMUMMU_FLUSH_ENTRYWriteRegister32(baseAddress, value)\
{\
const u32 offset = MMU_MMU_FLUSH_ENTRY_OFFSET;\
diff --git a/drivers/dsp/bridge/hw/hw_mmu.c b/drivers/dsp/bridge/hw/hw_mmu.c
index da7e092..ab65de0 100644
--- a/drivers/dsp/bridge/hw/hw_mmu.c
+++ b/drivers/dsp/bridge/hw/hw_mmu.c
@@ -212,15 +212,6 @@ HW_STATUS HW_MMU_VictimNumSet(const u32 baseAddress,
return status;
}
-HW_STATUS HW_MMU_TLBFlushAll(const u32 baseAddress)
-{
- HW_STATUS status = RET_OK;
-
- MMUMMU_GFLUSHGlobalFlushWrite32(baseAddress, HW_SET);
-
- return status;
-}
-
HW_STATUS HW_MMU_EventAck(const u32 baseAddress, u32 irqMask)
{
HW_STATUS status = RET_OK;
diff --git a/drivers/dsp/bridge/hw/hw_mmu.h b/drivers/dsp/bridge/hw/hw_mmu.h
index 924f32b..4783276 100644
--- a/drivers/dsp/bridge/hw/hw_mmu.h
+++ b/drivers/dsp/bridge/hw/hw_mmu.h
@@ -91,8 +91,6 @@ extern HW_STATUS HW_MMU_TLBFlush(const u32 baseAddress,
u32 virtualAddr,
u32 pageSize);
-extern HW_STATUS HW_MMU_TLBFlushAll(const u32 baseAddress);
-
extern HW_STATUS HW_MMU_TLBAdd(const u32 baseAddress,
u32 physicalAddr,
u32 virtualAddr,
diff --git a/drivers/dsp/bridge/wmd/tiomap3430.c b/drivers/dsp/bridge/wmd/tiomap3430.c
index b538ef7..30e0cb3 100644
--- a/drivers/dsp/bridge/wmd/tiomap3430.c
+++ b/drivers/dsp/bridge/wmd/tiomap3430.c
@@ -88,6 +88,9 @@
#define MMU_LARGE_PAGE_MASK 0xFFFF0000
#define MMU_SMALL_PAGE_MASK 0xFFFFF000
#define PAGES_II_LVL_TABLE 512
+
+#define MMU_GFLUSH 0x60
+
/* Forward Declarations: */
static DSP_STATUS WMD_BRD_Monitor(struct WMD_DEV_CONTEXT *pDevContext);
static DSP_STATUS WMD_BRD_Read(struct WMD_DEV_CONTEXT *pDevContext,
@@ -235,6 +238,11 @@ static struct WMD_DRV_INTERFACE drvInterfaceFxns = {
WMD_MSG_SetQueueId,
};
+static inline void tlb_flush_all(const u32 base)
+{
+ __raw_writeb(__raw_readb(base + MMU_GFLUSH) | 1, base + MMU_GFLUSH);
+}
+
static inline void flush_all(struct WMD_DEV_CONTEXT *pDevContext)
{
struct CFG_HOSTRES resources;
@@ -248,10 +256,10 @@ static inline void flush_all(struct WMD_DEV_CONTEXT *pDevContext)
DBG_Trace(DBG_LEVEL7, "temp value is 0x%x\n", temp);
CLK_Enable(SERVICESCLK_iva2_ck);
WakeDSP(pDevContext, NULL);
- HW_MMU_TLBFlushAll(pDevContext->dwDSPMmuBase);
+ tlb_flush_all(pDevContext->dwDSPMmuBase);
CLK_Disable(SERVICESCLK_iva2_ck);
} else
- HW_MMU_TLBFlushAll(pDevContext->dwDSPMmuBase);
+ tlb_flush_all(pDevContext->dwDSPMmuBase);
}
/*
--
1.6.2.1.287.g9a8be
next prev parent reply other threads:[~2009-03-18 1:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 1:26 [PATCH B 0/3] tidspbridge: don't flood the mailbox Felipe Contreras
2009-03-18 1:26 ` [PATCH B 1/3] tidspbridge: don't flood the mailbox on MemUnMap Felipe Contreras
2009-03-18 1:26 ` Felipe Contreras [this message]
2009-03-18 1:26 ` [PATCH B 3/3] tidspbridge: decreate timeout to a saner value Felipe Contreras
2009-03-19 20:42 ` Guzman Lugo, Fernando
2009-03-19 21:04 ` Felipe Contreras
2009-03-19 21:19 ` Guzman Lugo, Fernando
2009-03-19 21:35 ` Felipe Contreras
2009-03-20 0:00 ` Guzman Lugo, Fernando
2009-03-20 0:06 ` Felipe Contreras
2009-03-20 4:54 ` Hiroshi DOYU
2009-03-20 7:36 ` Hiroshi DOYU
2009-03-20 10:17 ` Felipe Contreras
2009-03-20 10:22 ` Gupta, Ramesh
2009-03-20 10:25 ` Felipe Contreras
2009-03-20 15:28 ` Tony Lindgren
2009-03-20 10:15 ` Felipe Contreras
2009-03-19 8:49 ` [PATCH B 2/3] tidspbridge: cleanup and remove HW_MMU_TLBFlushAll Felipe Contreras
2009-03-18 13:06 ` [PATCH B 1/3] tidspbridge: don't flood the mailbox on MemUnMap Kanigeri, Hari
2009-03-18 13:29 ` Felipe Contreras
2009-03-18 13:49 ` Kanigeri, Hari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237339605-20697-3-git-send-email-felipe.contreras@gmail.com \
--to=felipe.contreras@gmail.com \
--cc=ameya.palande@nokia.com \
--cc=felipe.contreras@nokia.com \
--cc=h-kanigeri2@ti.com \
--cc=hiroshi.doyu@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=x0095840@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).