linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Guzman Lugo, Fernando" <x0095840@ti.com>
To: Felipe Contreras <felipe.contreras@gmail.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Cc: "Kanigeri, Hari" <h-kanigeri2@ti.com>,
	Hiroshi DOYU <hiroshi.doyu@nokia.com>,
	Ameya Palande <ameya.palande@nokia.com>,
	Felipe Contreras <felipe.contreras@nokia.com>
Subject: RE: [PATCH B 3/3] tidspbridge: decreate timeout to a saner value
Date: Thu, 19 Mar 2009 15:42:14 -0500	[thread overview]
Message-ID: <496565EC904933469F292DDA3F1663E60287D6286E@dlee06.ent.ti.com> (raw)
In-Reply-To: <1237339605-20697-4-git-send-email-felipe.contreras@gmail.com>



Hi Felipe,

	I am seeing with this patch because of the timeout:

DSP device detected !!
DSPProcessor_Attach succeeded.
dspbridge: timed out waiting for mailbox
dspbridge: timed out waiting for mailbox
dspbridge: timed out waiting for mailbox
dspbridge: timed out waiting for mailbox
dspbridge: timed out waiting for mailbox
dspbridge: timed out waiting for mailbox
dspbridge: timed out waiting for mailbox
dspbridge: timed out waiting for mailbox
dspbridge: timed out waiting for mailbox
dspbridge: timed out waiting for mailbox
dspbridge: timed out waiting for mailbox
...

Did you see any issue when you change to 1ms? Maybe we can use a bigger timeout.

Please let me know your comments.

Regards,
Fernando.

-----Original Message-----
From: Felipe Contreras [mailto:felipe.contreras@gmail.com] 
Sent: Tuesday, March 17, 2009 7:27 PM
To: linux-omap@vger.kernel.org
Cc: Kanigeri, Hari; Hiroshi DOYU; Ameya Palande; Guzman Lugo, Fernando; Felipe Contreras
Subject: [PATCH B 3/3] tidspbridge: decreate timeout to a saner value

From: Felipe Contreras <felipe.contreras@nokia.com>

Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
---
 drivers/dsp/bridge/wmd/tiomap_sm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/dsp/bridge/wmd/tiomap_sm.c b/drivers/dsp/bridge/wmd/tiomap_sm.c
index 1b31162..535dc13 100644
--- a/drivers/dsp/bridge/wmd/tiomap_sm.c
+++ b/drivers/dsp/bridge/wmd/tiomap_sm.c
@@ -144,7 +144,7 @@ DSP_STATUS CHNLSM_InterruptDSP2(struct WMD_DEV_CONTEXT *pDevContext,
 
 		pDevContext->dwBrdState = BRD_RUNNING;
 	}
-	timeout = jiffies + msecs_to_jiffies(10);
+	timeout = jiffies + msecs_to_jiffies(1);
 	while (fifo_full((void __iomem *) resources.dwMboxBase, 0)) {
 		if (time_after(jiffies, timeout)) {
 			printk(KERN_ERR "dspbridge: timed out waiting for mailbox\n");
-- 
1.6.2.1.287.g9a8be



  reply	other threads:[~2009-03-19 20:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-18  1:26 [PATCH B 0/3] tidspbridge: don't flood the mailbox Felipe Contreras
2009-03-18  1:26 ` [PATCH B 1/3] tidspbridge: don't flood the mailbox on MemUnMap Felipe Contreras
2009-03-18  1:26   ` [PATCH B 2/3] tidspbridge: cleanup and remove HW_MMU_TLBFlushAll Felipe Contreras
2009-03-18  1:26     ` [PATCH B 3/3] tidspbridge: decreate timeout to a saner value Felipe Contreras
2009-03-19 20:42       ` Guzman Lugo, Fernando [this message]
2009-03-19 21:04         ` Felipe Contreras
2009-03-19 21:19           ` Guzman Lugo, Fernando
2009-03-19 21:35             ` Felipe Contreras
2009-03-20  0:00               ` Guzman Lugo, Fernando
2009-03-20  0:06                 ` Felipe Contreras
2009-03-20  4:54                   ` Hiroshi DOYU
2009-03-20  7:36                     ` Hiroshi DOYU
2009-03-20 10:17                       ` Felipe Contreras
2009-03-20 10:22                         ` Gupta, Ramesh
2009-03-20 10:25                           ` Felipe Contreras
2009-03-20 15:28                             ` Tony Lindgren
2009-03-20 10:15                     ` Felipe Contreras
2009-03-19  8:49     ` [PATCH B 2/3] tidspbridge: cleanup and remove HW_MMU_TLBFlushAll Felipe Contreras
2009-03-18 13:06   ` [PATCH B 1/3] tidspbridge: don't flood the mailbox on MemUnMap Kanigeri, Hari
2009-03-18 13:29     ` Felipe Contreras
2009-03-18 13:49       ` Kanigeri, Hari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=496565EC904933469F292DDA3F1663E60287D6286E@dlee06.ent.ti.com \
    --to=x0095840@ti.com \
    --cc=ameya.palande@nokia.com \
    --cc=felipe.contreras@gmail.com \
    --cc=felipe.contreras@nokia.com \
    --cc=h-kanigeri2@ti.com \
    --cc=hiroshi.doyu@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).