From: Felipe Contreras <felipe.contreras@gmail.com>
To: linux-omap@vger.kernel.org
Cc: Hari Kanigeri <h-kanigeri2@ti.com>,
Hiroshi DOYU <hiroshi.doyu@nokia.com>,
Ameya Palande <ameya.palande@nokia.com>,
Fernando Guzman Lugo <x0095840@ti.com>,
Felipe Contreras <felipe.contreras@nokia.com>
Subject: Re: [PATCH B 2/3] tidspbridge: cleanup and remove HW_MMU_TLBFlushAll
Date: Thu, 19 Mar 2009 10:49:00 +0200 [thread overview]
Message-ID: <94a0d4530903190149g3b9b7dbav2abb95c953ee9929@mail.gmail.com> (raw)
In-Reply-To: <1237339605-20697-3-git-send-email-felipe.contreras@gmail.com>
On Wed, Mar 18, 2009 at 3:26 AM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> From: Felipe Contreras <felipe.contreras@nokia.com>
>
> It doesn't make sense to have layers and layers of constants and defines
> to turn one bit on.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
> ---
I thought a bit more about this:
> +static inline void tlb_flush_all(const u32 base)
> +{
> + __raw_writeb(__raw_readb(base + MMU_GFLUSH) | 1, base + MMU_GFLUSH);
> +}
> +
Originally it was the equivalent of __raw_writel(__raw_readl but since
we are dealing only with one bit I chose 'b' instead of 'l'. Is that
correct?
--
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-03-19 8:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 1:26 [PATCH B 0/3] tidspbridge: don't flood the mailbox Felipe Contreras
2009-03-18 1:26 ` [PATCH B 1/3] tidspbridge: don't flood the mailbox on MemUnMap Felipe Contreras
2009-03-18 1:26 ` [PATCH B 2/3] tidspbridge: cleanup and remove HW_MMU_TLBFlushAll Felipe Contreras
2009-03-18 1:26 ` [PATCH B 3/3] tidspbridge: decreate timeout to a saner value Felipe Contreras
2009-03-19 20:42 ` Guzman Lugo, Fernando
2009-03-19 21:04 ` Felipe Contreras
2009-03-19 21:19 ` Guzman Lugo, Fernando
2009-03-19 21:35 ` Felipe Contreras
2009-03-20 0:00 ` Guzman Lugo, Fernando
2009-03-20 0:06 ` Felipe Contreras
2009-03-20 4:54 ` Hiroshi DOYU
2009-03-20 7:36 ` Hiroshi DOYU
2009-03-20 10:17 ` Felipe Contreras
2009-03-20 10:22 ` Gupta, Ramesh
2009-03-20 10:25 ` Felipe Contreras
2009-03-20 15:28 ` Tony Lindgren
2009-03-20 10:15 ` Felipe Contreras
2009-03-19 8:49 ` Felipe Contreras [this message]
2009-03-18 13:06 ` [PATCH B 1/3] tidspbridge: don't flood the mailbox on MemUnMap Kanigeri, Hari
2009-03-18 13:29 ` Felipe Contreras
2009-03-18 13:49 ` Kanigeri, Hari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a0d4530903190149g3b9b7dbav2abb95c953ee9929@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=ameya.palande@nokia.com \
--cc=felipe.contreras@nokia.com \
--cc=h-kanigeri2@ti.com \
--cc=hiroshi.doyu@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=x0095840@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).