* [patch] twl4030-regulator: expose VPLL2
@ 2009-03-14 0:54 David Brownell
2009-03-16 11:43 ` Liam Girdwood
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: David Brownell @ 2009-03-14 0:54 UTC (permalink / raw)
To: Liam Girdwood; +Cc: Mark Brown, OMAP, lkml
From: David Brownell <dbrownell@users.sourceforge.net>
Add VPLL2 to the set of twl4030-family regulators exposed for
use by various drivers. It's commonly used to power the digital
video outputs (e.g. LCD or DVI displays) on OMAP3 systems.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
---
Please apply to regulator-next and linux-omap ... I'll send
some patches configuring various OMAP boards to use this.
drivers/mfd/twl4030-core.c | 2 --
drivers/regulator/twl4030-regulator.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
--- a/drivers/mfd/twl4030-core.c
+++ b/drivers/mfd/twl4030-core.c
@@ -613,11 +613,9 @@ add_children(struct twl4030_platform_dat
/* maybe add LDOs that are omitted on cost-reduced parts */
if (twl_has_regulator() && !(features & TPS_SUBSET)) {
- /*
child = add_regulator(TWL4030_REG_VPLL2, pdata->vpll2);
if (IS_ERR(child))
return PTR_ERR(child);
- */
child = add_regulator(TWL4030_REG_VMMC2, pdata->vmmc2);
if (IS_ERR(child))
--- a/drivers/regulator/twl4030-regulator.c
+++ b/drivers/regulator/twl4030-regulator.c
@@ -404,8 +404,8 @@ static struct twlreg_info twl4030_regs[]
TWL_ADJUSTABLE_LDO(VMMC2, 0x2b, 6),
/*
TWL_ADJUSTABLE_LDO(VPLL1, 0x2f, 7),
- TWL_ADJUSTABLE_LDO(VPLL2, 0x33, 8),
*/
+ TWL_ADJUSTABLE_LDO(VPLL2, 0x33, 8),
TWL_ADJUSTABLE_LDO(VSIM, 0x37, 9),
TWL_ADJUSTABLE_LDO(VDAC, 0x3b, 10),
/*
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] twl4030-regulator: expose VPLL2
2009-03-14 0:54 [patch] twl4030-regulator: expose VPLL2 David Brownell
@ 2009-03-16 11:43 ` Liam Girdwood
2009-03-16 15:51 ` Mark Brown
2009-03-20 18:47 ` [APPLIED] " Tony Lindgren
2 siblings, 0 replies; 6+ messages in thread
From: Liam Girdwood @ 2009-03-16 11:43 UTC (permalink / raw)
To: dbrownell, Samuel Ortiz; +Cc: Mark Brown, OMAP, lkml
On Fri, 2009-03-13 at 17:54 -0700, David Brownell wrote:
> From: David Brownell <dbrownell@users.sourceforge.net>
>
> Add VPLL2 to the set of twl4030-family regulators exposed for
> use by various drivers. It's commonly used to power the digital
> video outputs (e.g. LCD or DVI displays) on OMAP3 systems.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
> Please apply to regulator-next and linux-omap ... I'll send
> some patches configuring various OMAP boards to use this.
>
> drivers/mfd/twl4030-core.c | 2 --
> drivers/regulator/twl4030-regulator.c | 2 +-
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> --- a/drivers/mfd/twl4030-core.c
> +++ b/drivers/mfd/twl4030-core.c
> @@ -613,11 +613,9 @@ add_children(struct twl4030_platform_dat
>
> /* maybe add LDOs that are omitted on cost-reduced parts */
> if (twl_has_regulator() && !(features & TPS_SUBSET)) {
> - /*
> child = add_regulator(TWL4030_REG_VPLL2, pdata->vpll2);
> if (IS_ERR(child))
> return PTR_ERR(child);
> - */
>
> child = add_regulator(TWL4030_REG_VMMC2, pdata->vmmc2);
> if (IS_ERR(child))
> --- a/drivers/regulator/twl4030-regulator.c
> +++ b/drivers/regulator/twl4030-regulator.c
> @@ -404,8 +404,8 @@ static struct twlreg_info twl4030_regs[]
> TWL_ADJUSTABLE_LDO(VMMC2, 0x2b, 6),
> /*
> TWL_ADJUSTABLE_LDO(VPLL1, 0x2f, 7),
> - TWL_ADJUSTABLE_LDO(VPLL2, 0x33, 8),
> */
> + TWL_ADJUSTABLE_LDO(VPLL2, 0x33, 8),
> TWL_ADJUSTABLE_LDO(VSIM, 0x37, 9),
> TWL_ADJUSTABLE_LDO(VDAC, 0x3b, 10),
> /*
>
Samuel, I'm fine putting this through regulator if its fine with you ?
Thanks
Liam
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] twl4030-regulator: expose VPLL2
2009-03-14 0:54 [patch] twl4030-regulator: expose VPLL2 David Brownell
2009-03-16 11:43 ` Liam Girdwood
@ 2009-03-16 15:51 ` Mark Brown
2009-03-19 18:13 ` Liam Girdwood
2009-03-20 18:47 ` [APPLIED] " Tony Lindgren
2 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2009-03-16 15:51 UTC (permalink / raw)
To: dbrownell; +Cc: Liam Girdwood, OMAP, lkml
On Fri, Mar 13, 2009 at 05:54:54PM -0700, David Brownell wrote:
> From: David Brownell <dbrownell@users.sourceforge.net>
>
> Add VPLL2 to the set of twl4030-family regulators exposed for
> use by various drivers. It's commonly used to power the digital
> video outputs (e.g. LCD or DVI displays) on OMAP3 systems.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] twl4030-regulator: expose VPLL2
2009-03-16 15:51 ` Mark Brown
@ 2009-03-19 18:13 ` Liam Girdwood
2009-03-22 19:19 ` Samuel Ortiz
0 siblings, 1 reply; 6+ messages in thread
From: Liam Girdwood @ 2009-03-19 18:13 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: dbrownell, OMAP, lkml, Mark Brown
On Mon, 2009-03-16 at 15:51 +0000, Mark Brown wrote:
> On Fri, Mar 13, 2009 at 05:54:54PM -0700, David Brownell wrote:
> > From: David Brownell <dbrownell@users.sourceforge.net>
> >
> > Add VPLL2 to the set of twl4030-family regulators exposed for
> > use by various drivers. It's commonly used to power the digital
> > video outputs (e.g. LCD or DVI displays) on OMAP3 systems.
> >
> > Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Samuel, I've applied this to the regulator tree as the part that touches
mfd is relatively minor and twl4030 specific (doesn't touch core).
Thanks
Liam
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] twl4030-regulator: expose VPLL2
2009-03-19 18:13 ` Liam Girdwood
@ 2009-03-22 19:19 ` Samuel Ortiz
0 siblings, 0 replies; 6+ messages in thread
From: Samuel Ortiz @ 2009-03-22 19:19 UTC (permalink / raw)
To: Liam Girdwood; +Cc: dbrownell, OMAP, lkml, Mark Brown
On Thu, Mar 19, 2009 at 06:13:46PM +0000, Liam Girdwood wrote:
> On Mon, 2009-03-16 at 15:51 +0000, Mark Brown wrote:
> > On Fri, Mar 13, 2009 at 05:54:54PM -0700, David Brownell wrote:
> > > From: David Brownell <dbrownell@users.sourceforge.net>
> > >
> > > Add VPLL2 to the set of twl4030-family regulators exposed for
> > > use by various drivers. It's commonly used to power the digital
> > > video outputs (e.g. LCD or DVI displays) on OMAP3 systems.
> > >
> > > Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> >
> > Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
> Samuel, I've applied this to the regulator tree as the part that touches
> mfd is relatively minor and twl4030 specific (doesn't touch core).
Thanks a lot, and sorry for the late reply...
Feel free to add my Acked-by: if needed.
Cheers,
Samuel.
> Thanks
>
> Liam
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [APPLIED] [patch] twl4030-regulator: expose VPLL2
2009-03-14 0:54 [patch] twl4030-regulator: expose VPLL2 David Brownell
2009-03-16 11:43 ` Liam Girdwood
2009-03-16 15:51 ` Mark Brown
@ 2009-03-20 18:47 ` Tony Lindgren
2 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2009-03-20 18:47 UTC (permalink / raw)
To: linux-omap
This patch has been applied to the linux-omap
by youw fwiendly patch wobot.
Commit: 989f9207562ffca4e83d0329c59efa0059287e46
PatchWorks
http://patchwork.kernel.org/patch/11961/
Git
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=989f9207562ffca4e83d0329c59efa0059287e46
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-03-22 19:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-14 0:54 [patch] twl4030-regulator: expose VPLL2 David Brownell
2009-03-16 11:43 ` Liam Girdwood
2009-03-16 15:51 ` Mark Brown
2009-03-19 18:13 ` Liam Girdwood
2009-03-22 19:19 ` Samuel Ortiz
2009-03-20 18:47 ` [APPLIED] " Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).