Linux-OMAP Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] ARM: multi_v7_defconfig: ti: Enable networking options for nfs boot
@ 2020-10-01 20:27 Grygorii Strashko
  2020-10-02 12:50 ` Nishanth Menon
  0 siblings, 1 reply; 6+ messages in thread
From: Grygorii Strashko @ 2020-10-01 20:27 UTC (permalink / raw)
  To: Tony Lindgren, linux-omap, linux-arm-kernel, Nishanth Menon,
	Arnd Bergmann
  Cc: linux-kernel, Sekhar Nori, Vignesh Raghavendra, Russell King,
	Grygorii Strashko

Enable networking options required for NFS boot on TI platforms, which is
widely for automated test systems.
- enable new TI CPSW switch driver and related NET_SWITCHDEV config
- enable TI DP83867 phy
- explicitly enable PTP clock support to ensure dependent networking
drivers will stay built-in

Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
 arch/arm/configs/multi_v7_defconfig | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index e9e76e32f10f..11b3184d8154 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -152,6 +152,7 @@ CONFIG_INET6_IPCOMP=m
 CONFIG_IPV6_MIP6=m
 CONFIG_IPV6_TUNNEL=m
 CONFIG_IPV6_MULTIPLE_TABLES=y
+CONFIG_NET_SWITCHDEV=y
 CONFIG_NET_DSA=m
 CONFIG_CAN=y
 CONFIG_CAN_AT91=m
@@ -268,9 +269,12 @@ CONFIG_SNI_AVE=y
 CONFIG_STMMAC_ETH=y
 CONFIG_DWMAC_DWC_QOS_ETH=y
 CONFIG_TI_CPSW=y
+CONFIG_TI_CPSW_SWITCHDEV=y
+CONFIG_TI_CPTS=y
 CONFIG_XILINX_EMACLITE=y
 CONFIG_BROADCOM_PHY=y
 CONFIG_ICPLUS_PHY=y
+CONFIG_DP83867_PHY=y
 CONFIG_MARVELL_PHY=y
 CONFIG_MICREL_PHY=y
 CONFIG_AT803X_PHY=y
@@ -434,6 +438,7 @@ CONFIG_SPI_TEGRA20_SLINK=y
 CONFIG_SPI_XILINX=y
 CONFIG_SPI_SPIDEV=y
 CONFIG_SPMI=y
+CONFIG_PTP_1588_CLOCK=y
 CONFIG_PINCTRL_AS3722=y
 CONFIG_PINCTRL_RZA2=y
 CONFIG_PINCTRL_STMFX=y
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: multi_v7_defconfig: ti: Enable networking options for nfs boot
  2020-10-01 20:27 [PATCH] ARM: multi_v7_defconfig: ti: Enable networking options for nfs boot Grygorii Strashko
@ 2020-10-02 12:50 ` Nishanth Menon
  2020-10-29 19:15   ` Grygorii Strashko
  0 siblings, 1 reply; 6+ messages in thread
From: Nishanth Menon @ 2020-10-02 12:50 UTC (permalink / raw)
  To: Grygorii Strashko
  Cc: Tony Lindgren, linux-omap, linux-arm-kernel, Arnd Bergmann,
	linux-kernel, Sekhar Nori, Vignesh Raghavendra, Russell King

On 23:27-20201001, Grygorii Strashko wrote:
> Enable networking options required for NFS boot on TI platforms, which is
> widely for automated test systems.
> - enable new TI CPSW switch driver and related NET_SWITCHDEV config
> - enable TI DP83867 phy
> - explicitly enable PTP clock support to ensure dependent networking
> drivers will stay built-in
> 
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
>  arch/arm/configs/multi_v7_defconfig | 5 +++++
>  1 file changed, 5 insertions(+)
> 

[...]

Reviewed-by: Nishanth Menon <nm@ti.com>

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: multi_v7_defconfig: ti: Enable networking options for nfs boot
  2020-10-02 12:50 ` Nishanth Menon
@ 2020-10-29 19:15   ` Grygorii Strashko
  2020-10-29 20:06     ` Arnd Bergmann
  0 siblings, 1 reply; 6+ messages in thread
From: Grygorii Strashko @ 2020-10-29 19:15 UTC (permalink / raw)
  To: Nishanth Menon, Tony Lindgren, Arnd Bergmann, Olof Johansson
  Cc: linux-omap, linux-arm-kernel, linux-kernel, Sekhar Nori,
	Vignesh Raghavendra, Russell King

Hi All,

On 02/10/2020 15:50, Nishanth Menon wrote:
> On 23:27-20201001, Grygorii Strashko wrote:
>> Enable networking options required for NFS boot on TI platforms, which is
>> widely for automated test systems.
>> - enable new TI CPSW switch driver and related NET_SWITCHDEV config
>> - enable TI DP83867 phy
>> - explicitly enable PTP clock support to ensure dependent networking
>> drivers will stay built-in
>>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>> ---
>>   arch/arm/configs/multi_v7_defconfig | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
> 
> [...]
> 
> Reviewed-by: Nishanth Menon <nm@ti.com>
> 

Are there any actions need to be done to have this patch merged?

-- 
Best regards,
grygorii

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: multi_v7_defconfig: ti: Enable networking options for nfs boot
  2020-10-29 19:15   ` Grygorii Strashko
@ 2020-10-29 20:06     ` Arnd Bergmann
  2020-10-30  9:36       ` Grygorii Strashko
  0 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2020-10-29 20:06 UTC (permalink / raw)
  To: Grygorii Strashko
  Cc: Nishanth Menon, Tony Lindgren, Arnd Bergmann, Olof Johansson,
	linux-omap, Linux ARM, linux-kernel, Sekhar Nori,
	Vignesh Raghavendra, Russell King

On Thu, Oct 29, 2020 at 8:15 PM Grygorii Strashko
<grygorii.strashko@ti.com> wrote:
> On 02/10/2020 15:50, Nishanth Menon wrote:
> > On 23:27-20201001, Grygorii Strashko wrote:
> >> Enable networking options required for NFS boot on TI platforms, which is
> >> widely for automated test systems.
> >> - enable new TI CPSW switch driver and related NET_SWITCHDEV config
> >> - enable TI DP83867 phy
> >> - explicitly enable PTP clock support to ensure dependent networking
> >> drivers will stay built-in
> >>
> >> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> >> ---
> >>   arch/arm/configs/multi_v7_defconfig | 5 +++++
> >>   1 file changed, 5 insertions(+)
> >>
> >
> > [...]
> >
> > Reviewed-by: Nishanth Menon <nm@ti.com>
> >
>
> Are there any actions need to be done to have this patch merged?

I would prefer if a platform maintainer (I assume Tony in this case)
picks it up and forwards it to soc@kernel.org together with other
related changes. Olof and I tend to ignore patches sent directly
to us, so we don't get in the way of platform maintainers that
may have already merged similar patches or have comments.

I suspect Tony didn't pick it up either because from the patch
subject and the description, it is not clear that he is the one
to act on it. It helps to be more specific and ask the maintainer
by addressing them in person below the '---' line, as well as
only putting one person in 'To:' and the rest in 'Cc:'.

One comment on the contents of the patch: IIRC this is a fairly
large driver. To ensure we don't burden other users too much,
can you include the size of the vmlinux file before and after
this patch?

      Arnd

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: multi_v7_defconfig: ti: Enable networking options for nfs boot
  2020-10-29 20:06     ` Arnd Bergmann
@ 2020-10-30  9:36       ` Grygorii Strashko
  2020-10-30 10:01         ` Arnd Bergmann
  0 siblings, 1 reply; 6+ messages in thread
From: Grygorii Strashko @ 2020-10-30  9:36 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Nishanth Menon, Tony Lindgren, Arnd Bergmann, Olof Johansson,
	linux-omap, Linux ARM, linux-kernel, Sekhar Nori,
	Vignesh Raghavendra, Russell King

Hi Arnd,

On 29/10/2020 22:06, Arnd Bergmann wrote:
> On Thu, Oct 29, 2020 at 8:15 PM Grygorii Strashko
> <grygorii.strashko@ti.com> wrote:
>> On 02/10/2020 15:50, Nishanth Menon wrote:
>>> On 23:27-20201001, Grygorii Strashko wrote:
>>>> Enable networking options required for NFS boot on TI platforms, which is
>>>> widely for automated test systems.
>>>> - enable new TI CPSW switch driver and related NET_SWITCHDEV config
>>>> - enable TI DP83867 phy
>>>> - explicitly enable PTP clock support to ensure dependent networking
>>>> drivers will stay built-in
>>>>
>>>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>>>> ---
>>>>    arch/arm/configs/multi_v7_defconfig | 5 +++++
>>>>    1 file changed, 5 insertions(+)
>>>>
>>>
>>> [...]
>>>
>>> Reviewed-by: Nishanth Menon <nm@ti.com>
>>>
>>
>> Are there any actions need to be done to have this patch merged?
> 
> I would prefer if a platform maintainer (I assume Tony in this case)
> picks it up and forwards it to soc@kernel.org together with other
> related changes. Olof and I tend to ignore patches sent directly
> to us, so we don't get in the way of platform maintainers that
> may have already merged similar patches or have comments.
> 
> I suspect Tony didn't pick it up either because from the patch
> subject and the description, it is not clear that he is the one
> to act on it. It helps to be more specific and ask the maintainer
> by addressing them in person below the '---' line, as well as
> only putting one person in 'To:' and the rest in 'Cc:'.

Thanks for your comments and sorry that I disturbed you.

But, honestly, I'm confused (and probably I'm not the first one) as multi_v7 is common
for all ARM platforms while change is TI OMAP specific,
and neither Documentation neither get_maintainer.pl provide any reliable information
on how to proceed :( and who should be responsible for merging multi_x patches.

I'd really have tried to do some checking while preparing patch and TO/CC list - some patches applied by
platform maintainers, but some by top ARM maintainers.

> 
> One comment on the contents of the patch: IIRC this is a fairly
> large driver. To ensure we don't burden other users too much,
> can you include the size of the vmlinux file before and after
> this patch?

before:
    text	   data	    bss	    dec	    hex	filename
14703736	8024602	 444976	23173314	16198c2	./omap-arm/vmlinux

after:
    text	   data	    bss	    dec	    hex	filename
14727271	8029150	 444528	23200949	16204b5	./omap-arm/vmlinux

diff: 27635 (dec)

-- 
Best regards,
grygorii

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: multi_v7_defconfig: ti: Enable networking options for nfs boot
  2020-10-30  9:36       ` Grygorii Strashko
@ 2020-10-30 10:01         ` Arnd Bergmann
  0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2020-10-30 10:01 UTC (permalink / raw)
  To: Grygorii Strashko
  Cc: Nishanth Menon, Tony Lindgren, Arnd Bergmann, Olof Johansson,
	linux-omap, Linux ARM, linux-kernel, Sekhar Nori,
	Vignesh Raghavendra, Russell King

On Fri, Oct 30, 2020 at 10:36 AM Grygorii Strashko
<grygorii.strashko@ti.com> wrote:
> On 29/10/2020 22:06, Arnd Bergmann wrote:
> >>
> >> Are there any actions need to be done to have this patch merged?
> >
> > I would prefer if a platform maintainer (I assume Tony in this case)
> > picks it up and forwards it to soc@kernel.org together with other
> > related changes. Olof and I tend to ignore patches sent directly
> > to us, so we don't get in the way of platform maintainers that
> > may have already merged similar patches or have comments.
> >
> > I suspect Tony didn't pick it up either because from the patch
> > subject and the description, it is not clear that he is the one
> > to act on it. It helps to be more specific and ask the maintainer
> > by addressing them in person below the '---' line, as well as
> > only putting one person in 'To:' and the rest in 'Cc:'.
>
> Thanks for your comments and sorry that I disturbed you.
>
> But, honestly, I'm confused (and probably I'm not the first one) as multi_v7 is common
> for all ARM platforms while change is TI OMAP specific,
> and neither Documentation neither get_maintainer.pl provide any reliable information
> on how to proceed :( and who should be responsible for merging multi_x patches.
>
> I'd really have tried to do some checking while preparing patch and TO/CC list -
> some patches applied by platform maintainers, but some by top ARM maintainers.

I understand that this is confusion, and we should probably come up
with a better way to handle it.

To clarify further, while we prefer the patches to be picked up by the
platform maintainers and forwarded to us for patches to the common
files that are needed for a particular platform, you can also send these
patches directly to soc@kernel.org, which puts them into patchwork
at https://patchwork.kernel.org/project/linux-soc/list/. Once it's in
there, we will process it by merging the patch or getting back to you
for further clarification.

> > One comment on the contents of the patch: IIRC this is a fairly
> > large driver. To ensure we don't burden other users too much,
> > can you include the size of the vmlinux file before and after
> > this patch?
>
> before:
>     text           data     bss     dec     hex filename
> 14703736        8024602  444976 23173314        16198c2 ./omap-arm/vmlinux
>
> after:
>     text           data     bss     dec     hex filename
> 14727271        8029150  444528 23200949        16204b5 ./omap-arm/vmlinux
>
> diff: 27635 (dec)

Ok, that doesn't look too bad, though the total size is definitely worrying.
Please include the above in the changelog text.

       Arnd

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-01 20:27 [PATCH] ARM: multi_v7_defconfig: ti: Enable networking options for nfs boot Grygorii Strashko
2020-10-02 12:50 ` Nishanth Menon
2020-10-29 19:15   ` Grygorii Strashko
2020-10-29 20:06     ` Arnd Bergmann
2020-10-30  9:36       ` Grygorii Strashko
2020-10-30 10:01         ` Arnd Bergmann

Linux-OMAP Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-omap/0 linux-omap/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-omap linux-omap/ https://lore.kernel.org/linux-omap \
		linux-omap@vger.kernel.org
	public-inbox-index linux-omap

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-omap


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git