Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

[Nikhil Devshatwar <nikhil.nd@ti.com>]

On 14:02-20201105, Tomi Valkeinen wrote:
> Hi,
> 
> This is third version of the series sent by Sebastian in February:
> 
> https://www.spinics.net/lists/linux-omap/msg153465.html
> 
> I took the patches from his git tree, and rebased on 5.10-rc2. There
> were some conflicts and compilation errors, and one bug that made dsi to
> not work (videomode variable was not initialized to 0).
> 
> I then fixed the few checkpatch and sparse issues. Overall, Sebastian's
> patches are pretty much as they were previously. I did drop Laurent's
> reviewed-bys, as it's been a long time since the previous series, and
> the patches are not identical anyway.
> 
> The topmost 5 patches are new ones, cleanups enabled by the DSI
> conversion. They could be handled separately, but it's such a nice
> cleanup, and I've been waiting for years to get this done, so here they
> are. That said, there are still a _lot_ of cleanups to do.
> 
> Almost all of the patches are omapdrm changes. The two non-omapdrm
> changes are:
> - After converting panel-dsi-cm to common DRM panel model, it is moved
>   to drm's panel directory.
> - Add MIPI_DSI_MODE_ULPS_IDLE flag
> 
> I have tested these with OMAP4 SDP, AM5 EVM and OMAP4 Panda. SDP has
> command mode panel, and I don't have any videomode panels.
> 
> Sebastian, I hope you're ok with all this? I did send you an email, but
> didn't get a reply yet, so I thought to just proceed. If you want to
> handle this in some other way, or don't want your
> authorship/signed-off-by in some of the commits, just tell.
> 
>  Tomi
> 
> Sebastian Reichel (51):
>   drm/dsi: add MIPI_DSI_MODE_ULPS_IDLE
>   Revert "drm/omap: dss: Remove unused omap_dss_device operations"
>   drm/omap: drop unused dsi.configure_pins
>   drm/omap: dsi: use MIPI_DSI_FMT_* instead of OMAP_DSS_DSI_FMT_*
>   drm/omap: constify write buffers
>   drm/omap: dsi: add generic transfer function
>   drm/omap: panel-dsi-cm: convert to transfer API
>   drm/omap: dsi: unexport specific data transfer functions
>   drm/omap: dsi: drop virtual channel logic
>   drm/omap: dsi: simplify write function
>   drm/omap: dsi: simplify read functions
>   drm/omap: dsi: switch dsi_vc_send_long/short to mipi_dsi_msg
>   drm/omap: dsi: introduce mipi_dsi_host
>   drm/omap: panel-dsi-cm: use DSI helpers
>   drm/omap: dsi: request VC via mipi_dsi_attach
>   drm/omap: panel-dsi-cm: drop hardcoded VC
>   drm/omap: panel-dsi-cm: use common MIPI DCS 1.3 defines
>   drm/omap: dsi: drop unused memory_read()
>   drm/omap: dsi: drop unused get_te()
>   drm/omap: dsi: drop unused enable_te()
>   drm/omap: dsi: drop useless sync()
>   drm/omap: dsi: use pixel-format and mode from attach
>   drm/omap: panel-dsi-cm: use bulk regulator API
>   drm/omap: dsi: lp/hs switching support for transfer()
>   drm/omap: dsi: move TE GPIO handling into core
>   drm/omap: dsi: drop custom enable_te() API
>   drm/omap: dsi: do bus locking in host driver
>   drm/omap: dsi: untangle ulps ops from enable/disable
>   drm/omap: dsi: do ULPS in host driver
>   drm/omap: dsi: move panel refresh function to host
>   drm/omap: dsi: Reverse direction of the DSS device enable/disable
>     operations
>   drm/omap: dsi: drop custom panel capability support
>   drm/omap: dsi: convert to drm_panel
>   drm/omap: drop omapdss-boot-init
>   drm/omap: dsi: implement check timings
>   drm/omap: panel-dsi-cm: use DEVICE_ATTR_RO
>   drm/omap: panel-dsi-cm: support unbinding
>   drm/omap: panel-dsi-cm: fix remove()
>   drm/omap: remove global dss_device variable
>   drm/panel: Move OMAP's DSI command mode panel driver
>   drm/omap: dsi: Register a drm_bridge
>   drm/omap: remove legacy DSS device operations
>   drm/omap: remove unused omap_connector
>   drm/omap: simplify omap_display_id
>   drm/omap: drop unused DSS next pointer
>   drm/omap: drop empty omap_encoder helper functions
>   drm/omap: drop DSS ops_flags
>   drm/omap: drop dssdev display field
>   drm/omap: simplify DSI manual update code
>   drm/omap: dsi: simplify pin config
>   ARM: omap2plus_defconfig: Update for moved DSI command mode panel
> 
> Tomi Valkeinen (5):
>   drm/omap: squash omapdrm sub-modules into one
>   drm/omap: remove unused display.c
>   drm/omap: drop unused owner field
>   drm/omap: remove dispc_ops
>   drm/omap: remove dss_mgr_ops
> 

Reviewed-by: Nikhil Devshatwar <nikhil.nd@ti.com>

Thanks
Nikhil D

>  arch/arm/configs/omap2plus_defconfig          |    2 +-
>  drivers/gpu/drm/omapdrm/Kconfig               |  120 +-
>  drivers/gpu/drm/omapdrm/Makefile              |   19 +-
>  drivers/gpu/drm/omapdrm/displays/Kconfig      |   10 -
>  drivers/gpu/drm/omapdrm/displays/Makefile     |    2 -
>  .../gpu/drm/omapdrm/displays/panel-dsi-cm.c   | 1385 -----------------
>  drivers/gpu/drm/omapdrm/dss/Kconfig           |  135 --
>  drivers/gpu/drm/omapdrm/dss/Makefile          |   20 -
>  drivers/gpu/drm/omapdrm/dss/base.c            |   87 +-
>  drivers/gpu/drm/omapdrm/dss/dispc.c           |  101 +-
>  drivers/gpu/drm/omapdrm/dss/display.c         |   60 -
>  drivers/gpu/drm/omapdrm/dss/dpi.c             |    1 -
>  drivers/gpu/drm/omapdrm/dss/dsi.c             | 1069 ++++++++-----
>  drivers/gpu/drm/omapdrm/dss/dss.c             |   28 +-
>  drivers/gpu/drm/omapdrm/dss/dss.h             |   72 +-
>  drivers/gpu/drm/omapdrm/dss/hdmi4.c           |    1 -
>  drivers/gpu/drm/omapdrm/dss/hdmi5.c           |    1 -
>  .../gpu/drm/omapdrm/dss/omapdss-boot-init.c   |  229 ---
>  drivers/gpu/drm/omapdrm/dss/omapdss.h         |  278 +---
>  drivers/gpu/drm/omapdrm/dss/output.c          |   57 +-
>  drivers/gpu/drm/omapdrm/dss/sdi.c             |    1 -
>  drivers/gpu/drm/omapdrm/dss/venc.c            |    2 -
>  drivers/gpu/drm/omapdrm/omap_connector.c      |  157 --
>  drivers/gpu/drm/omapdrm/omap_connector.h      |   28 -
>  drivers/gpu/drm/omapdrm/omap_crtc.c           |  103 +-
>  drivers/gpu/drm/omapdrm/omap_crtc.h           |    2 -
>  drivers/gpu/drm/omapdrm/omap_drv.c            |   65 +-
>  drivers/gpu/drm/omapdrm/omap_drv.h            |    3 +-
>  drivers/gpu/drm/omapdrm/omap_encoder.c        |   59 +-
>  drivers/gpu/drm/omapdrm/omap_irq.c            |   34 +-
>  drivers/gpu/drm/omapdrm/omap_plane.c          |   12 +-
>  drivers/gpu/drm/panel/Kconfig                 |    9 +
>  drivers/gpu/drm/panel/Makefile                |    1 +
>  drivers/gpu/drm/panel/panel-dsi-cm.c          |  647 ++++++++
>  include/drm/drm_mipi_dsi.h                    |    2 +
>  35 files changed, 1718 insertions(+), 3084 deletions(-)
>  delete mode 100644 drivers/gpu/drm/omapdrm/displays/Kconfig
>  delete mode 100644 drivers/gpu/drm/omapdrm/displays/Makefile
>  delete mode 100644 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
>  delete mode 100644 drivers/gpu/drm/omapdrm/dss/Kconfig
>  delete mode 100644 drivers/gpu/drm/omapdrm/dss/Makefile
>  delete mode 100644 drivers/gpu/drm/omapdrm/dss/display.c
>  delete mode 100644 drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c
>  delete mode 100644 drivers/gpu/drm/omapdrm/omap_connector.c
>  delete mode 100644 drivers/gpu/drm/omapdrm/omap_connector.h
>  create mode 100644 drivers/gpu/drm/panel/panel-dsi-cm.c
> 
> -- 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>