From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Sebastian Reichel <sre@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Nikhil Devshatwar <nikhil.nd@ti.com>,
Linux-OMAP <linux-omap@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Sekhar Nori <nsekhar@ti.com>, Tony Lindgren <tony@atomide.com>,
Discussions about the Letux Kernel
<letux-kernel@openphoenux.org>
Subject: Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel
Date: Wed, 11 Nov 2020 08:40:15 +0200 [thread overview]
Message-ID: <dd0a41eb-aa86-7c5c-3151-313a0d9d0883@ti.com> (raw)
In-Reply-To: <2265AEF5-42BC-4E7B-B263-D0B93B78DE91@goldelico.com>
On 10/11/2020 23:04, H. Nikolaus Schaller wrote:
>
>> Am 10.11.2020 um 17:52 schrieb Tomi Valkeinen <tomi.valkeinen@ti.com>:
>>
>> On 10/11/2020 18:49, H. Nikolaus Schaller wrote:
>>
>> I guess you have the same issue. It goes to dsi_bridge_mode_valid, then __dsi_calc_config, and stays
>> there finding good clocks.
>
> Yes, I could trace it down to exactly this point.
>
> So the culprit is somehow the panel driver. Because it asks for clocks that the PLL driver does not want to provide...
> Or is it the victim?
>
> Here is what dmesg reports with even more printk():
>
> [ 276.970635] drm_helper_probe_single_connector_modes 12 count=1
> [ 277.003509] drm_mode_validate_pipeline 2 ret=0 status=0
> [ 277.038678] drm_bridge_chain_mode_valid: func=dsi_bridge_mode_valid+0x0/0xa0 [omapdrm]
> [ 277.047199] dsi_bridge_mode_valid
> [ 277.050786] __dsi_calc_config
> [ 277.057270] dsi_vm_calc
> [ 277.073251] dss_pll_calc_a clkin=19200000 pll_min=1555386656 pll_max=1555410656 func=dsi_vm_calc_pll_cb+0x0/0x48 [omapdrm]
> [ 277.084975] dss_pll_calc_a pll_hw_max=1800000000 fint_hw_min=150000 fint_hw_max=52000000
> [ 277.093637] dss_pll_calc_a n_start=1 n_inc=1 n_stop=128 pll_max'=1555410656
> [ 277.101062] dss_pll_calc_a n=1 clkin=19200000 fint=19200000
> [ 277.107152] dss_pll_calc_a m_start=41 m_inc=1 m_stop=40
>
> Ok, we have to wait quite a while until the for(m;;) loop ends, because m_stop < m_start and m_inc is positive.
>
> So something in the formulae in dss_pll_calc_a() does not fit or has unintended rounding effects.
> Or the values reported by w677l_get_modes() do not fit anything.
>
> I think these findings and ideas should help to find a fix.
drm_display_mode.clock is in kHz, but the panel driver writes Hz (w677l_PIXELCLOCK) to it. But
there's more after fixing that. The DSI gets configured in bridge's modeset, which I think is before
w677l_prepare where the panel already sends DSI commands. Also, the dsi driver fails to lock the
PLL, so possibly the clock calcs are still wrong.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-11-11 6:40 UTC|newest]
Thread overview: 164+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 12:02 [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel Tomi Valkeinen
2020-11-05 12:02 ` [PATCH v3 01/56] drm/dsi: add MIPI_DSI_MODE_ULPS_IDLE Tomi Valkeinen
2020-11-06 4:41 ` Laurent Pinchart
2020-11-05 12:02 ` [PATCH v3 02/56] Revert "drm/omap: dss: Remove unused omap_dss_device operations" Tomi Valkeinen
2020-11-05 21:27 ` Sam Ravnborg
2020-11-06 4:50 ` Laurent Pinchart
2020-11-05 12:02 ` [PATCH v3 03/56] drm/omap: drop unused dsi.configure_pins Tomi Valkeinen
2020-11-06 4:50 ` Laurent Pinchart
2020-11-05 12:02 ` [PATCH v3 04/56] drm/omap: dsi: use MIPI_DSI_FMT_* instead of OMAP_DSS_DSI_FMT_* Tomi Valkeinen
2020-11-06 4:56 ` Laurent Pinchart
2020-11-05 12:02 ` [PATCH v3 05/56] drm/omap: constify write buffers Tomi Valkeinen
2020-11-06 4:57 ` Laurent Pinchart
2020-11-05 12:02 ` [PATCH v3 06/56] drm/omap: dsi: add generic transfer function Tomi Valkeinen
2020-11-06 5:05 ` Laurent Pinchart
2020-11-05 12:02 ` [PATCH v3 07/56] drm/omap: panel-dsi-cm: convert to transfer API Tomi Valkeinen
2020-11-06 5:08 ` Laurent Pinchart
2020-11-05 12:02 ` [PATCH v3 08/56] drm/omap: dsi: unexport specific data transfer functions Tomi Valkeinen
2020-11-09 8:10 ` Laurent Pinchart
2020-11-05 12:02 ` [PATCH v3 09/56] drm/omap: dsi: drop virtual channel logic Tomi Valkeinen
2020-11-09 8:14 ` Laurent Pinchart
2020-11-09 8:20 ` Tomi Valkeinen
2020-11-09 8:18 ` Tomi Valkeinen
2020-11-05 12:02 ` [PATCH v3 10/56] drm/omap: dsi: simplify write function Tomi Valkeinen
2020-11-09 8:21 ` Laurent Pinchart
2020-11-05 12:02 ` [PATCH v3 11/56] drm/omap: dsi: simplify read functions Tomi Valkeinen
2020-11-09 8:28 ` Laurent Pinchart
2020-11-05 12:02 ` [PATCH v3 12/56] drm/omap: dsi: switch dsi_vc_send_long/short to mipi_dsi_msg Tomi Valkeinen
2020-11-09 8:33 ` Laurent Pinchart
2020-11-05 12:02 ` [PATCH v3 13/56] drm/omap: dsi: introduce mipi_dsi_host Tomi Valkeinen
2020-11-09 8:38 ` Laurent Pinchart
2020-11-05 12:02 ` [PATCH v3 14/56] drm/omap: panel-dsi-cm: use DSI helpers Tomi Valkeinen
2020-11-09 8:40 ` Laurent Pinchart
2020-11-05 12:02 ` [PATCH v3 15/56] drm/omap: dsi: request VC via mipi_dsi_attach Tomi Valkeinen
2020-11-09 8:42 ` Laurent Pinchart
2020-11-09 11:16 ` Tomi Valkeinen
2020-11-05 12:02 ` [PATCH v3 16/56] drm/omap: panel-dsi-cm: drop hardcoded VC Tomi Valkeinen
2020-11-09 8:43 ` Laurent Pinchart
2020-11-05 12:02 ` [PATCH v3 17/56] drm/omap: panel-dsi-cm: use common MIPI DCS 1.3 defines Tomi Valkeinen
2020-11-09 8:44 ` Laurent Pinchart
2020-11-05 12:02 ` [PATCH v3 18/56] drm/omap: dsi: drop unused memory_read() Tomi Valkeinen
2020-11-09 8:45 ` Laurent Pinchart
2020-11-05 12:02 ` [PATCH v3 19/56] drm/omap: dsi: drop unused get_te() Tomi Valkeinen
2020-11-09 8:45 ` Laurent Pinchart
2020-11-09 9:49 ` Tomi Valkeinen
2020-11-05 12:02 ` [PATCH v3 20/56] drm/omap: dsi: drop unused enable_te() Tomi Valkeinen
2020-11-09 8:46 ` Laurent Pinchart
2020-11-05 12:02 ` [PATCH v3 21/56] drm/omap: dsi: drop useless sync() Tomi Valkeinen
2020-11-09 8:46 ` Laurent Pinchart
2020-11-05 12:02 ` [PATCH v3 22/56] drm/omap: dsi: use pixel-format and mode from attach Tomi Valkeinen
2020-11-09 8:49 ` Laurent Pinchart
2020-11-09 9:45 ` Tomi Valkeinen
2020-11-05 12:03 ` [PATCH v3 23/56] drm/omap: panel-dsi-cm: use bulk regulator API Tomi Valkeinen
2020-11-09 8:51 ` Laurent Pinchart
2020-11-05 12:03 ` [PATCH v3 24/56] drm/omap: dsi: lp/hs switching support for transfer() Tomi Valkeinen
2020-11-09 8:53 ` Laurent Pinchart
2020-11-05 12:03 ` [PATCH v3 25/56] drm/omap: dsi: move TE GPIO handling into core Tomi Valkeinen
2020-11-09 9:19 ` Laurent Pinchart
2020-11-11 13:26 ` Tomi Valkeinen
2020-11-05 12:03 ` [PATCH v3 26/56] drm/omap: dsi: drop custom enable_te() API Tomi Valkeinen
2020-11-09 9:32 ` Laurent Pinchart
2020-11-05 12:03 ` [PATCH v3 27/56] drm/omap: dsi: do bus locking in host driver Tomi Valkeinen
2020-11-09 9:52 ` Laurent Pinchart
2020-11-09 10:08 ` Tomi Valkeinen
2020-11-09 13:27 ` Sebastian Reichel
2020-11-09 14:25 ` Tomi Valkeinen
2020-11-11 13:35 ` Tomi Valkeinen
2020-11-05 12:03 ` [PATCH v3 28/56] drm/omap: dsi: untangle ulps ops from enable/disable Tomi Valkeinen
2020-11-09 9:57 ` Laurent Pinchart
2020-11-11 14:05 ` Tomi Valkeinen
2020-11-05 12:03 ` [PATCH v3 29/56] drm/omap: dsi: do ULPS in host driver Tomi Valkeinen
2020-11-09 10:03 ` Laurent Pinchart
2020-11-11 15:29 ` Tomi Valkeinen
2020-11-05 12:03 ` [PATCH v3 30/56] drm/omap: dsi: move panel refresh function to host Tomi Valkeinen
2020-11-09 10:10 ` Laurent Pinchart
2020-11-11 15:34 ` Tomi Valkeinen
2020-11-11 15:58 ` Laurent Pinchart
2020-11-12 8:08 ` Tomi Valkeinen
2020-11-16 9:22 ` Laurent Pinchart
2020-11-17 10:04 ` Sebastian Reichel
2020-11-05 12:03 ` [PATCH v3 31/56] drm/omap: dsi: Reverse direction of the DSS device enable/disable operations Tomi Valkeinen
2020-11-09 10:17 ` Laurent Pinchart
2020-11-05 12:03 ` [PATCH v3 32/56] drm/omap: dsi: drop custom panel capability support Tomi Valkeinen
2020-11-09 10:20 ` Laurent Pinchart
2020-11-05 12:03 ` [PATCH v3 33/56] drm/omap: dsi: convert to drm_panel Tomi Valkeinen
2020-11-09 10:39 ` Laurent Pinchart
2020-11-11 15:54 ` Tomi Valkeinen
2020-11-05 12:03 ` [PATCH v3 34/56] drm/omap: drop omapdss-boot-init Tomi Valkeinen
2020-11-09 10:40 ` Laurent Pinchart
2020-11-05 12:03 ` [PATCH v3 35/56] drm/omap: dsi: implement check timings Tomi Valkeinen
2020-11-09 10:47 ` Laurent Pinchart
2020-11-11 12:36 ` Tomi Valkeinen
2020-11-05 12:03 ` [PATCH v3 36/56] drm/omap: panel-dsi-cm: use DEVICE_ATTR_RO Tomi Valkeinen
2020-11-09 10:48 ` Laurent Pinchart
2020-11-05 12:03 ` [PATCH v3 37/56] drm/omap: panel-dsi-cm: support unbinding Tomi Valkeinen
2020-11-09 10:49 ` Laurent Pinchart
2020-11-11 12:03 ` Tomi Valkeinen
2020-11-05 12:03 ` [PATCH v3 38/56] drm/omap: panel-dsi-cm: fix remove() Tomi Valkeinen
2020-11-09 10:50 ` Laurent Pinchart
2020-11-05 12:03 ` [PATCH v3 39/56] drm/omap: remove global dss_device variable Tomi Valkeinen
2020-11-09 10:51 ` Laurent Pinchart
2020-11-05 12:03 ` [PATCH v3 40/56] drm/panel: Move OMAP's DSI command mode panel driver Tomi Valkeinen
2020-11-05 15:16 ` Sam Ravnborg
2020-11-05 15:27 ` Tomi Valkeinen
2020-11-09 10:53 ` Laurent Pinchart
2020-11-05 12:03 ` [PATCH v3 41/56] drm/omap: dsi: Register a drm_bridge Tomi Valkeinen
2020-11-09 10:54 ` Laurent Pinchart
2020-11-05 12:03 ` [PATCH v3 42/56] drm/omap: remove legacy DSS device operations Tomi Valkeinen
2020-11-09 11:01 ` Laurent Pinchart
2020-11-05 12:03 ` [PATCH v3 43/56] drm/omap: remove unused omap_connector Tomi Valkeinen
2020-11-09 11:02 ` Laurent Pinchart
2020-11-05 12:03 ` [PATCH v3 44/56] drm/omap: simplify omap_display_id Tomi Valkeinen
2020-11-09 11:03 ` Laurent Pinchart
2020-11-05 12:03 ` [PATCH v3 45/56] drm/omap: drop unused DSS next pointer Tomi Valkeinen
2020-11-09 11:04 ` Laurent Pinchart
2020-11-05 12:03 ` [PATCH v3 46/56] drm/omap: drop empty omap_encoder helper functions Tomi Valkeinen
2020-11-09 11:05 ` Laurent Pinchart
2020-11-05 12:03 ` [PATCH v3 47/56] drm/omap: drop DSS ops_flags Tomi Valkeinen
2020-11-09 11:05 ` Laurent Pinchart
2020-11-05 12:03 ` [PATCH v3 48/56] drm/omap: drop dssdev display field Tomi Valkeinen
2020-11-09 11:06 ` Laurent Pinchart
2020-11-05 12:03 ` [PATCH v3 49/56] drm/omap: simplify DSI manual update code Tomi Valkeinen
2020-11-09 11:07 ` Laurent Pinchart
2020-11-05 12:03 ` [PATCH v3 50/56] drm/omap: dsi: simplify pin config Tomi Valkeinen
2020-11-09 11:09 ` Laurent Pinchart
2020-11-11 12:24 ` Tomi Valkeinen
2020-11-05 12:03 ` [PATCH v3 51/56] ARM: omap2plus_defconfig: Update for moved DSI command mode panel Tomi Valkeinen
2020-11-09 11:10 ` Laurent Pinchart
2020-11-05 12:03 ` [PATCH v3 52/56] drm/omap: squash omapdrm sub-modules into one Tomi Valkeinen
2020-11-09 11:15 ` Laurent Pinchart
2020-11-05 12:03 ` [PATCH v3 53/56] drm/omap: remove unused display.c Tomi Valkeinen
2020-11-09 11:16 ` Laurent Pinchart
2020-11-05 12:03 ` [PATCH v3 54/56] drm/omap: drop unused owner field Tomi Valkeinen
2020-11-09 11:16 ` Laurent Pinchart
2020-11-05 12:03 ` [PATCH v3 55/56] drm/omap: remove dispc_ops Tomi Valkeinen
2020-11-09 11:17 ` Laurent Pinchart
2020-11-05 12:03 ` [PATCH v3 56/56] drm/omap: remove dss_mgr_ops Tomi Valkeinen
2020-11-09 11:18 ` Laurent Pinchart
2020-11-05 17:15 ` [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel H. Nikolaus Schaller
2020-11-05 17:36 ` Tomi Valkeinen
2020-11-05 18:14 ` H. Nikolaus Schaller
2020-11-05 18:28 ` Tomi Valkeinen
2020-11-05 18:56 ` H. Nikolaus Schaller
2020-11-06 14:37 ` Tomi Valkeinen
2020-11-06 15:04 ` Tomi Valkeinen
2020-11-07 12:19 ` H. Nikolaus Schaller
2020-11-09 8:04 ` Tomi Valkeinen
2020-11-09 9:30 ` H. Nikolaus Schaller
2020-11-09 10:22 ` Tomi Valkeinen
2020-11-09 10:31 ` H. Nikolaus Schaller
2020-11-09 10:34 ` Tomi Valkeinen
2020-11-09 11:09 ` H. Nikolaus Schaller
2020-11-09 11:33 ` Tomi Valkeinen
2020-11-10 13:49 ` H. Nikolaus Schaller
2020-11-10 15:25 ` Tomi Valkeinen
2020-11-10 16:49 ` H. Nikolaus Schaller
2020-11-10 16:52 ` Tomi Valkeinen
2020-11-10 21:04 ` H. Nikolaus Schaller
2020-11-11 6:40 ` Tomi Valkeinen [this message]
2020-11-11 7:48 ` H. Nikolaus Schaller
2020-11-11 10:11 ` Tomi Valkeinen
2020-11-11 19:27 ` H. Nikolaus Schaller
2020-11-05 21:31 ` Sam Ravnborg
2020-11-08 16:33 ` Nikhil Devshatwar
[not found] ` <BAFBC885-9BBE-46D1-B4C4-79910705864A@goldelico.com>
[not found] ` <74abbdc4-cc1e-9caf-d4ee-0a5cdb557643@ti.com>
[not found] ` <b0677958-02ad-1d2f-d755-! 25a9d384eddc@ti.com>
[not found] ` <1A09B4DA-F726-4F37-8CF4-BC192C659950@goldelico.com>
[not found] ` <9a4e373e-9092-6d82-937a-bc663d2376b4@ti.com>
[not found] ` <09ebc3e3-72c7-41fb-fb21-bf28c! f883d3f@ti.com>
[not found] ` <E738362A-8ECE-4ED5-8057-2ABB6F5C3056@goldelico.com>
[not found] ` <9a21b475-eff0-9882-8d65-d1f! dd2139dc4@ti.com>
[not found] ` <A1DEB54D-FEC0-493A-858C-E5C0DB24B35E@goldelico.com>
[not found] ` <1150ba22-1ae2-39f3-0924-7! a1f1b468597@ti.com>
[not found] ` <2999ED77-B9F7-4197-81B8-F1AFF329A1E9@goldelico.com>
[not found] ` <cbc147d2-af41-2bed-5670-530d45cfb24e@ti.com>
[not found] ` <106bfbee-c472-c04c-0f7b-db108a090a63@ti.com>
[not found] ` <420b81bd-fc95-e294-fcbe-f34db1ef! f9e7@ti.c om>
[not found] ` <B2FBCAE4-FAD9-4C0D-9C75-63A701215886@goldelico.com>
[not found] ` <826B2E97-8B77-412A-8093-753BF7A65EE1@goldelico.com>
[not found] ` <acad2006-53a2-6587-b8e6-787e358! 8932a@ti.com>
[not found] ` <AF87C7B4-DCD2-4207-A300-567DB65B08ED@goldelico.com>
[not found] ` <27cfb13a-62e3-0a53-153f-92641c437cee@ti. com>
[not found] ` <27cfb13a-62e3-0a53-153f-92641c437cee@ti.com>
2020-11-16 9:16 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd0a41eb-aa86-7c5c-3151-313a0d9d0883@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hns@goldelico.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-omap@vger.kernel.org \
--cc=nikhil.nd@ti.com \
--cc=nsekhar@ti.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).