From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Tony Lindgren <tony@atomide.com>
Cc: kernel@pyra-handheld.com,
Discussions about the Letux Kernel
<letux-kernel@openphoenux.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-OMAP <linux-omap@vger.kernel.org>
Subject: Re: [Letux-kernel] [PATCH] omap5: Fix DSI base address and clocks
Date: Tue, 18 Aug 2020 11:58:47 +0200 [thread overview]
Message-ID: <9081697A-02F9-42EA-9F22-F62381FA1C79@goldelico.com> (raw)
In-Reply-To: <20200818095100.25412-1-dave@ds0.me>
> Am 18.08.2020 um 11:51 schrieb David Shah <dave@ds0.me>:
>
> DSI was not probing due to base address off by 0x1000, and sys_clk
> missing.
>
> With this patch, the Pyra display works if HDMI is disabled in the
> device tree.
For me it also works if HDMI is not disabled.
So IMHO this comment is misleading.
Otherwise,
Tested-by: H. Nikolaus Schaller <hns@goldelico.com>
>
> Signed-off-by: David Shah <dave@ds0.me>
> ---
> arch/arm/boot/dts/omap5.dtsi | 20 +++++++++++---------
> 1 file changed, 11 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> index c96e19a15c52..849a2dd9fef7 100644
> --- a/arch/arm/boot/dts/omap5.dtsi
> +++ b/arch/arm/boot/dts/omap5.dtsi
> @@ -388,11 +388,11 @@ rfbi: encoder@0 {
> };
> };
>
> - target-module@5000 {
> + target-module@4000 {
> compatible = "ti,sysc-omap2", "ti,sysc";
> - reg = <0x5000 0x4>,
> - <0x5010 0x4>,
> - <0x5014 0x4>;
> + reg = <0x4000 0x4>,
> + <0x4010 0x4>,
> + <0x4014 0x4>;
> reg-names = "rev", "sysc", "syss";
> ti,sysc-sidle = <SYSC_IDLE_FORCE>,
> <SYSC_IDLE_NO>,
> @@ -404,7 +404,7 @@ SYSC_OMAP2_SOFTRESET |
> ti,syss-mask = <1>;
> #address-cells = <1>;
> #size-cells = <1>;
> - ranges = <0 0x5000 0x1000>;
> + ranges = <0 0x4000 0x1000>;
>
> dsi1: encoder@0 {
> compatible = "ti,omap5-dsi";
> @@ -414,8 +414,9 @@ dsi1: encoder@0 {
> reg-names = "proto", "phy", "pll";
> interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
> status = "disabled";
> - clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>;
> - clock-names = "fck";
> + clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>,
> + <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 10>;
> + clock-names = "fck", "sys_clk";
> };
> };
>
> @@ -445,8 +446,9 @@ dsi2: encoder@0 {
> reg-names = "proto", "phy", "pll";
> interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
> status = "disabled";
> - clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>;
> - clock-names = "fck";
> + clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>,
> + <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 10>;
> + clock-names = "fck", "sys_clk";
> };
> };
>
> --
> 2.28.0
>
> _______________________________________________
> https://projects.goldelico.com/p/gta04-kernel/
> Letux-kernel mailing list
> Letux-kernel@openphoenux.org
> http://lists.goldelico.com/mailman/listinfo.cgi/letux-kernel
next prev parent reply other threads:[~2020-08-18 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 9:51 [PATCH] omap5: Fix DSI base address and clocks David Shah
2020-08-18 9:58 ` H. Nikolaus Schaller [this message]
2020-08-19 5:58 ` [Letux-kernel] " Tony Lindgren
2020-08-19 8:39 ` David Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9081697A-02F9-42EA-9F22-F62381FA1C79@goldelico.com \
--to=hns@goldelico.com \
--cc=kernel@pyra-handheld.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).