* [PATCH] omap5: Fix DSI base address and clocks
@ 2020-08-18 9:51 David Shah
2020-08-18 9:58 ` [Letux-kernel] " H. Nikolaus Schaller
0 siblings, 1 reply; 4+ messages in thread
From: David Shah @ 2020-08-18 9:51 UTC (permalink / raw)
To: letux-kernel, kernel, linux-omap, tony
DSI was not probing due to base address off by 0x1000, and sys_clk
missing.
With this patch, the Pyra display works if HDMI is disabled in the
device tree.
Signed-off-by: David Shah <dave@ds0.me>
---
arch/arm/boot/dts/omap5.dtsi | 20 +++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
index c96e19a15c52..849a2dd9fef7 100644
--- a/arch/arm/boot/dts/omap5.dtsi
+++ b/arch/arm/boot/dts/omap5.dtsi
@@ -388,11 +388,11 @@ rfbi: encoder@0 {
};
};
- target-module@5000 {
+ target-module@4000 {
compatible = "ti,sysc-omap2", "ti,sysc";
- reg = <0x5000 0x4>,
- <0x5010 0x4>,
- <0x5014 0x4>;
+ reg = <0x4000 0x4>,
+ <0x4010 0x4>,
+ <0x4014 0x4>;
reg-names = "rev", "sysc", "syss";
ti,sysc-sidle = <SYSC_IDLE_FORCE>,
<SYSC_IDLE_NO>,
@@ -404,7 +404,7 @@ SYSC_OMAP2_SOFTRESET |
ti,syss-mask = <1>;
#address-cells = <1>;
#size-cells = <1>;
- ranges = <0 0x5000 0x1000>;
+ ranges = <0 0x4000 0x1000>;
dsi1: encoder@0 {
compatible = "ti,omap5-dsi";
@@ -414,8 +414,9 @@ dsi1: encoder@0 {
reg-names = "proto", "phy", "pll";
interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
status = "disabled";
- clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>;
- clock-names = "fck";
+ clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>,
+ <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 10>;
+ clock-names = "fck", "sys_clk";
};
};
@@ -445,8 +446,9 @@ dsi2: encoder@0 {
reg-names = "proto", "phy", "pll";
interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
status = "disabled";
- clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>;
- clock-names = "fck";
+ clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>,
+ <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 10>;
+ clock-names = "fck", "sys_clk";
};
};
--
2.28.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Letux-kernel] [PATCH] omap5: Fix DSI base address and clocks
2020-08-18 9:51 [PATCH] omap5: Fix DSI base address and clocks David Shah
@ 2020-08-18 9:58 ` H. Nikolaus Schaller
2020-08-19 5:58 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: H. Nikolaus Schaller @ 2020-08-18 9:58 UTC (permalink / raw)
To: Tony Lindgren
Cc: kernel, Discussions about the Letux Kernel,
Linux Kernel Mailing List, Linux-OMAP
> Am 18.08.2020 um 11:51 schrieb David Shah <dave@ds0.me>:
>
> DSI was not probing due to base address off by 0x1000, and sys_clk
> missing.
>
> With this patch, the Pyra display works if HDMI is disabled in the
> device tree.
For me it also works if HDMI is not disabled.
So IMHO this comment is misleading.
Otherwise,
Tested-by: H. Nikolaus Schaller <hns@goldelico.com>
>
> Signed-off-by: David Shah <dave@ds0.me>
> ---
> arch/arm/boot/dts/omap5.dtsi | 20 +++++++++++---------
> 1 file changed, 11 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> index c96e19a15c52..849a2dd9fef7 100644
> --- a/arch/arm/boot/dts/omap5.dtsi
> +++ b/arch/arm/boot/dts/omap5.dtsi
> @@ -388,11 +388,11 @@ rfbi: encoder@0 {
> };
> };
>
> - target-module@5000 {
> + target-module@4000 {
> compatible = "ti,sysc-omap2", "ti,sysc";
> - reg = <0x5000 0x4>,
> - <0x5010 0x4>,
> - <0x5014 0x4>;
> + reg = <0x4000 0x4>,
> + <0x4010 0x4>,
> + <0x4014 0x4>;
> reg-names = "rev", "sysc", "syss";
> ti,sysc-sidle = <SYSC_IDLE_FORCE>,
> <SYSC_IDLE_NO>,
> @@ -404,7 +404,7 @@ SYSC_OMAP2_SOFTRESET |
> ti,syss-mask = <1>;
> #address-cells = <1>;
> #size-cells = <1>;
> - ranges = <0 0x5000 0x1000>;
> + ranges = <0 0x4000 0x1000>;
>
> dsi1: encoder@0 {
> compatible = "ti,omap5-dsi";
> @@ -414,8 +414,9 @@ dsi1: encoder@0 {
> reg-names = "proto", "phy", "pll";
> interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
> status = "disabled";
> - clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>;
> - clock-names = "fck";
> + clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>,
> + <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 10>;
> + clock-names = "fck", "sys_clk";
> };
> };
>
> @@ -445,8 +446,9 @@ dsi2: encoder@0 {
> reg-names = "proto", "phy", "pll";
> interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
> status = "disabled";
> - clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>;
> - clock-names = "fck";
> + clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>,
> + <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 10>;
> + clock-names = "fck", "sys_clk";
> };
> };
>
> --
> 2.28.0
>
> _______________________________________________
> https://projects.goldelico.com/p/gta04-kernel/
> Letux-kernel mailing list
> Letux-kernel@openphoenux.org
> http://lists.goldelico.com/mailman/listinfo.cgi/letux-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Letux-kernel] [PATCH] omap5: Fix DSI base address and clocks
2020-08-18 9:58 ` [Letux-kernel] " H. Nikolaus Schaller
@ 2020-08-19 5:58 ` Tony Lindgren
2020-08-19 8:39 ` David Shah
0 siblings, 1 reply; 4+ messages in thread
From: Tony Lindgren @ 2020-08-19 5:58 UTC (permalink / raw)
To: H. Nikolaus Schaller
Cc: kernel, Discussions about the Letux Kernel,
Linux Kernel Mailing List, Linux-OMAP
* H. Nikolaus Schaller <hns@goldelico.com> [200818 09:58]:
>
> > Am 18.08.2020 um 11:51 schrieb David Shah <dave@ds0.me>:
> >
> > DSI was not probing due to base address off by 0x1000, and sys_clk
> > missing.
> >
> > With this patch, the Pyra display works if HDMI is disabled in the
> > device tree.
>
> For me it also works if HDMI is not disabled.
> So IMHO this comment is misleading.
>
> Otherwise,
>
> Tested-by: H. Nikolaus Schaller <hns@goldelico.com>
Thanks pushed out into fixes. Looks like I missed removing the
HDMI disabled comment part but seems like that's not critical
and don't want to redo the branch after pushing out.
Regards,
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Letux-kernel] [PATCH] omap5: Fix DSI base address and clocks
2020-08-19 5:58 ` Tony Lindgren
@ 2020-08-19 8:39 ` David Shah
0 siblings, 0 replies; 4+ messages in thread
From: David Shah @ 2020-08-19 8:39 UTC (permalink / raw)
To: Discussions about the Letux Kernel, H. Nikolaus Schaller
Cc: Linux-OMAP, Linux Kernel Mailing List, kernel
In any case the HDMI bug has reappeared while testing 5.9-rc1, although
I can get the display to work by doing 'modprobe omapdrm' even if HDMI
is enabled (as before it loads automatically if HDMI is disabled).
Best
David
On Wed, 2020-08-19 at 08:58 +0300, Tony Lindgren wrote:
> * H. Nikolaus Schaller <hns@goldelico.com> [200818 09:58]:
> > > Am 18.08.2020 um 11:51 schrieb David Shah <dave@ds0.me>:
> > >
> > > DSI was not probing due to base address off by 0x1000, and
> > > sys_clk
> > > missing.
> > >
> > > With this patch, the Pyra display works if HDMI is disabled in
> > > the
> > > device tree.
> >
> > For me it also works if HDMI is not disabled.
> > So IMHO this comment is misleading.
> >
> > Otherwise,
> >
> > Tested-by: H. Nikolaus Schaller <hns@goldelico.com>
>
> Thanks pushed out into fixes. Looks like I missed removing the
> HDMI disabled comment part but seems like that's not critical
> and don't want to redo the branch after pushing out.
>
> Regards,
>
> Tony
> _______________________________________________
> https://projects.goldelico.com/p/gta04-kernel/
> Letux-kernel mailing list
> Letux-kernel@openphoenux.org
> http://lists.goldelico.com/mailman/listinfo.cgi/letux-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-19 8:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-18 9:51 [PATCH] omap5: Fix DSI base address and clocks David Shah
2020-08-18 9:58 ` [Letux-kernel] " H. Nikolaus Schaller
2020-08-19 5:58 ` Tony Lindgren
2020-08-19 8:39 ` David Shah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).