Linux-parisc archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] net: tulip: Adjust indentation in {dmfe,uli526x}_init_module
@ 2019-12-09 21:16 Nathan Chancellor
  2019-12-09 21:22 ` Nick Desaulniers
  2019-12-10  4:29 ` David Miller
  0 siblings, 2 replies; 4+ messages in thread
From: Nathan Chancellor @ 2019-12-09 21:16 UTC (permalink / raw)
  To: David S. Miller
  Cc: netdev, linux-parisc, linux-kernel, clang-built-linux, Nathan Chancellor

Clang warns:

../drivers/net/ethernet/dec/tulip/uli526x.c:1812:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
        switch (mode) {
        ^
../drivers/net/ethernet/dec/tulip/uli526x.c:1809:2: note: previous
statement is here
        if (cr6set)
        ^
1 warning generated.

../drivers/net/ethernet/dec/tulip/dmfe.c:2217:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
        switch(mode) {
        ^
../drivers/net/ethernet/dec/tulip/dmfe.c:2214:2: note: previous
statement is here
        if (cr6set)
        ^
1 warning generated.

This warning occurs because there is a space before the tab on these
lines. Remove them so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

While we are here, adjust the default block in dmfe_init_module to have
a proper break between the label and assignment and add a space between
the switch and opening parentheses to avoid a checkpatch warning.

Fixes: e1c3e5014040 ("[PATCH] initialisation cleanup for ULI526x-net-driver")
Link: https://github.com/ClangBuiltLinux/linux/issues/795
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
 drivers/net/ethernet/dec/tulip/dmfe.c    | 7 ++++---
 drivers/net/ethernet/dec/tulip/uli526x.c | 4 ++--
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/dec/tulip/dmfe.c b/drivers/net/ethernet/dec/tulip/dmfe.c
index 0efdbd1a4a6f..32d470d4122a 100644
--- a/drivers/net/ethernet/dec/tulip/dmfe.c
+++ b/drivers/net/ethernet/dec/tulip/dmfe.c
@@ -2214,15 +2214,16 @@ static int __init dmfe_init_module(void)
 	if (cr6set)
 		dmfe_cr6_user_set = cr6set;
 
- 	switch(mode) {
-   	case DMFE_10MHF:
+	switch (mode) {
+	case DMFE_10MHF:
 	case DMFE_100MHF:
 	case DMFE_10MFD:
 	case DMFE_100MFD:
 	case DMFE_1M_HPNA:
 		dmfe_media_mode = mode;
 		break;
-	default:dmfe_media_mode = DMFE_AUTO;
+	default:
+		dmfe_media_mode = DMFE_AUTO;
 		break;
 	}
 
diff --git a/drivers/net/ethernet/dec/tulip/uli526x.c b/drivers/net/ethernet/dec/tulip/uli526x.c
index b1f30b194300..117ffe08800d 100644
--- a/drivers/net/ethernet/dec/tulip/uli526x.c
+++ b/drivers/net/ethernet/dec/tulip/uli526x.c
@@ -1809,8 +1809,8 @@ static int __init uli526x_init_module(void)
 	if (cr6set)
 		uli526x_cr6_user_set = cr6set;
 
- 	switch (mode) {
-   	case ULI526X_10MHF:
+	switch (mode) {
+	case ULI526X_10MHF:
 	case ULI526X_100MHF:
 	case ULI526X_10MFD:
 	case ULI526X_100MFD:
-- 
2.24.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] net: tulip: Adjust indentation in {dmfe,uli526x}_init_module
  2019-12-09 21:16 [PATCH] net: tulip: Adjust indentation in {dmfe,uli526x}_init_module Nathan Chancellor
@ 2019-12-09 21:22 ` Nick Desaulniers
  2019-12-10  4:29 ` David Miller
  1 sibling, 0 replies; 4+ messages in thread
From: Nick Desaulniers @ 2019-12-09 21:22 UTC (permalink / raw)
  To: Nathan Chancellor
  Cc: David S. Miller, Network Development, linux-parisc, LKML,
	clang-built-linux

On Mon, Dec 9, 2019 at 1:16 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> Clang warns:
>
> ../drivers/net/ethernet/dec/tulip/uli526x.c:1812:3: warning: misleading
> indentation; statement is not part of the previous 'if'
> [-Wmisleading-indentation]
>         switch (mode) {
>         ^
> ../drivers/net/ethernet/dec/tulip/uli526x.c:1809:2: note: previous
> statement is here
>         if (cr6set)
>         ^
> 1 warning generated.
>
> ../drivers/net/ethernet/dec/tulip/dmfe.c:2217:3: warning: misleading
> indentation; statement is not part of the previous 'if'
> [-Wmisleading-indentation]
>         switch(mode) {
>         ^
> ../drivers/net/ethernet/dec/tulip/dmfe.c:2214:2: note: previous
> statement is here
>         if (cr6set)
>         ^
> 1 warning generated.
>
> This warning occurs because there is a space before the tab on these
> lines. Remove them so that the indentation is consistent with the Linux
> kernel coding style and clang no longer warns.
>
> While we are here, adjust the default block in dmfe_init_module to have
> a proper break between the label and assignment and add a space between
> the switch and opening parentheses to avoid a checkpatch warning.
>
> Fixes: e1c3e5014040 ("[PATCH] initialisation cleanup for ULI526x-net-driver")
> Link: https://github.com/ClangBuiltLinux/linux/issues/795
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>

/^ \t
in vim turns up a few more cases that I think should be fixed (in both files)

> ---
>  drivers/net/ethernet/dec/tulip/dmfe.c    | 7 ++++---
>  drivers/net/ethernet/dec/tulip/uli526x.c | 4 ++--
>  2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/dec/tulip/dmfe.c b/drivers/net/ethernet/dec/tulip/dmfe.c
> index 0efdbd1a4a6f..32d470d4122a 100644
> --- a/drivers/net/ethernet/dec/tulip/dmfe.c
> +++ b/drivers/net/ethernet/dec/tulip/dmfe.c
> @@ -2214,15 +2214,16 @@ static int __init dmfe_init_module(void)
>         if (cr6set)
>                 dmfe_cr6_user_set = cr6set;
>
> -       switch(mode) {
> -       case DMFE_10MHF:
> +       switch (mode) {
> +       case DMFE_10MHF:
>         case DMFE_100MHF:
>         case DMFE_10MFD:
>         case DMFE_100MFD:
>         case DMFE_1M_HPNA:
>                 dmfe_media_mode = mode;
>                 break;
> -       default:dmfe_media_mode = DMFE_AUTO;
> +       default:
> +               dmfe_media_mode = DMFE_AUTO;
>                 break;
>         }
>
> diff --git a/drivers/net/ethernet/dec/tulip/uli526x.c b/drivers/net/ethernet/dec/tulip/uli526x.c
> index b1f30b194300..117ffe08800d 100644
> --- a/drivers/net/ethernet/dec/tulip/uli526x.c
> +++ b/drivers/net/ethernet/dec/tulip/uli526x.c
> @@ -1809,8 +1809,8 @@ static int __init uli526x_init_module(void)
>         if (cr6set)
>                 uli526x_cr6_user_set = cr6set;
>
> -       switch (mode) {
> -       case ULI526X_10MHF:
> +       switch (mode) {
> +       case ULI526X_10MHF:
>         case ULI526X_100MHF:
>         case ULI526X_10MFD:
>         case ULI526X_100MFD:
> --
> 2.24.0
>
> --
> You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20191209211623.44166-1-natechancellor%40gmail.com.



-- 
Thanks,
~Nick Desaulniers

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] net: tulip: Adjust indentation in {dmfe,uli526x}_init_module
  2019-12-09 21:16 [PATCH] net: tulip: Adjust indentation in {dmfe,uli526x}_init_module Nathan Chancellor
  2019-12-09 21:22 ` Nick Desaulniers
@ 2019-12-10  4:29 ` David Miller
  2019-12-10 19:41   ` Nathan Chancellor
  1 sibling, 1 reply; 4+ messages in thread
From: David Miller @ 2019-12-10  4:29 UTC (permalink / raw)
  To: natechancellor; +Cc: netdev, linux-parisc, linux-kernel, clang-built-linux

From: Nathan Chancellor <natechancellor@gmail.com>
Date: Mon,  9 Dec 2019 14:16:23 -0700

> Clang warns:
> 
> ../drivers/net/ethernet/dec/tulip/uli526x.c:1812:3: warning: misleading
> indentation; statement is not part of the previous 'if'
> [-Wmisleading-indentation]
>         switch (mode) {
>         ^
> ../drivers/net/ethernet/dec/tulip/uli526x.c:1809:2: note: previous
> statement is here
>         if (cr6set)
>         ^
> 1 warning generated.
> 
> ../drivers/net/ethernet/dec/tulip/dmfe.c:2217:3: warning: misleading
> indentation; statement is not part of the previous 'if'
> [-Wmisleading-indentation]
>         switch(mode) {
>         ^
> ../drivers/net/ethernet/dec/tulip/dmfe.c:2214:2: note: previous
> statement is here
>         if (cr6set)
>         ^
> 1 warning generated.
> 
> This warning occurs because there is a space before the tab on these
> lines. Remove them so that the indentation is consistent with the Linux
> kernel coding style and clang no longer warns.
> 
> While we are here, adjust the default block in dmfe_init_module to have
> a proper break between the label and assignment and add a space between
> the switch and opening parentheses to avoid a checkpatch warning.
> 
> Fixes: e1c3e5014040 ("[PATCH] initialisation cleanup for ULI526x-net-driver")
> Link: https://github.com/ClangBuiltLinux/linux/issues/795
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>

Applied, but it's really crummy that the tool gets tripped up by the
fact that a space preceeds the TAB.  It's what the code visually looks
like, not what exact kinds of SPACE characters were used to get there.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] net: tulip: Adjust indentation in {dmfe,uli526x}_init_module
  2019-12-10  4:29 ` David Miller
@ 2019-12-10 19:41   ` Nathan Chancellor
  0 siblings, 0 replies; 4+ messages in thread
From: Nathan Chancellor @ 2019-12-10 19:41 UTC (permalink / raw)
  To: David Miller; +Cc: netdev, linux-parisc, linux-kernel, clang-built-linux

On Mon, Dec 09, 2019 at 08:29:20PM -0800, David Miller wrote:
> From: Nathan Chancellor <natechancellor@gmail.com>
> Date: Mon,  9 Dec 2019 14:16:23 -0700
> 
> > Clang warns:
> > 
> > ../drivers/net/ethernet/dec/tulip/uli526x.c:1812:3: warning: misleading
> > indentation; statement is not part of the previous 'if'
> > [-Wmisleading-indentation]
> >         switch (mode) {
> >         ^
> > ../drivers/net/ethernet/dec/tulip/uli526x.c:1809:2: note: previous
> > statement is here
> >         if (cr6set)
> >         ^
> > 1 warning generated.
> > 
> > ../drivers/net/ethernet/dec/tulip/dmfe.c:2217:3: warning: misleading
> > indentation; statement is not part of the previous 'if'
> > [-Wmisleading-indentation]
> >         switch(mode) {
> >         ^
> > ../drivers/net/ethernet/dec/tulip/dmfe.c:2214:2: note: previous
> > statement is here
> >         if (cr6set)
> >         ^
> > 1 warning generated.
> > 
> > This warning occurs because there is a space before the tab on these
> > lines. Remove them so that the indentation is consistent with the Linux
> > kernel coding style and clang no longer warns.
> > 
> > While we are here, adjust the default block in dmfe_init_module to have
> > a proper break between the label and assignment and add a space between
> > the switch and opening parentheses to avoid a checkpatch warning.
> > 
> > Fixes: e1c3e5014040 ("[PATCH] initialisation cleanup for ULI526x-net-driver")
> > Link: https://github.com/ClangBuiltLinux/linux/issues/795
> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> 
> Applied, but it's really crummy that the tool gets tripped up by the
> fact that a space preceeds the TAB.  It's what the code visually looks
> like, not what exact kinds of SPACE characters were used to get there.

I agree. There is a follow up patch from the author of the warning that
claims to alieviate some of these but that is still in discussion and as
far as I understand it, it won't fix all of them so I'm just dealing
with all of them on the Linux side.

https://reviews.llvm.org/D71037

Thanks for picking them up!
Nathan

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-09 21:16 [PATCH] net: tulip: Adjust indentation in {dmfe,uli526x}_init_module Nathan Chancellor
2019-12-09 21:22 ` Nick Desaulniers
2019-12-10  4:29 ` David Miller
2019-12-10 19:41   ` Nathan Chancellor

Linux-parisc archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-parisc/0 linux-parisc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-parisc linux-parisc/ https://lore.kernel.org/linux-parisc \
		linux-parisc@vger.kernel.org
	public-inbox-index linux-parisc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-parisc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git